Re: [Wicket-user] PageableGridDataView and IDataProvider

2005-11-09 Thread Gili
That worked, thanks :) Gili Igor Vaynberg wrote: oops, not=now. -Igor On 11/8/05, *Igor Vaynberg* <[EMAIL PROTECTED] > wrote: PageableGridDataView is not GridView in extensions. there are only minor incompatibilities with the old dataview package

Re: [Wicket-user] PageableGridDataView and IDataProvider

2005-11-09 Thread Igor Vaynberg
PageableGridDataView is not GridView in extensions. there are only minor incompatibilities with the old dataview package so you should have no problems migrating. the dataview project is no longer in wicket-stuff cvs btw. -Igor On 11/8/05, Eelco Hillenius <[EMAIL PROTECTED]> wrote: I don't know m

Re: [Wicket-user] PageableGridDataView and IDataProvider

2005-11-08 Thread Igor Vaynberg
oops, not=now. -Igor On 11/8/05, Igor Vaynberg <[EMAIL PROTECTED]> wrote: PageableGridDataView is not GridView in extensions. there are only minor incompatibilities with the old dataview package so you should have no problems migrating. the dataview project is no longer in wicket-stuff cvs btw. -

Re: [Wicket-user] PageableGridDataView and IDataProvider

2005-11-08 Thread Christian Essl
The replacement of PageableGridDataView is wicket.extensions.markup.html.repeater.data.GridView On Tue, 8 Nov 2005 21:57:37 -0800, Eelco Hillenius <[EMAIL PROTECTED]> wrote: I don't know much about that package, but afaik the dataview project will be dropped in favor of the extensions projec

Re: [Wicket-user] PageableGridDataView and IDataProvider

2005-11-08 Thread Eelco Hillenius
I don't know much about that package, but afaik the dataview project will be dropped in favor of the extensions project. Eelco On 11/8/05, Gili <[EMAIL PROTECTED]> wrote: > Hi, > > I'm trying to use recompile code that uses PageableGridDataView which > used to work. The problem is that P

[Wicket-user] PageableGridDataView and IDataProvider

2005-11-08 Thread Gili
Hi, I'm trying to use recompile code that uses PageableGridDataView which used to work. The problem is that PageableGridDataView has a constructor which takes in wicket.contrib.dataview.IDataProvider in its constructor but HibernateDataProvider now extends wicket.extensions.markup.html.repea

RE: [Wicket-user] PageableGridDataView

2005-09-12 Thread Igor Vaynberg
Please submit a patch. -Igor > -Original Message- > From: [EMAIL PROTECTED] [mailto:wicket-user- > [EMAIL PROTECTED] On Behalf Of Gili > Sent: Monday, September 12, 2005 3:38 PM > To: [EMAIL PROTECTED] > Subject: [Wicket-user] PageableGridDataView > > Hi, >

[Wicket-user] PageableGridDataView

2005-09-12 Thread Gili
Hi, I recently switched to PageableGridDataView. It's nice, thanks :) I just wanted to recommend you provide more Javadoc for it. It isn't clear from the example code sniplet in the Javadoc that the 1st Wicket tag is user-defined and corresponds to the ID of the PageableGridDataView

RE: [Wicket-user] PageableGridDataView

2005-09-06 Thread Igor Vaynberg
> Johan Compagner > Sent: Tuesday, September 06, 2005 1:44 PM > To: wicket-user@lists.sourceforge.net > Subject: Re: [Wicket-user] PageableGridDataView > > is there an example where i can see this? > > Igor Vaynberg wrote: > > Path not found. Might be something weird t

Re: [Wicket-user] PageableGridDataView

2005-09-06 Thread Johan Compagner
, September 06, 2005 12:58 PM To: wicket-user@lists.sourceforge.net Subject: Re: [Wicket-user] PageableGridDataView what kind of error do you get? Igor Vaynberg wrote: I removed the setStartIndex() and setViewSize() from dataview and setcurrentpage() simply ignores the page if paging is

RE: [Wicket-user] PageableGridDataView

2005-09-06 Thread Igor Vaynberg
t; To: wicket-user@lists.sourceforge.net > Subject: Re: [Wicket-user] PageableGridDataView > > what kind of error do you get? > > > Igor Vaynberg wrote: > > I removed the setStartIndex() and setViewSize() from dataview and > > setcurrentpage() simply ignores the page i

Re: [Wicket-user] PageableGridDataView

2005-09-06 Thread Johan Compagner
back the dataview dataitems to the state they were... -Igor -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Christian Essl Sent: Wednesday, August 31, 2005 9:58 PM To: wicket-user@lists.sourceforge.net Subject: Re: [Wicket-user] PageableGridDataVie

RE: [Wicket-user] PageableGridDataView

2005-09-06 Thread Igor Vaynberg
, 2005 11:29 AM > To: wicket-user@lists.sourceforge.net > Subject: RE: [Wicket-user] PageableGridDataView > > I removed the setStartIndex() and setViewSize() from dataview and > setcurrentpage() simply ignores the page if paging is > disabled instead of throwing illegalstatee

RE: [Wicket-user] PageableGridDataView

2005-09-06 Thread Igor Vaynberg
-Igor > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > Christian Essl > Sent: Wednesday, August 31, 2005 9:58 PM > To: wicket-user@lists.sourceforge.net > Subject: Re: [Wicket-user] PageableGridDataView > > Hi Igor, >

RE: [Wicket-user] PageableGridDataView

2005-09-05 Thread Igor Vaynberg
ECTED] On Behalf Of > Johan Compagner > Sent: Monday, September 05, 2005 2:15 PM > To: wicket-user@lists.sourceforge.net > Subject: Re: [Wicket-user] PageableGridDataView > > what do you mean with bounded page? > most of the time it will just return the page that is the input?

Re: [Wicket-user] PageableGridDataView

2005-09-05 Thread Johan Compagner
Ipageable and having it return the bounded page? -Igor -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Johan Compagner Sent: Monday, September 05, 2005 8:16 AM To: wicket-user@lists.sourceforge.net Subject: Re: [Wicket-user] PageableGridDataView

RE: [Wicket-user] PageableGridDataView

2005-09-05 Thread Igor Vaynberg
t; Sent: Monday, September 05, 2005 8:16 AM > To: wicket-user@lists.sourceforge.net > Subject: Re: [Wicket-user] PageableGridDataView > > just remove those 2 for DataView > I don't think anybody will use them for DataView > > Igor Vaynberg wrote: > > Gili, > >

RE: [Wicket-user] PageableGridDataView

2005-09-05 Thread Igor Vaynberg
That's what I am thinking :) -Igor > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > Johan Compagner > Sent: Monday, September 05, 2005 8:16 AM > To: wicket-user@lists.sourceforge.net > Subject: Re: [Wicket-user] Page

RE: [Wicket-user] PageableGridDataView

2005-09-05 Thread Igor Vaynberg
Gili, You just don't get it. -Igor > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Gili > Sent: Monday, September 05, 2005 8:26 AM > To: wicket-user@lists.sourceforge.net > Subject: Re: [Wicket-use

Re: [Wicket-user] PageableGridDataView

2005-09-05 Thread Gili
PageableListView is a ListView, if it extends it. As for the class hierarchy getting doubled, you wouldn't advocate stuffing setCacheTimeout() into the Resource base-class, would you? This method is obviously specific only to dynamic resources, not all resources, so why force the same "squar

Re: [Wicket-user] PageableGridDataView

2005-09-05 Thread Johan Compagner
EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Gili Sent: Sunday, September 04, 2005 11:27 AM To: wicket-user@lists.sourceforge.net Subject: Re: [Wicket-user] PageableGridDataView It sounds to me like you might be able to use the Strategy design pattern here. Your design (mentioned in a

Re: [Wicket-user] PageableGridDataView

2005-09-05 Thread Johan Compagner
then suddenly the class hierarchy is doubled.. And a PageableListView != ListView anymore. (and all the subclasses that depend on one of those) Gili wrote: Read below... Igor Vaynberg wrote: Gili, All you would be doing is factoring out semantic incompatibilities into the strategy inte

Re: [Wicket-user] PageableGridDataView

2005-09-05 Thread Gili
Read below... Igor Vaynberg wrote: Gili, All you would be doing is factoring out semantic incompatibilities into the strategy interface/impls. In a way the old pageabledataview was a navigation strategy for the regular dataview. Please try to understand the problem. Let me lay it out f

Re: [Wicket-user] PageableGridDataView

2005-09-05 Thread Gili
Gili wrote: If setFirstIndex() does not make sense for all subclasses then it likely does not belong in the subclass. Oops, typo! I meant to say that setFirstIndex() likely does not belong in the *superclass*. Gili --- SF.Net email is Sp

RE: [Wicket-user] PageableGridDataView

2005-09-04 Thread Igor Vaynberg
AM > To: wicket-user@lists.sourceforge.net > Subject: Re: [Wicket-user] PageableGridDataView > > On Sat, 3 Sep 2005 07:48:09 -0700, Igor Vaynberg > <[EMAIL PROTECTED]> > wrote: > > > Doh, > > Now we have two alternative impls, do you mind quickly > comparing the >

RE: [Wicket-user] PageableGridDataView

2005-09-04 Thread Igor Vaynberg
7 AM > To: wicket-user@lists.sourceforge.net > Subject: Re: [Wicket-user] PageableGridDataView > > > It sounds to me like you might be able to use the > Strategy design pattern here. Your design (mentioned in a > previous email) made a lot more sense to me than Igor

Re: [Wicket-user] PageableGridDataView

2005-09-04 Thread Gili
It sounds to me like you might be able to use the Strategy design pattern here. Your design (mentioned in a previous email) made a lot more sense to me than Igor's idea of throwing "unsupported" exceptions. In essense, you could say there are two available navigation strategies so far: linea

Re: [Wicket-user] PageableGridDataView

2005-09-03 Thread Christian Essl
On Sat, 3 Sep 2005 07:48:09 -0700, Igor Vaynberg <[EMAIL PROTECTED]> wrote: Doh, Now we have two alternative impls, do you mind quickly comparing the two and seeing advantages/disadvantages. Not at all. That's what my impl is for. First if there is no use-case than I am also for getting rid

RE: [Wicket-user] PageableGridDataView

2005-09-03 Thread Igor Vaynberg
Doh, Now we have two alternative impls, do you mind quickly comparing the two and seeing advantages/disadvantages. My impl doesn tuse the OIR helper yet which I would like to integrate in the future. > > 1.) IPageable: Paging is always enabled. By default it > behaves like items per page is se

RE: [Wicket-user] PageableGridDataView

2005-09-03 Thread Igor Vaynberg
ginal Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Gili > Sent: Friday, September 02, 2005 10:50 PM > To: wicket-user@lists.sourceforge.net > Subject: Re: [Wicket-user] PageableGridDataView > > > So this gets back to my original point, if yo

Re: [Wicket-user] PageableGridDataView

2005-09-03 Thread Christian Essl
On Fri, 02 Sep 2005 18:04:31 -0400, Gili <[EMAIL PROTECTED]> wrote: What is the reason? The new method sounds very anti-OOP to me. Usually one layers functionality using interfaces. Stuffing them all into the base class but having them throw exceptions when "disabled" sounds a lot like a fl

Re: [Wicket-user] PageableGridDataView

2005-09-03 Thread Christian Essl
On Fri, 2 Sep 2005 14:38:01 -0700, Igor Vaynberg <[EMAIL PROTECTED]> wrote: Just got a bit of time to work on the dataview, it is now itself pageable. I did not know that. Yesterday I've also got some time and tried to implement it (DataView2). I just did not send it because I have not tes

Re: [Wicket-user] PageableGridDataView

2005-09-02 Thread Gili
subclass let me know and I will be happy to do that. -Igor -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Gili Sent: Friday, September 02, 2005 3:05 PM To: wicket-user@lists.sourceforge.net Subject: Re: [Wicket-user] PageableGridDataView What is the

RE: [Wicket-user] PageableGridDataView

2005-09-02 Thread Igor Vaynberg
age- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Gili > Sent: Friday, September 02, 2005 9:45 PM > To: wicket-user@lists.sourceforge.net > Subject: Re: [Wicket-user] PageableGridDataView > > > What are you talking about? I wasn't saying you

Re: [Wicket-user] PageableGridDataView

2005-09-02 Thread Gili
et me know and I will be happy to do that. -Igor -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Gili Sent: Friday, September 02, 2005 3:05 PM To: wicket-user@lists.sourceforge.net Subject: Re: [Wicket-user] PageableGridDataView What is the reaso

RE: [Wicket-user] PageableGridDataView

2005-09-02 Thread Igor Vaynberg
To: wicket-user@lists.sourceforge.net > Subject: Re: [Wicket-user] PageableGridDataView > > > What is the reason? The new method sounds very anti-OOP > to me. Usually one layers functionality using interfaces. > Stuffing them all into the base class but having them throw >

RE: [Wicket-user] PageableGridDataView

2005-09-02 Thread Igor Vaynberg
I am not, that's why I suggested getting rid of them. -Igor > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > Johan Compagner > Sent: Friday, September 02, 2005 3:08 PM > To: wicket-user@lists.sourceforge.net >

Re: [Wicket-user] PageableGridDataView

2005-09-02 Thread Johan Compagner
Of course paging is not as flexible in certain situations as using setStartIndex() and setViewSize() but the question is do we want to trade that flexibility for clarity? yes who is using that in a listview or dataview? setting a startindex i can maybe maybe think of but setting a view size

Re: [Wicket-user] PageableGridDataView

2005-09-02 Thread Gili
What is the reason? The new method sounds very anti-OOP to me. Usually one layers functionality using interfaces. Stuffing them all into the base class but having them throw exceptions when "disabled" sounds a lot like a flat object model to me. Gili Johan Compagner wrote: that is somethi

Re: [Wicket-user] PageableGridDataView

2005-09-02 Thread Johan Compagner
that is something we had.. and want to get rid of i think.. johan Gili wrote: Igor Vaynberg wrote: Yes the support delegate is lazily created. Setcurrentpage() throws illegalstateexception if paging is disabled. Sounds like an anti-pattern to me. Why don't you have a base class without

Re: [Wicket-user] PageableGridDataView

2005-09-02 Thread Gili
Igor Vaynberg wrote: Yes the support delegate is lazily created. Setcurrentpage() throws illegalstateexception if paging is disabled. Sounds like an anti-pattern to me. Why don't you have a base class without Pagable support and a subclass that is Pagable (always) with these methods. Gili

RE: [Wicket-user] PageableGridDataView

2005-09-02 Thread Igor Vaynberg
Just got a bit of time to work on the dataview, it is now itself pageable. > That's a very good idea. I also do not like PageableDataView > with the unsupported methods. Well, some of the methods have to stay locked since they really don't make sense withing the paging context. However, it might

RE: [Wicket-user] PageableGridDataView

2005-09-01 Thread Igor Vaynberg
Will try this out whenever I find a bit of free time. -Igor > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > Christian Essl > Sent: Wednesday, August 31, 2005 9:58 PM > To: wicket-user@lists.sourceforge.net > Subj

Re: [Wicket-user] PageableGridDataView

2005-08-31 Thread Christian Essl
Hi Igor, Thanks for the compliments. I am happy you like it. I was also thinking of getting rid of pageable dataview and introducing enablePaging(int rowsperpage)/disablePaging() into dataview directly. What do you think? +1 That's a very good idea. I also do not like PageableDataView with

RE: [Wicket-user] PageableGridDataView

2005-08-31 Thread Igor Vaynberg
)/disablePaging() into dataview directly. What do you think? -Igor > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > Christian Essl > Sent: Wednesday, August 31, 2005 5:37 AM > To: wicket-user@lists.sourceforge.net >

[Wicket-user] PageableGridDataView

2005-08-31 Thread Christian Essl
As promissed I've tried to implement a PageableGridDataView with OIR support and empty cell fill up. Attached is a patch. There are a few other new classes as well let me explain: By the way doing this I also implemented a PageableOrderedRepeatingView (first I thought I'll base the GridDataVie