[MediaWiki-CodeReview] [MediaWiki r87807]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r87807. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87807#c16762 Commit summary: Commit SemanticFormsToolbar extension Comment: Use $article = new Article( $form, '''0''' );. This thing has caused enough bugs already. ___

[MediaWiki-CodeReview] [MediaWiki r87777]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Bawolff" posted a comment on MediaWiki.r8. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/8#c16761 Commit summary: (follow-up r87593 / bug 28875) Replace calls to makeKnownLink with Linker::link since makeKnownLink was killed in 1.19. Comment: done in r87810

Re: [Wikitech-l] Mediawiki Development IDE

2011-05-09 Thread Ashar Voultoiz
On 09/05/11 18:47, Brion Vibber wrote: > On 09/05/11 15:08, Tod wrote: > > Is there an IDE that the MW developer community has settled on and can > > recommend? > Some hardcore people use a terminal-based editor like vim or emacs by > choice; the best of these are extremely powerful with syntax& n

[MediaWiki-CodeReview] [MediaWiki r87778]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r87778. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87778#c16760 Commit summary: coding style tweaks Comment: Yay for code obfuscation. The rest if fine though. ___ MediaWiki-CodeRevi

[MediaWiki-CodeReview] [MediaWiki r87777]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r8. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/8#c16759 Commit summary: (follow-up r87593 / bug 28875) Replace calls to makeKnownLink with Linker::link since makeKnownLink was killed in 1.19. Comment: Since you changed

[MediaWiki-CodeReview] [MediaWiki r87769]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r87769. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87769#c16758 Commit summary: More silly ternary true : false fixes Comment: Why not $this->nullable = strtolower( $info['IS_NULLABLE'] ) != 'no'; ___

[MediaWiki-CodeReview] [MediaWiki r87779]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r87779. Old Status: fixme New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87779#c0 Commit summary: Fixing logic of stats gathering maintenance script to account for rating sets (the group of ra

[MediaWiki-CodeReview] [MediaWiki r87785]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r87785. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87785#c0 Commit summary: Making it possible to configure a URL to point to a page where discussion can happen about the A

[Wikitech-l] Bug Triage meeting notes

2011-05-09 Thread Mark A. Hershberger
The Berlin Hack-a-thon (http://hexm.de/2o) and a variety of CSS-related bugs possibly caused by the recent IE fixes dominated the discussion durin this week's bug triage. Here's the bugs we discussed and a quick summary of the decided course of action. == Bugsmash == * http://bugzilla.wikimedia

[MediaWiki-CodeReview] [MediaWiki r87785]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r87785. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87785#c16757 Commit summary: Making it possible to configure a URL to point to a page where discussion can happen about the AFT dashboard. Since the dashboard is powered by a

[Wikitech-l] New Committer

2011-05-09 Thread Ryan Lane
Added Asher Feldman (asher) to extensions, core, and deployment. He's a new member of the Operations team. - Ryan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

[MediaWiki-CodeReview] [MediaWiki r87779]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Awjrichards" posted a comment on MediaWiki.r87779. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87779#c16756 Commit summary: Fixing logic of stats gathering maintenance script to account for rating sets (the group of ratings generated when the user hits submit) rather tha

[MediaWiki-CodeReview] [MediaWiki r87779]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r87779. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87779#c0 Commit summary: Fixing logic of stats gathering maintenance script to account for rating sets (the group of ratings generated when

[MediaWiki-CodeReview] [MediaWiki r87779]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Awjrichards" posted a comment on MediaWiki.r87779. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87779#c16755 Commit summary: Fixing logic of stats gathering maintenance script to account for rating sets (the group of ratings generated when the user hits submit) rather tha

Re: [Wikitech-l] Mediawiki Development IDE

2011-05-09 Thread Happy-melon
"Bryan Tong Minh" wrote in message news:BANLkTinddq+HJgTE=4dwc5ofbvnht7p...@mail.gmail.com... > On Mon, May 9, 2011 at 3:08 PM, Tod wrote: >> Is there an IDE that the MW developer community has settled on and can >> recommend? >> > Sam has a license for phpStorm, iirc, available for all MediaWi

[MediaWiki-CodeReview] [MediaWiki r86577]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Mdale" posted a comment on MediaWiki.r86577. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86577#c16754 Commit summary: Added generic bucketing feature to the user object, which handles bucketing users, invalidating bucketing on version changes, tracking and and persistenc

[MediaWiki-CodeReview] [MediaWiki r87775]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r87775. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87775#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-05-09 21:14:00 UTC) __

[MediaWiki-CodeReview] [MediaWiki r87497]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Catrope" posted a comment on MediaWiki.r87497. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87497#c16753 Commit summary: Per bug 28738 comment 4, pack ResourceLoader URLs by encoding foo.bar|foo.baz|bar.baz|bar.quux as foo.bar,baz|bar.baz,quux *

[MediaWiki-CodeReview] [MediaWiki r87497]: New comment added, and revision status changed

2011-05-09 Thread MediaWiki Mail
User "Mdale" changed the status of MediaWiki.r87497. Old Status: new New Status: fixme User "Mdale" also posted a comment on MediaWiki.r87497. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87497#c16752 Commit summary: Per bug 28738 comment 4, pack ResourceLoader URLs by encodin

[MediaWiki-CodeReview] [MediaWiki r87764]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87764. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87764#c0 Commit summary: count the errors and show them next to the submit button (this helps when the errors are scrolled off page) ___

[MediaWiki-CodeReview] [MediaWiki r87771]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87771. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87771#c0 Commit summary: followup to r87764; use simpler jquery selector ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r87410]: New comment added, and revision status changed

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87410. Old Status: new New Status: resolved User "Brion VIBBER" also posted a comment on MediaWiki.r87410. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87410#c16751 Commit summary: obtain URL from page title of alternate upl

[MediaWiki-CodeReview] [MediaWiki r87772]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87772. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87772#c0 Commit summary: followup to r87410 -- trap errors for mw.Title properly ___ MediaWiki-Co

[MediaWiki-CodeReview] [MediaWiki r87752]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "NeilK" changed the status of MediaWiki.r87752. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87752#c0 Commit summary: Minor adjustments in UploadWizard/mw.Utilities * Removing window.mediaWiki > mw alias (already in core) * Removing typeof ch

[MediaWiki-CodeReview] [MediaWiki r87764]: New comment added

2011-05-09 Thread MediaWiki Mail
User "NeilK" posted a comment on MediaWiki.r87764. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87764#c16750 Commit summary: count the errors and show them next to the submit button (this helps when the errors are scrolled off page) Comment: fixed in r87771 _

[MediaWiki-CodeReview] [MediaWiki r87410]: New comment added

2011-05-09 Thread MediaWiki Mail
User "NeilK" posted a comment on MediaWiki.r87410. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87410#c16749 Commit summary: obtain URL from page title of alternate upload form Comment: excellent catch. most people wouldn't go looking for exceptions. :) fixed in r87772 (I tes

[MediaWiki-CodeReview] [MediaWiki r87410]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r87410. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87410#c16748 Commit summary: obtain URL from page title of alternate upload form Comment: Whether this is ok for now depends on whether initial configuration could include a

[MediaWiki-CodeReview] [MediaWiki r87768]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r87768. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87768#c0 Commit summary: Fixing query to select highs/lows from db prior to caching results to return them in the correct

[MediaWiki-CodeReview] [MediaWiki r87767]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r87767. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87767#c0 Commit summary: reverting r87765, brion is right, this excludes too many filenames ___ MediaWi

[MediaWiki-CodeReview] [MediaWiki r87764]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r87764. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87764#c16747 Commit summary: count the errors and show them next to the submit button (this helps when the errors are scrolled off page) Comment: fyi -- should be able to do

[MediaWiki-CodeReview] [MediaWiki r87767]: New comment added

2011-05-09 Thread MediaWiki Mail
User "NeilK" posted a comment on MediaWiki.r87767. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87767#c16746 Commit summary: reverting r87765, brion is right, this excludes too many filenames Comment: except, I can't actually do that. :) __

[MediaWiki-CodeReview] [MediaWiki r87767]: New comment added

2011-05-09 Thread MediaWiki Mail
User "NeilK" posted a comment on MediaWiki.r87767. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87767#c16745 Commit summary: reverting r87765, brion is right, this excludes too many filenames Comment: marking ok since this just restored an earlier version marked ok. _

[MediaWiki-CodeReview] [MediaWiki r87765]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "NeilK" changed the status of MediaWiki.r87765. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87765#c0 Commit summary: make the regexes more like prefixes not full filenames ___ MediaWiki-Co

[MediaWiki-CodeReview] [MediaWiki r87722]: New comment added

2011-05-09 Thread MediaWiki Mail
User "^demon" posted a comment on MediaWiki.r87722. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87722#c16744 Commit summary: do not create console logging div unless configured to do so Comment: Brion marked it ok, you didn't. You can't mark your own revs as ok :) __

[MediaWiki-CodeReview] [MediaWiki r87722]: New comment added, and revision status changed

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87722. Old Status: new New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r87722. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87722#c16743 Commit summary: do not create console logging div unless configur

[MediaWiki-CodeReview] [MediaWiki r87722]: New comment added

2011-05-09 Thread MediaWiki Mail
User "NeilK" posted a comment on MediaWiki.r87722. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87722#c16742 Commit summary: do not create console logging div unless configured to do so Comment: Marking this as "ok" but only for now -- it's a required hack for prod to stop un

[MediaWiki-CodeReview] [MediaWiki r87747]: New comment added, and revision status changed

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87747. Old Status: new New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r87747. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87747#c16741 Commit summary: error recovery on filename errors Comment: Ther

[MediaWiki-CodeReview] [MediaWiki r87722]: New comment added, and revision status changed

2011-05-09 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r87722. Old Status: fixme New Status: new User "Krinkle" also posted a comment on MediaWiki.r87722. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87722#c16740 Commit summary: do not create console logging div unless configured to d

[MediaWiki-CodeReview] [MediaWiki r87766]: New comment added, and revision status changed

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87766. Old Status: new New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r87766. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87766#c16739 Commit summary: error count messages, file extension errors Comm

[MediaWiki-CodeReview] [MediaWiki r87765]: New comment added, and revision status changed

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87765. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r87765. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87765#c16738 Commit summary: make the regexes more like prefixes not full f

[MediaWiki-CodeReview] [MediaWiki r87746]: New comment added, and revision status changed

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87746. Old Status: new New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r87746. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87746#c16737 Commit summary: misc linting issues, removed recoverable errors u

[MediaWiki-CodeReview] [MediaWiki r87410]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r87410. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87410#c16736 Commit summary: obtain URL from page title of alternate upload form Comment: Looks like mw.Title is UploadWizard-specific, not part of MediaWiki core. _

[MediaWiki-CodeReview] [MediaWiki r87410]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r87410. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87410#c16735 Commit summary: obtain URL from page title of alternate upload form Comment: Doesn't check for errors; mw.Title() constructor appears to throw an exception on s

[MediaWiki-CodeReview] [MediaWiki r87725]: New comment added, and revision status changed

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87725. Old Status: new New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r87725. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87725#c16734 Commit summary: precheck commons blacklist (in a hacky way, sans

[MediaWiki-CodeReview] [MediaWiki r87722]: New comment added

2011-05-09 Thread MediaWiki Mail
User "NeilK" posted a comment on MediaWiki.r87722. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87722#c16733 Commit summary: do not create console logging div unless configured to do so Comment: correct, I am just making sure it doesn't get triggered. it causes super ugly div

[MediaWiki-CodeReview] [MediaWiki r87760]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87760. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87760#c0 Commit summary: followup to r87747 - look for labels for id, not name ___ MediaWiki-Code

[MediaWiki-CodeReview] [MediaWiki r87722]: New comment added

2011-05-09 Thread MediaWiki Mail
User "NeilK" posted a comment on MediaWiki.r87722. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87722#c16732 Commit summary: do not create console logging div unless configured to do so Comment: of course I want to fix all doubling. Also I've committed myself to talking about

[MediaWiki-CodeReview] [MediaWiki r87751]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87751. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87751#c0 Commit summary: correct message string ___ MediaWiki-CodeReview mailing list mediawiki-c

[MediaWiki-CodeReview] [MediaWiki r87722]: New comment added

2011-05-09 Thread MediaWiki Mail
User "NeilK" posted a comment on MediaWiki.r87722. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87722#c16731 Commit summary: do not create console logging div unless configured to do so Comment: usually there are real reasons not to reconcile the libraries, or IMO the UW vers

[MediaWiki-CodeReview] [MediaWiki r87592]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87592. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87592#c0 Commit summary: this comment is cryptic and I have not idea what I meant by it ___ Media

[MediaWiki-CodeReview] [MediaWiki r87722]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Krinkle" posted a comment on MediaWiki.r87722. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87722#c16730 Commit summary: do not create console logging div unless configured to do so Comment: I'd go bonkers and fix all doubling between UpWiz modules and core modules, how

Re: [Wikitech-l] Mediawiki Development IDE

2011-05-09 Thread Brion Vibber
On Mon, May 9, 2011 at 12:31 PM, Mark A. Hershberger < mhershber...@wikimedia.org> wrote: > Since no one else has said it: emacs is my choice. I typically use > flymake (http://www.emacswiki.org/emacs/FlyMake) while editing to catch > obvious syntax errors. I've configured emacs so that MW codin

[MediaWiki-CodeReview] [MediaWiki r87722]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Krinkle" posted a comment on MediaWiki.r87722. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87722#c16729 Commit summary: do not create console logging div unless configured to do so Comment: Should probably use the core mw.'''l'''og rather than this copy named mw.'''L''

[MediaWiki-CodeReview] [MediaWiki r87724]: New comment added, and revision status changed

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87724. Old Status: new New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r87724. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87724#c16728 Commit summary: fix spinner, previous version did not spin proper

[MediaWiki-CodeReview] [MediaWiki r87722]: New comment added, and revision status changed

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87722. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r87722. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87722#c16727 Commit summary: do not create console logging div unless confi

Re: [Wikitech-l] Mediawiki Development IDE

2011-05-09 Thread Mark A. Hershberger
Tod writes: > Is there an IDE that the MW developer community has settled on and can > recommend? Since no one else has said it: emacs is my choice. I typically use flymake (http://www.emacswiki.org/emacs/FlyMake) while editing to catch obvious syntax errors. I've configured emacs so that MW

[MediaWiki-CodeReview] [MediaWiki r87747]: New comment added

2011-05-09 Thread MediaWiki Mail
User "NeilK" posted a comment on MediaWiki.r87747. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87747#c16726 Commit summary: error recovery on filename errors Comment: fixed in r87760 ___ MediaWiki-CodeReview mailing list mediawiki-

[MediaWiki-CodeReview] [MediaWiki r82778]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Nikola Smolenski" posted a comment on MediaWiki.r82778. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82778#c16725 Commit summary: Fix outstanding issues Comment: Done in r87753. Also removed caching. ___ MediaWiki-CodeReview m

[MediaWiki-CodeReview] [MediaWiki r86692]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Nikola Smolenski" posted a comment on MediaWiki.r86692. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86692#c16724 Commit summary: CSS, per http://www.mediawiki.org/wiki/Extension:Interlanguage/WMF_Design_Pass Comment: Fixed in r87753. ___

[MediaWiki-CodeReview] [MediaWiki r86692]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Nikola Smolenski" posted a comment on MediaWiki.r86692. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86692#c16723 Commit summary: CSS, per http://www.mediawiki.org/wiki/Extension:Interlanguage/WMF_Design_Pass Comment: Fixed in r87753. ___

Re: [Wikitech-l] AJAX call avoiding CSS error

2011-05-09 Thread Tod
On 05/09/2011 12:25 PM, Krinkle wrote: > Op 9 mei 2011, om 15:05 heeft Tod het volgende geschreven: > >> I'd like to make a call to a service on another server and present the >> results in a mediawiki page. Does the current release of MW (1.16.5 I >> think) have a built in proxy to support this ?

[MediaWiki-CodeReview] [MediaWiki r87747]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r87747. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87747#c16722 Commit summary: error recovery on filename errors Comment: recoverFromError seems to be finding matching fields & labels by finding a match on the 'name' attrib

[MediaWiki-CodeReview] [MediaWiki r87745]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87745. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87745#c0 Commit summary: prevent animation buildup, use stop() ___ MediaWiki-CodeReview mailing l

[MediaWiki-CodeReview] [MediaWiki r83309]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Krinkle" posted a comment on MediaWiki.r83309. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83309#c16721 Commit summary: Fix bug in makeCollapsible. * The instantHide implementation (added in r82471) didn't cover the case where a table is collapsed by default, it needs to

[MediaWiki-CodeReview] [MediaWiki r87340]: New comment added, and revision status changed

2011-05-09 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r87340. Old Status: fixme New Status: new User "Krinkle" also posted a comment on MediaWiki.r87340. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87340#c16720 Commit summary: Moved "printfooter" and debug HTML away from "bodytext"

[MediaWiki-CodeReview] [MediaWiki r87340]: New comment added, and revision status changed

2011-05-09 Thread MediaWiki Mail
User "Krinkle" changed the status of MediaWiki.r87340. Old Status: new New Status: fixme User "Krinkle" also posted a comment on MediaWiki.r87340. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87340#c16719 Commit summary: Moved "printfooter" and debug HTML away from "bodytext"

[MediaWiki-CodeReview] [MediaWiki r85327]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r85327. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85327#c16718 Commit summary: The beginnings of HipHop compiled mode support. It works now for parser cache hits. * Work around HipHop issue 314 (volatile broken) and issue 30

[MediaWiki-CodeReview] [MediaWiki r85944]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r85944. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85944#c16717 Commit summary: Related to bug 28470 (Doxygen not updating) Move require_once( MWInit::compiledPath( 'includes/normal/UtfNormalDefines.php' ) ); to Setup.php Mi

[MediaWiki-CodeReview] [MediaWiki r87468]: New comment added, and revision status changed

2011-05-09 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r87468. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r87468. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87468#c16716 Commit summary: Move CleanUpTest, fixes in next commit Commen

[MediaWiki-CodeReview] [MediaWiki r87734]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Nikerabbit" posted a comment on MediaWiki.r87734. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87734#c16715 Commit summary: Added messaging for above/below high/low tables Comment: addWikiText ( wfMsg() ) -> addWikiMsg() ___ M

[MediaWiki-CodeReview] [MediaWiki r87686]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Kaldari" posted a comment on MediaWiki.r87686. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87686#c16714 Commit summary: Reverted r87521 for now. Couldn't find any documentation that elastic textareas are available in jQuery UI. Comment: Ah, I didn't realize that. Carry

[MediaWiki-CodeReview] [MediaWiki r87735]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r87735. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87735#c0 Commit summary: Smaxage should be 0 when userrating=1 ___ MediaWiki-

Re: [Wikitech-l] Mediawiki Development IDE

2011-05-09 Thread Brion Vibber
On Mon, May 9, 2011 at 6:08 AM, Tod wrote: > Is there an IDE that the MW developer community has settled on and can > recommend? > There is no magic bullet. :) In the early days I mostly used fairly lightweight syntax-highlighting program editors (bbedit on Mac, jedit on Linux/Windows, joe or v

Re: [Wikitech-l] Mediawiki Development IDE

2011-05-09 Thread Bryan Tong Minh
On Mon, May 9, 2011 at 3:08 PM, Tod wrote: > Is there an IDE that the MW developer community has settled on and can > recommend? > Sam has a license for phpStorm, iirc, available for all MediaWiki developers. Bryan ___ Wikitech-l mailing list Wikitech

[MediaWiki-CodeReview] [MediaWiki r87730]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r87730. Old Status: fixme New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87730#c0 Commit summary: Added maxage=0 and smaxage= to the ApiQueryArticleFeedback call and cache purge. _

[MediaWiki-CodeReview] [MediaWiki r87730]: New comment added, and revision status changed

2011-05-09 Thread MediaWiki Mail
User "Awjrichards" changed the status of MediaWiki.r87730. Old Status: new New Status: fixme User "Awjrichards" also posted a comment on MediaWiki.r87730. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87730#c16713 Commit summary: Added maxage=0 and smaxage= to the ApiQueryArtic

[MediaWiki-CodeReview] [MediaWiki r87575]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r87575. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87575#c0 Commit summary: Added squid updateer upon rating, which purges the API call made by the ArticleFeedback fr

Re: [Wikitech-l] Mediawiki Development IDE

2011-05-09 Thread Chad
On Mon, May 9, 2011 at 9:08 AM, Tod wrote: > Is there an IDE that the MW developer community has settled on and can > recommend? > Depends on who you ask. Dmitriy pointed out vim and Eclipse. I personally use Netbeans when I want a full IDE, and I know a few other people who do as well. For quic

[MediaWiki-CodeReview] [MediaWiki r77374]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Catrope" posted a comment on MediaWiki.r77374. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/77374#c16712 Commit summary: (bug 25638) Allow manual associating and dissociating of follow-up revisions in CodeReview. This has a bug: you have to click

[MediaWiki-CodeReview] [MediaWiki r87482]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Catrope" posted a comment on MediaWiki.r87482. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87482#c16711 Commit summary: * Fix for bug 28534: IE 6 content type detection again * Fix for bug 28639: user object instance cache pollution * Release note

Re: [Wikitech-l] AJAX call avoiding CSS error

2011-05-09 Thread Krinkle
Op 9 mei 2011, om 15:05 heeft Tod het volgende geschreven: > I'd like to make a call to a service on another server and present the > results in a mediawiki page. Does the current release of MW (1.16.5 I > think) have a built in proxy to support this ? > > > Thanks - Tod Using a serverside proxy

Re: [Wikitech-l] Mediawiki Development IDE

2011-05-09 Thread Dmitriy Sintsov
* Tod [Mon, 09 May 2011 09:08:43 -0400]: > Is there an IDE that the MW developer community has settled on and can > recommend? > > tip-toeing softly away from the list > Lots of MediaWiki source files contain the following lines: if (!defined('MEDIAWIKI')) { // Eclipse helper - will b

[MediaWiki-CodeReview] [MediaWiki r87719]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Awjrichards" posted a comment on MediaWiki.r87719. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87719#c16710 Commit summary: ArticleFeedback: Fix for r87522: SpecialPageFactory doesn't exist in 1.17wmf1. Instead, call the function statically. Comment: Thanks for fixing

[MediaWiki-CodeReview] [MediaWiki r87714]: New comment added, and revision status changed

2011-05-09 Thread MediaWiki Mail
User "Siebrand" changed the status of MediaWiki.r87714. Old Status: fixme New Status: ok User "Siebrand" also posted a comment on MediaWiki.r87714. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87714#c16709 Commit summary: delete some unused translations and remove an empty loo

[MediaWiki-CodeReview] [MediaWiki r87720]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Siebrand" changed the status of MediaWiki.r87720. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87720#c0 Commit summary: remove PHP4-ism ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...

[MediaWiki-CodeReview] [MediaWiki r87381]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r87381. Old Status: fixme New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87381#c0 Commit summary: Now actually determing only the top and bottom 50 rated pages __

[MediaWiki-CodeReview] [MediaWiki r87379]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r87379. Old Status: fixme New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87379#c0 Commit summary: Follow up r87310; Adding index to timestamp files in article_feedback and article_feedba

[MediaWiki-CodeReview] [MediaWiki r87402]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r87402. Old Status: fixme New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87402#c0 Commit summary: Added caching of latest highs/lows in high/low populating maintenance script; Added data

[MediaWiki-CodeReview] [MediaWiki r87310]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r87310. Old Status: fixme New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87310#c0 Commit summary: Adding sql to create table for article feedback stats relating to high/low article ratin

[MediaWiki-CodeReview] [MediaWiki r87714]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Faure.thomas" posted a comment on MediaWiki.r87714. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87714#c16708 Commit summary: delete some unused translations and remove an empty loop in JS file. Comment: done in revision 87720. _

[MediaWiki-CodeReview] [MediaWiki r87522]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r87522. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/87522#c0 Commit summary: Followup r87402, r87381, r87379 * Functionalized creation of array data store for highs/lo

[MediaWiki-CodeReview] [MediaWiki r87714]: New comment added, and revision status changed

2011-05-09 Thread MediaWiki Mail
User "Siebrand" changed the status of MediaWiki.r87714. Old Status: new New Status: fixme User "Siebrand" also posted a comment on MediaWiki.r87714. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87714#c16707 Commit summary: delete some unused translations and remove an empty lo

[MediaWiki-CodeReview] [MediaWiki r85815]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r85815. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85815#c0 Commit summary: Added from-name for outgoing emails. Fixed API syntax errors and use of affectedRows (was

[MediaWiki-CodeReview] [MediaWiki r85811]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r85811. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85811#c0 Commit summary: (part 2 of 2 - see r85810) Fixed schema issues, syntax errors in the schema update code, made pa

[MediaWiki-CodeReview] [MediaWiki r85810]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r85810. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85810#c0 Commit summary: Fixed schema issues, syntax errors in the schema update code, made path to SQL file absolute (by

[MediaWiki-CodeReview] [MediaWiki r85707]: Revision status changed

2011-05-09 Thread MediaWiki Mail
User "Catrope" changed the status of MediaWiki.r85707. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/85707#c0 Commit summary: Creating new extension for collecting and verifying email addresses. This code is nearly complet

[MediaWiki-CodeReview] [MediaWiki r87706]: New comment added

2011-05-09 Thread MediaWiki Mail
User "Reedy" posted a comment on MediaWiki.r87706. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87706#c16706 Commit summary: Revert SQLite-related part of r87357: sauses SLQ errors, not needed Comment: In Soviet Russia, Holiday has you? ___

[MediaWiki-CodeReview] [MediaWiki r87706]: New comment added

2011-05-09 Thread MediaWiki Mail
User "MaxSem" posted a comment on MediaWiki.r87706. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87706#c16705 Commit summary: Revert SQLite-related part of r87357: sauses SLQ errors, not needed Comment: a) Today is Russia's national holiday b) no _

Re: [Wikitech-l] AJAX call avoiding CSS error

2011-05-09 Thread Bryan Tong Minh
On Mon, May 9, 2011 at 3:05 PM, Tod wrote: > I'd like to make a call to a service on another server and present the > results in a mediawiki page.  Does the current release of MW (1.16.5 I > think) have a built in proxy to support this ? > No. Writing one should be trivial, but currently I don't b

[Wikitech-l] Mediawiki Development IDE

2011-05-09 Thread Tod
Is there an IDE that the MW developer community has settled on and can recommend? tip-toeing softly away from the list Thanks - Tod ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l

  1   2   >