[PATCH 1/7] WINGs: WMIsPL* functions return False if proplist is null.

in this case. --- WINGs/proplist.c | 20 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/WINGs/proplist.c b/WINGs/proplist.c index 5f68eace..55188964 100644 --- a/WINGs/proplist.c +++ b/WINGs/proplist.c @@ -1253,22 +1253,34 @@ int WMGetPropListItemCount(WMPropList * plist

[PATCH] WINGs: Set widget background pixmaps before realization.

, the background pixel takes precendence over the background pixmap. We fix this by setting CWBackPixel to 0 when setting CWBackPixmap to 1 and vice versa. --- WINGs/wview.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/WINGs/wview.c b/WINGs/wview.c index 610e640..0667458 100644 --- a/WINGs/wview.c

[PATCH 1/4] WINGs/wrlib: Remove deprecated get-*-flags scripts.

These have been replaced by pkg-config. Christophe left a note in January 2015 to remove them, and this time has now passed. --- WINGs/Makefile.am | 2 -- WINGs/get-wings-flags | 33 - WINGs/get-wutil-flags | 33 - doc

[PATCH 1/4] WINGs: Updated news with the API changes that occured between 0.95.6 and 0.95.7

Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/NEWS | 45 + 1 file changed, 45 insertions(+) diff --git a/WINGs/NEWS b/WINGs/NEWS index d1bfa7b..1c94845 100644 --- a/WINGs/NEWS +++ b/WINGs/NEWS @@ -155,6 +155,41 @@ wshellquote ADDED

[PATCH 2/4] WINGs: ran spell checker on the NEWS file

The command used was: aspell --lang=en_GB check WINGs/NEWS Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/NEWS | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/WINGs/NEWS b/WINGs/NEWS index 1c94845..c5afb8d 100644 --- a/WINGs/NEWS +++ b

[PATCH 3/4] WINGs: fix non-portable int conversion for printf in font panel size handling

, so the compiler knows what is happening and printf always gets the 'int' it expects. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/wfontpanel.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/WINGs/wfontpanel.c b/WINGs/wfontpanel.c index

[PATCH 6/9] WINGs: create a new type of Tri-State Switch Button (to doc)

to application as '-1'. The implementation was done in order to not break the binary API. The version have been incremented in the WINGs header to reflect the change, but not the version in the 'configure.ac' because that have already been done in commit c6e323e75d for the next Window Maker release

Re: [PATCH] WINGs: trivial fixes in text strings

On Tue, 28 Apr 2015 at 14:39:43 +0200, Alwin wrote: Fixing typos and/or inconsistencies in error messages. Some backports for the Dutch .po file. - WMenuParserError(parser, _(too many nested macro expansion, breaking loop) ); +

[PATCH] WINGs: trivial fixes in text strings

Fixing typos and/or inconsistencies in error messages. Some backports for the Dutch .po file. --- WINGs/dragcommon.c| 4 ++-- WINGs/dragsource.c| 2 +- WINGs/menuparser.c| 12 +- WINGs/menuparser_macros.c | 4 ++-- WINGs/po/cs.po| 8 +++ WINGs

[PATCH] WINGs: removing some spaces

`# ./checkpatch.pl 00*' reported (4x): ERROR: space prohibited before that close parenthesis ')' --- WINGs/menuparser.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/WINGs/menuparser.c b/WINGs/menuparser.c index 7c4e875..a2c9678 100644 --- a/WINGs/menuparser.c +++ b

[PATCH 08/12] WINGs: remove useless function call in WColorPanel (Coverity #109617)

christophe.cu...@free.fr --- WINGs/wcolorpanel.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/WINGs/wcolorpanel.c b/WINGs/wcolorpanel.c index f23c91d..8aea1df 100644 --- a/WINGs/wcolorpanel.c +++ b/WINGs/wcolorpanel.c @@ -2867,8 +2867,6 @@ static void customSetPalette(W_ColorPanel * panel

[PATCH 03/12] WINGs: fix memory leak in WMSubtractPLDictionaries (Coverity #50128)

As pointed by Coverity, a temporary proplist is created with the list of keys to be removed from the source proplist, but this temporary proplist was not released at the end, leaking memory. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/proplist.c | 1 + 1 file changed, 1

Re: [PATCH 03/23] WINGs: mark the script 'get-wings-flags' as deprecated

Hi Douglas, - Douglas Torrance dtorra...@monmouthcollege.edu a écrit : Hi Christophe, On 04/06/2015 10:57 AM, Christophe CURIS wrote: --- a/doc/get-wings-flags.1 +++ b/doc/get-wings-flags.1 [...] +.R WINGs I'm getting the following warnings when I run man --warnings ./get

Re: [PATCH 03/23] WINGs: mark the script 'get-wings-flags' as deprecated

Hi Christophe, On 04/06/2015 10:57 AM, Christophe CURIS wrote: --- a/doc/get-wings-flags.1 +++ b/doc/get-wings-flags.1 @@ -1,32 +1,32 @@ .TH get-wings-flags 1 22 March 2005 .SH NAME -\fBget-wings-flags\fR \- output libWINGs compile and linker flags +\fBget-wings-flags\fP \- output

[PATCH 03/23] WINGs: mark the script 'get-wings-flags' as deprecated

(and spell-checked). Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- .gitignore | 1 - WINGs/Makefile.am| 17 +++-- WINGs/get-wings-flags| 33 + WINGs/get-wings-flags.in | 31 --- doc/get

[PATCH 4/4] WINGs: add version script to hide non-public API symbols from WUtil and WINGS

not increment CURRENT because it has already been done for the next release. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- .gitignore| 2 ++ WINGs/Makefile.am | 22 ++ configure.ac | 2 +- 3 files changed, 25 insertions(+), 1 deletion(-) diff --git

[PATCH 3/4] WINGs: move declaration from WINGs.h into WUtil for consistency

the declaration from WINGs.h to the WUtil.h header to be consistent with what is really done; This will not break backward compatibility because WINGs.h starts by including the WUtil.h header, so on source side it is equivalent. Versions for WUtil and WINGs are, of course, not changed then as the whole

Re: [PATCH 3/4] WINGs: move declaration from WINGs.h into WUtil for consistency

On Mon, 5 Jan 2015 at 11:06:32 +0100, Christophe CURIS wrote: For historical reason, some functions defined in WINGs.h are actually compiled into the WUtil.so library. Although it would be better to compile them in the appropriate library instead (and fix the code accordingly to make it

Re: [PATCH 3/4] WINGs: move declaration from WINGs.h into WUtil for consistency

there are a lot of app left, but on the other hand the change would impact apps that use only WUtil, not WINGs, and that's probably even less... Will see what I can do (I already started to look at it, but stopped considereing the compatibility break). Patch 1 and 2 are still valid, though

RE: [PATCH 3/4] WINGs: move declaration from WINGs.h into WUtil for consistency

From: Carlos R. Mafra [crma...@gmail.com] Sent: Monday, January 05, 2015 9:39 AM To: wmaker-dev@lists.windowmaker.org Subject: Re: [PATCH 3/4] WINGs: move declaration from WINGs.h into WUtil for consistency I suppose not too many programs use

Re: [PATCH 3/4] WINGs: move declaration from WINGs.h into WUtil for consistency

know any? WPrefs? Ok, that was an easy one ;-) I don't think there are a lot of app left, but on the other hand the change would impact apps that use only WUtil, not WINGs, and that's probably even less... There's wdm, I've just realized. wdm stopped working for me in my openSUSE a long

Re: [PATCH 3/4] WINGs: move declaration from WINGs.h into WUtil for consistency

Carlos R. Mafra schreef: There's wdm, I've just realized. wdm stopped working for me in my openSUSE a long time ago (probably because of systemd but I'm not sure). I'd like to ask if anyone is using it currently in a modern distro, but I think that unless wdm development comes back and we

Re: [PATCH 1/4] WINGs: add functions to set widget background image

ok patch enclosed. Carlos could you please amend commit 467b7ee4560f124f7469a2a630cb35d477cc0444 ? thx, david [PATCH] WINGs: increment version This patch is incrementing version number as the API changed. --- WINGs/WINGs/WINGs.h | 2 +- configure.ac| 4 ++-- 2 files changed, 3

Re: [PATCH 1/4] WINGs: add functions to set widget background image

amend commit 467b7ee4560f124f7469a2a630cb35d477cc0444 ? thx, david [PATCH] WINGs: increment version This patch is incrementing version number as the API changed. --- WINGs/WINGs/WINGs.h | 2 +- configure.ac| 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCH 1/4] WINGs: add functions to set widget background image

On Sun, Dec 07, 2014 at 10:01:17AM +0800, David Maciejak wrote: I agree with you Rodolfo that it should be better to increase the minor version number instead. This is not just numbers after .so.. And was a bit wrong, AGE should also be increased. From info libtool: So, libtool library

Re: [PATCH 1/4] WINGs: add functions to set widget background image

On Fri, Dec 05, 2014 at 10:13:34AM +0800, David Maciejak wrote: -WINGS_CURRENT=3 +WINGS_CURRENT=4 WINGS_REVISION=0 WINGS_AGE=0 I should read more docs, before suggesting. WINGS_AGE should also be increased according to info libtool... -- Regards,-- Sir Raorn. ---

[PATCH 05/23] WINGs: remove the macro DEFAULT_TITLE because it is not used

As pointed by gcc, the macro is not used, that is probably because it is totally ok to never provide a title from X point of view, so there is now reason to fall back to that empty constant. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/wwindow.c | 1 - 1 file changed, 1

[PATCH 06/23] WINGs: remove constants used for default width+height for the widget

...@free.fr --- WINGs/wscroller.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/WINGs/wscroller.c b/WINGs/wscroller.c index 4a5ae8c..f1daa3a 100644 --- a/WINGs/wscroller.c +++ b/WINGs/wscroller.c @@ -64,8 +64,6 @@ typedef struct W_Scroller { } flags; } Scroller; -#define

[PATCH 09/23] WINGs: remove dead code from 'loadPixmaps'

then removes that dead code, but keeps the image as part of the WINGs resource for the case where an application would have been using it. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/widgets.c | 13 - 1 file changed, 13 deletions(-) diff --git a/WINGs/widgets.c b/WINGs

[PATCH 07/23] WINGs: remove unused constant DEFAULT_BORDER_WIDTH in wcolorwell

As pointed by gcc, this constant is not used anywhere, and it looks like it have always been the case. As there's no reason to specifically add a border to this widget, remove the constant. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/wcolorwell.c | 1 - 1 file changed, 1

[PATCH 10/23] WINGs: remove macro ABS_SHIFT from the wcolorpanel code

it. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/wcolorpanel.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/WINGs/wcolorpanel.c b/WINGs/wcolorpanel.c index 0b3fc15..9cb004e 100644 --- a/WINGs/wcolorpanel.c +++ b/WINGs/wcolorpanel.c @@ -3525,9 +3525,6 @@ static void

Re: [PATCH 1/4] WINGs: add functions to set widget background image

I agree with you Rodolfo that it should be better to increase the minor version number instead. On Saturday, December 6, 2014, Rodolfo García Peñas k...@kix.es wrote: Hi, I think is better increase the REVISION number instead of the WINGS_CURRENT when we are *adding* new functions. The new

Re: [PATCH 1/4] WINGs: add functions to set widget background image

Hi, I think is better increase the REVISION number instead of the WINGS_CURRENT when we are *adding* new functions. The new revision has backward compatibility with previous versions of wmaker, so IMO is better hold the library version number. We should avoid remove functions, because other

[PATCH 1/4] WINGs: add functions to set widget background image

With this patch we can set widget background image. As now, only background color was available. --- WINGs/WINGs/WINGs.h | 4 WINGs/WINGs/WINGsP.h | 4 WINGs/widgets.c | 15 +++ WINGs/wmisc.c| 14 +++--- WINGs/wview.c| 17 - 5

Re: [PATCH 1/4] WINGs: add functions to set widget background image

On Thu, Dec 04, 2014 at 04:08:41PM +0800, David Maciejak wrote: +void WMSetWidgetBackgroundPixmap(WMWidget *w, WMPixmap *pix); + +WMPixmap *WMGetWidgetBackgroundPixmap(WMWidget *w); + New public functions are added to the library. WINGS_VERSION should be changed as described in info libtool

Re: [PATCH 1/4] WINGs: add functions to set widget background image

info) - increment WINGS_CURRENT and set WINGS_REVISION to 0. -- Regards,-- Sir Raorn. --- https://plus.google.com/+AlexeyFroloff 0001-WINGs-increment-version.patch Description: Binary data

[PATCH 1/1] WINGs: fix infinite loop when using Pango on string that have to be split

From: Christophe CURIS christophe.cu...@free.fr As reported by Charles Philip Chan, WPrefs would get into infinite loop when the support for Pango is enabled. The problem is due to long strings that are broken into multiple lines by WINGs. This is done in an iterative process in the internal

[PATCH 03/16] WINGs: fix possible problems due to sign extension when setting Icon (Coverity #50202)

as possible unsigned types and by using explicit types conversion instead of counting on the wrong implicit type conversion done by the language. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/wwindow.c | 20 1 file changed, 12 insertions(+), 8 deletions

[PATCH 02/16] WINGs: to not allocate memory for a short lived array (Coverity #50136)

fragmentation. Instead, we use now memory on the stack which is more efficient. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/wtext.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/WINGs/wtext.c b/WINGs/wtext.c index 5981de3..93090e4 100644

[PATCH 01/16] WINGs: fix WMPathForResourceOfType to check for all the paths it claims to check

From: Christophe CURIS christophe.cu...@free.fr The documentation of the function claims to check for the resource in a number of path, but factually if the application did provide its argument list when creating the WINGs App structure (which is likely) then the search would stop before checking

[PATCH 06/32] WINGs: fix possible null pointer dereference in W_RealizeView (Coverity #50060)

From: Christophe CURIS christophe.cu...@free.fr As pointed by Coverity, the function makes use of a pointer which may be null, so we have to properly check that to ensure application will not crash. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/wview.c | 6 ++ 1 file

[PATCH 05/32] WINGs: removed unnecessary size checks in WMGetBrowserPaths

. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/wbrowser.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/WINGs/wbrowser.c b/WINGs/wbrowser.c index 4027c2e..0475611 100644 --- a/WINGs/wbrowser.c +++ b/WINGs/wbrowser.c @@ -781,11 +781,7 @@ WMArray

[PATCH 04/32] WINGs: inverted the direction for mouse wheel on WMSliders

From: Christophe CURIS christophe.cu...@free.fr The original choice may have looked mathematically correct, but it was actually counter-intuitive and opposite to what every other application do with sliders. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/wslider.c | 8

[PATCH 2/3] WINGs: Fix unused parameter compiler warnings in examples.

--- WINGs/Examples/colorpick.c | 1 + WINGs/Examples/fontl.c | 2 ++ WINGs/Examples/puzzle.c| 3 +++ 3 files changed, 6 insertions(+) diff --git a/WINGs/Examples/colorpick.c b/WINGs/Examples/colorpick.c index 24daa2c..3d6a2dc 100644 --- a/WINGs/Examples/colorpick.c +++ b/WINGs/Examples

[PATCH 1/3] WINGs: Link examples against Xlib.

The font lister WINGs example program was failing to build because it uses the XOpenDisplay() function from Xlib. --- WINGs/Examples/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WINGs/Examples/Makefile.am b/WINGs/Examples/Makefile.am index 4ddaaf2..cfab01f

[PATCH 3/3] WINGs: Avoid cast from pointer to integer of different size compiler warnings.

--- WINGs/Examples/fontl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/WINGs/Examples/fontl.c b/WINGs/Examples/fontl.c index 4f4eaab..a440a22 100644 --- a/WINGs/Examples/fontl.c +++ b/WINGs/Examples/fontl.c @@ -23,6 +23,7 @@ #include stdint.h #include WINGs/WINGs.h

[PATCH] WINGs: Fix decimal/hexadecimal conversion bug in color panel.

In particular, the values were only being converted when the RGB slider was used to pick the color. If another tool was used, e.g., the magnifying glass, th e value was assumed to be decimal, even if hexadecimal was selected. --- WINGs/wcolorpanel.c | 16 +--- 1 file changed, 13

[PATCH 02/13] WINGs: add const to return value that must not be modified

with f01852f079c402b54180d1d08e96d95d4b3f5049) --- WINGs/WINGs/WINGs.h | 2 +- WINGs/wbutton.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/WINGs/WINGs/WINGs.h b/WINGs/WINGs/WINGs.h index 48ffa42..8cb0144 100644 --- a/WINGs/WINGs/WINGs.h +++ b/WINGs/WINGs/WINGs.h @@ -1069,7 +1069,7 @@ void

[PATCH 01/13] WINGs: fix possible crash with Pango reported by Zoltan BALATON

From: Christophe CURIS christophe.cu...@free.fr (merge with 21a882ef9abc115812e11f9a0f40f30018228b24) --- WINGs/wfont.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/WINGs/wfont.c b/WINGs/wfont.c index 32bb613..a5cff07 100644 --- a/WINGs/wfont.c +++ b

[PATCH 1/2] Add optional Pango text layout support to WINGs

Currently WINGs renders text using Xft directly which does not support any advanced text layout that is needed for scripts like Arabic or Indic scripts (or even things like automatic ligature support for Latin script). With Pango we also get text fallback for free, so no more square boxes

[PATCH 1/2] Add optional Pango text layout support to WINGs

Currently WINGs renders text using Xft directly which does not support any advanced text layout that is needed for scripts like Arabic or Indic scripts (or even things like automatic ligature support for Latin script). With Pango we also get text fallback for free, so no more square boxes

[PATCH 1/3] WINGs: merge hashtable duplicate code

This patch is adding a new static function hashGetItem to factorize some code. --- WINGs/hashtable.c | 50 +++--- 1 file changed, 19 insertions(+), 31 deletions(-) diff --git a/WINGs/hashtable.c b/WINGs/hashtable.c index c4c8214..2620c78 100644

[PATCH 2/3] WINGs: merge bagtree duplicate code

This patch is adding a new static function treeDeleteNode to factorize some code. --- WINGs/bagtree.c | 38 +- 1 file changed, 9 insertions(+), 29 deletions(-) diff --git a/WINGs/bagtree.c b/WINGs/bagtree.c index 25ac080..4b3062c 100644 --- a/WINGs/bagtree.c

[PATCH] WINGs: merge duplicate code from wtext

This patch is saving about 30 duplicate code lines from WMPrependTextBlock and WMAppendTextBlock to create a static fct called prepareTextBlock. --- WINGs/wtext.c | 50 +++--- 1 file changed, 15 insertions(+), 35 deletions(-) diff --git a/WINGs

Re: [PATCH] WINGs/Tests: make them compile again

wrote: Hi David, this patch included an extra space at the end of the new line. Cheers, kix David Maciejak david.macie...@gmail.com escribió: This patch is adding the missing X11 libs reference. --- diff --git a/WINGs/Tests/Makefile.am b/WINGs/Tests/Makefile.am index de6070e..8be4edb

[PATCH 1/4] WINGs: correct possible null pointer dereference

As reported by cppcheck: [WINGs/array.c:129] - [WINGs/array.c:131]: (warning) Possible null pointer dereference: array - otherwise it is redundant to check it against null. [WINGs/array.c:151] - [WINGs/array.c:153]: (warning) Possible null pointer dereference: array - otherwise it is redundant

[PATCH] WINGs/Tests: make them compile again

This patch is adding the missing X11 libs reference. --- diff --git a/WINGs/Tests/Makefile.am b/WINGs/Tests/Makefile.am index de6070e..8be4edb 100644 --- a/WINGs/Tests/Makefile.am +++ b/WINGs/Tests/Makefile.am @@ -6,7 +6,7 @@ noinst_PROGRAMS = wtest wmquery wmfile testmywidget LDADD

[PATCH 05/16] WINGs: optimisations to 'WMReadPropListFromPipe'

of data to avoid searching it for next read. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/proplist.c | 43 +-- 1 file changed, 25 insertions(+), 18 deletions(-) diff --git a/WINGs/proplist.c b/WINGs/proplist.c index beb209d..174edbe

[PATCH] WINGs: fix duplicate if/else branch in W_LookupString

cppcheck is reporting the msg below: [../WINGs/winputmethod.c:215] - [../WINGs/winputmethod.c:209]: (style) Found duplicate branches for 'if' and 'else'. The patch is fixing it by setting a default return call. diff --git a/WINGs/winputmethod.c b/WINGs/winputmethod.c index 7d3aae0..26bc4a1

[PATCH] WINGs: Click on colored portion of color well also opens color panel.

The color well contains two views: view, consisting of the outer button, and colorView, consisting of the color itself. Previously, only clicking on view would bring up the corresponding color panel, resulting in nonintuitive behavior. --- WINGs/wcolorwell.c | 2 ++ 1 file changed, 2 insertions

Re: [PATCH] WINGs: Click on colored portion of color well also opens color panel.

behavior. Thanks a lot Doug! --- a/WINGs/wcolorwell.c +++ b/WINGs/wcolorwell.c @@ -151,6 +151,8 @@ WMColorWell *WMCreateColorWell(WMWidget * parent) WMCreateDragHandler(cPtr-colorView, handleDragEvents, cPtr); WMCreateEventHandler(cPtr-view, ButtonPressMask, handleActionEvents, cPtr

[PATCH 01/11] WINGs: Value stored to 'columnX' is never read

Signed-off-by: Amadeusz Sławiński am...@asmblr.net --- WINGs/wbrowser.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/WINGs/wbrowser.c b/WINGs/wbrowser.c index d390407..03b75ad 100644 --- a/WINGs/wbrowser.c +++ b/WINGs/wbrowser.c @@ -375,8 +375,6 @@ void WMSetBrowserTitled(WMBrowser * bPtr

[PATCH 10/11] WINGs: Value stored to 'fh'|'fy' is never read

Signed-off-by: Amadeusz Sławiński am...@asmblr.net --- WINGs/wframe.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/WINGs/wframe.c b/WINGs/wframe.c index 38547e7..336f839 100644 --- a/WINGs/wframe.c +++ b/WINGs/wframe.c @@ -82,9 +82,6 @@ static void paintFrame(Frame * fPtr

[PATCH 07/11] WINGs: Value stored to 'aw' is never read

Signed-off-by: Amadeusz Sławiński am...@asmblr.net --- WINGs/wpanel.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/WINGs/wpanel.c b/WINGs/wpanel.c index 1c1d04f..6e2f9f4 100644 --- a/WINGs/wpanel.c +++ b/WINGs/wpanel.c @@ -545,13 +545,11 @@ WMGenericPanel *WMCreateGenericPanel(WMScreen

Re: [PATCH 09/11] WINGs: Value stored to 'found' is never read

On Sun, 18 May 2014 14:54:22 +0100 Carlos R. Mafra crma...@gmail.com wrote: On Sun, 18 May 2014 at 13:32:48 +0200, Amadeusz Sławiński wrote: Signed-off-by: Amadeusz Sławiński am...@asmblr.net --- WINGs/wfilepanel.c | 1 - 1 file changed, 1 deletion(-) diff --git a/WINGs

[PATCH 00/15] WINGs: fixes for stuff reported by Coverity

From: Christophe CURIS christophe.cu...@free.fr Hello, This serie of patch fixes the code in WINGs toolkit that are related to 17 bugs reported by Coverity. 5 bugs should have been fixed from WUtil fixes (commit 515fb74c0c). It does not fix everything, there are 5 more bugs which will probably

[PATCH 03/15] WINGs: fix check for NULL pointer in WMText selection (Coverity #50067)

to avoid crash, and includes a log message to help debug if the case happens. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/wtext.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/WINGs/wtext.c b/WINGs/wtext.c index 5fcf40c..8641840 100644 --- a/WINGs

[PATCH 02/15] WINGs: do not crash on NULL title in WMSetWindowTitle (Coverity #50046)

, the correct way is to provide as we're not able to remove a title. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/wwindow.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/WINGs/wwindow.c b/WINGs/wwindow.c index e600f89..5293f87 100644 --- a/WINGs

[PATCH 01/15] WINGs: remove unreachable code in paintMenuEntry (Coverity #50042)

From: Christophe CURIS christophe.cu...@free.fr As pointed by coverity, the case 'index 0' cannot be true because it was already earlier and handled with an early return. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/wpopupbutton.c | 2 -- 1 file changed, 2 deletions

[PATCH 05/15] WINGs: fix memory leak in WMGetBrowserPaths (Coverity #50111)

From: Christophe CURIS christophe.cu...@free.fr As reported by Coverity, in the (rare) case where the wstrlcat would fail the array for the result would not be freed before returning. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/wbrowser.c | 1 + 1 file changed, 1

[PATCH 06/15] WINGs: fix memory leak in WMCreateTextForDocumentType (Coverity #50118)

From: Christophe CURIS christophe.cu...@free.fr As pointed by Coverity, a temporary WMArray was not freed after use. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/wtext.c | 1 + 1 file changed, 1 insertion(+) diff --git a/WINGs/wtext.c b/WINGs/wtext.c index 8641840

[PATCH 08/15] WINGs: fix memory leak in requestHandler (Coverity #50135)

From: Christophe CURIS christophe.cu...@free.fr As pointed by Coverity, the data returned by WMGetTextSelectedStream are actually a newly allocated buffer, so we need to release it when we're done with it. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/wtext.c | 1 + 1 file

[PATCH 11/15] WINGs: fix incorrect usage of direction variable in updateStartForCurrentTextBlock (Coverity #50192)

have been on the value, not on the pointer. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/wtext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/WINGs/wtext.c b/WINGs/wtext.c index 495be70..c112fbe 100644 --- a/WINGs/wtext.c +++ b/WINGs/wtext.c @@ -581,7

[PATCH 09/15] WINGs: fix memory leak in requestHandler (Coverity #50136)

From: Christophe CURIS christophe.cu...@free.fr As pointed by Coverity, the allocated temporary storage was not freed. As an allocation is not needed here, replaced by a local storage. --- WINGs/wtextfield.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/WINGs

[PATCH 12/15] WINGs: fix check for NULL pointer in WMFilePanel (Coverity #50195)

is not NULL. The check is moved to where it matters. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/wfilepanel.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/WINGs/wfilepanel.c b/WINGs/wfilepanel.c index 0f12819..be604d7 100644 --- a/WINGs/wfilepanel.c

[PATCH 13/15] WINGs: fix possible NULL pointer dereference (Coverity #50197)

and reduce the lifespan of 'textLen' to highlight incorrect tries to use the variable. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/wbrowser.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/WINGs/wbrowser.c b/WINGs/wbrowser.c index 8d1858a..02e906e

[PATCH 14/15] WINGs: fix probable crash in drag'n'drop (Coverity #50264)

christophe.cu...@free.fr --- WINGs/dragdestination.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/WINGs/dragdestination.c b/WINGs/dragdestination.c index 2dba64a..2833b88 100644 --- a/WINGs/dragdestination.c +++ b/WINGs/dragdestination.c @@ -974,8 +974,6 @@ void

[PATCH 15/15] WINGs: removed unnecessary gotos in handleTextKeyPress

From: Christophe CURIS christophe.cu...@free.fr When the condition can be simply checked in an if, it is better to do that than to use a flow breaking goto. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/wtext.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions

[PATCH 10/15] WINGs: fix possible NULL pointer dereference in WMFreeColorPanel (Coverity #50189)

From: Christophe CURIS christophe.cu...@free.fr As pointed by Coverity, the code was checking for NULL pointer to avoid misbehaviour, but it actually dereferenced the pointer beforehand so the crash would still happen. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs

[PATCH 2/7] WINGs: changed use of 'if' on panel-rgbState into a switch

christophe.cu...@free.fr --- WINGs/wcolorpanel.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/WINGs/wcolorpanel.c b/WINGs/wcolorpanel.c index 63892c4..579fded 100644 --- a/WINGs/wcolorpanel.c +++ b/WINGs/wcolorpanel.c @@ -2480,19 +2480,26 @@ static

Re: [PATCH] WINGs: RGB panel decimal/hexadecimal modifications

to strtol for the base 10 string conversion. In addition, the hexadecimal text was too wide for the default size of its radio button for some fonts, so both radio buttons are now resized to fit the width of the panel. --- WINGs/wcolorpanel.c | 47

Re: [PATCH] WINGs: Option for decimal or hexadecimal RGB colors

- Doug Torrance dtorra...@monmouthcollege.edu a écrit : The RGB panel of the WINGs color panel lists the red, green, and blue values as base 10 numbers. However, hexadecimal numbers are very common when dealing with RGB colors. This patch adds two radio buttons at the bottom

[PATCH] WINGs: RGB panel decimal/hexadecimal modifications

, the hexadecimal text was too wide for the default size of its radio button for some fonts, so both radio buttons are now resized to fit the width of the panel. --- WINGs/wcolorpanel.c | 47 --- 1 file changed, 28 insertions(+), 19 deletions(-) diff --git

[PATCH] WINGs: Option for decimal or hexadecimal RGB colors

The RGB panel of the WINGs color panel lists the red, green, and blue values as base 10 numbers. However, hexadecimal numbers are very common when dealing with RGB colors. This patch adds two radio buttons at the bottom of the RGB panel to allow users to choose their preferred number system

[PATCH] Restore wprogressindicator.c declarations to WINGs/WINGs.h

In commit b4cb488, wprogressindicator.c was removed. It was restored in commit d435ea7, but the corresponding declarations in WINGs/WINGs.h were not. This patch fixes this oversight. --- WINGs/WINGs/WINGs.h | 16 1 file changed, 16 insertions(+) diff --git a/WINGs/WINGs

[PATCH 0/1] WINGs: Fix crash on exit while trying to save user config changes

From: Christophe CURIS christophe.cu...@free.fr Hello, Apparently, trying to do things the right way has sometimes unexpected side effects... Regards. WINGs/Makefile.am| 1 + WINGs/userdefaults.c | 19 --- WINGs/userdefaults.h | 34

[PATCH 1/1] WINGs: Fix crash on exit while trying to save user config changes

From: Christophe CURIS christophe.cu...@free.fr Recent patches has introduced the ability to exit cleanly from the WINGs library, but this introduced some side effects because a function is registered with 'atexit' to save user config on exit, which may not work anymore because

[PATCH 2/8] WINGs: removed unused variable in syslog messaging code

From: Christophe CURIS christophe.cu...@free.fr As pointed by the commpiler, the variable 'syslog_prefix' is not used in the code, so it is removed. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/error.c | 4 1 file changed, 4 deletions(-) diff --git a/WINGs/error.c b

[PATCH 4/8] WINGs: Removed checks for code that can't fail

' there were checks to make sure the generated result string would fit in the allocated area, but this allocated area is sized precisely to fit the path, so it cannot fail. Signed-off-by: Christophe CURIS christophe.cu...@free.fr --- WINGs/userdefaults.c | 11 --- WINGs/wfilepanel.c | 15

[PATCH 3/8] WINGs: safer cleanup in the 'WMReleaseApplication' function

From: Christophe CURIS christophe.cu...@free.fr The function would not behave correctly if called twice, and the library may re-use de-allocated pointers if calling WINGs functions after calling this function. The goal is for our library to behave as cleanly as possible, so that users may have

[PATCH 0/2] Changed WINGs function to created a resized pixmap

be: + pixmap = WMCreateScaledBlendedPixmapFromFile(wmscr, file, color, width - 2, height - 2); Regards, Christophe WINGs/WINGs/WINGs.h| 7 ++- WINGs/wpixmap.c| 37 ++--- WPrefs.app/MouseSettings.c | 2 +- WPrefs.app/WPrefs.c| 4

[PATCH 1/2] Added new WINGs function to created a resized pixmap

From: Christophe CURIS christophe.cu...@free.fr In order to keep compatibility for the WINGs public API: - created a new function instead of changing the parameters of the legacy function as done in commit 0c3b76a0c92beb3891891dbfd23d3b34dee4bd05; - restore use of legacy function

[PATCH 0/1] Avoid breaking legacy WINGs public API

From: Christophe CURIS christophe.cu...@free.fr Hello, The commit 0c3b76a0c92beb3891891dbfd23d3b34dee4bd05 introduced a compatibility break to the public API of WINGs, this patch restores compatibility by introducing a new function instead: - diff: the proposed changes for review - replace

[PATCH 1/1 diff] Fixed WINGs API broken in commit 0c3b76a0c92beb3891891dbfd23d3b34dee4bd05

From: Christophe CURIS christophe.cu...@free.fr In order to keep compatibility for the WINGs public API: - created new function instead of changing the parameters of the legacy function; - swapped arguments to use the logical order (width / height) instead of the reverse Signed-off

[PATCH 1/3 replace] WINGs: Add functions to release application memory

From: David Maciejak david.macie...@gmail.com --- WINGs/WINGs/WINGs.h | 4 +++- WINGs/WINGs/WINGsP.h | 2 ++ WINGs/notification.c | 15 +++ WINGs/wapplication.c | 15 +++ 4 files changed, 35 insertions(+), 1 deletion(-) diff --git a/WINGs/WINGs/WINGs.h b/WINGs/WINGs

[PATCH 1/3] Added cleaned function in wings

--- WINGs/WINGs/WINGs.h | 3 ++- WINGs/notification.c | 12 WINGs/wapplication.c | 11 +++ 3 files changed, 25 insertions(+), 1 deletion(-) diff --git a/WINGs/WINGs/WINGs.h b/WINGs/WINGs/WINGs.h index aa95844..6597504 100644 --- a/WINGs/WINGs/WINGs.h +++ b/WINGs/WINGs

[PATCH 1/3 merged] WINGs: Add support for syslog messaging

From: David Maciejak david.macie...@gmail.com This patch is used to add support for syslog messaging implemented in WINGs lib directly, so available from the lib itself and wmaker too. I believe it will in a first time help to get some logging info centralized in one point, and in a second time

Re: Re : [PATCH] WINGs: Added support for syslog msg

...@free.fr wrote: Hi, Sorry to bring those suggestions below a bit late... - David Maciejak david.macie...@gmail.com a écrit : [...] diff --git a/WINGs/WINGs/WUtil.h b/WINGs/WINGs/WUtil.h index 246ef2d..b2e76ab 100644 --- a/WINGs/WINGs/WUtil.h +++ b/WINGs/WINGs/WUtil.h @@ -243,6

[PATCH] WINGs: Added support for syslog msg

This patch is used to add support for syslog messaging implemented in WINGs lib directly, so available from the lib itself and wmaker too. I believe it will in a first time help to get some logging info centralized in one point, and in a second time maybe add some info level messages like wmaker

Re: [PATCH] WINGs: Added support for syslog msg

On Thu, 13 Feb 2014 at 19:04:41 +0800, David Maciejak wrote: This patch is used to add support for syslog messaging implemented in WINGs lib directly, so available from the lib itself and wmaker too. I believe it will in a first time help to get some logging info centralized in one point

  1   2   3   >