Hi Paul, All the packages are updated and uploaded for code review. The links for all the packages is the same as below.
Let me know once the review is done and if we need to change anything in the files. Thanks, ~Vivek R. Titarmare -----Original Message----- From: [email protected] [mailto:sfwnv-discuss-bounces at opensolaris.org] On Behalf Of Vivek Titarmare Sent: Wednesday, April 08, 2009 6:58 PM To: paul.cunningham at tadpole.com Cc: sfwnv-discuss at opensolaris.org Subject: Re: [sfwnv-discuss] Request code review for "janino", "jettison", "jaxen-core", "jodatime", "mvel", "relaxngDatatype", "staxapi" & "xpp3min" Thanks Paul.. The webrev is uploaded at the same location with the changes you mentioned. The changes for point 1 and 4 are done. For point 2: the source is available only in the jar format/compressed. We used the same file to port. For point 3: we were using junit as a reference. We did not find any dependency related to java in the depend file (all listed dependencies are the default dependencies). Do we need to mention java in the depend file for all the packages? Is there any example available for the same? This will help me add the dependency in all the packages. Let me know. For point 5: Actually, we did not find any copyright owner/s for both the packages. Do we still need to mention the owner in the copyright file. Let me know. Thanks, ~Vivek R. Titarmare -----Original Message----- From: Paul Cunningham [mailto:[email protected]] Sent: Wednesday, April 08, 2009 3:33 PM To: Vivek Titarmare Cc: sfwnv-discuss at opensolaris.org Subject: Re: [sfwnv-discuss] Request code review for "janino", "jettison", "jaxen-core", "jodatime", "mvel", "relaxngDatatype", "staxapi" & "xpp3min" See below for my comments on jettison and jodatime ... Paul Vivek Titarmare wrote: > > Webrev for all the packages are created separately and are uploaded to cr.opensolaris.org. The url's are as follows: > > http://cr.opensolaris.org/~vivekrt/6816378-mvel/ > http://cr.opensolaris.org/~vivekrt/6816382-jettison/ > http://cr.opensolaris.org/~vivekrt/6816384-jodatime/ > http://cr.opensolaris.org/~vivekrt/6816385-staxapi/ > http://cr.opensolaris.org/~vivekrt/6816386-xpp3min/ > http://cr.opensolaris.org/~vivekrt/6816388-relaxngDatatype/ > http://cr.opensolaris.org/~vivekrt/6816392-jaxen-core/ > http://cr.opensolaris.org/~vivekrt/6816393-janino/ 1. usr/src/pkgdefs/SUNWjettison/pkginfo.tmpl Add pkg version at end of DESC= line 2. usr/src/lib/jettison/jettison-1.0-sources.jar Why a jar file ? 3. SUNWjettison/SUNWjodatime dependencies Does this have a dependency on the java runtime pkg? 4. usr/src/pkgdefs/Makefile Line ... 161 SUNWjoda-time but package dir is .. usr/src/pkgdefs/SUNWjodatime ? 5. usr/src/pkgdefs/SUNWjodatime/copyright & usr/src/pkgdefs/SUNWjettison/copyright Can you add the source code owner copyright lines? -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit _______________________________________________ sfwnv-discuss mailing list sfwnv-discuss at opensolaris.org http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss
