See below for comments on staxapi ... Paul
Vivek Titarmare wrote: > Hi Alan/Paul, > > Webrev for all the packages are created separately and are uploaded to > cr.opensolaris.org. The url's are as follows: > > http://cr.opensolaris.org/~vivekrt/6816378-mvel/ > http://cr.opensolaris.org/~vivekrt/6816382-jettison/ > http://cr.opensolaris.org/~vivekrt/6816384-jodatime/ > http://cr.opensolaris.org/~vivekrt/6816385-staxapi/ > http://cr.opensolaris.org/~vivekrt/6816386-xpp3min/ > http://cr.opensolaris.org/~vivekrt/6816388-relaxngDatatype/ > http://cr.opensolaris.org/~vivekrt/6816392-jaxen-core/ > http://cr.opensolaris.org/~vivekrt/6816393-janino/ 1. usr/src/lib/stax-api/install-sfw The following lines are not required .. 66 cd ${TOP}/${VERS} 67 The versioning looks wrong here .. 71 _install N stax-api-1.0.1.jar ${JARDIR}/stax-api-1.2.0.jar 444 72 _install L stax-api-1.2.0.jar ${JARDIR}/stax-api.jar 444 You could also use a version var passed in from Makefile.sfw instead of hard coding it. 2. usr/src/pkgdefs/Makefile Line ... 317 SUNWstax-api doesn't match the pkg dir name SUNWstaxapi 3. package 'copyright' As for others, add the src owner copyrights (if any) 4. package 'depend' As for others, does it depend on the java pkg? 5. usr/src/lib/stax-api/METADATA & usr/src/pkgdefs/SUNWstaxapi/pkginfo.tmpl Text "Java-based Library" for what ? Maybe that should say .. "Java-based Library for XML processing API" 6. usr/src/pkgdefs/SUNWstaxapi/prototype_com Line .. 156 s none usr/share/lib/java/stax-api.jar=stax-api-1.0.1.jar is version number right ? -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Business Unit
