Paul, I have removed the INSTALL of the man directories. I will consider moving the install to a script, but for now I am leaving it in the Makefile.sfw; I hope that is okay.
I have also updated the depend file and added commands to rename the man pages from *.5 to *.4 and from *.7 to *.5 as suggested by Alan Coopersmith. Thanks for all your comments; they were helpful and much appreciated. If you see anything else, please do contact me. Thanks, Enrique Paul Cunningham wrote: > Enrique, > > Your changes look okay to me. I have one addition comment ... > > 1. usr/src/cmd/git/Makefile.sfw > You have used INSTALL to install doc stuff in here, most > other packages, if not using 'make install', provide a > script call install-sfw (normally) that then uses the > '_install ...' macro to install stuff into proto. Maybe > you should think about doing it that way. > > Also you INSTALL the man directories, these should have > already been created by entries in Targetdirs; and if > not in there they should be. So you may want to remove > those lines. > > Paul > > On Wed, 2008-06-18 at 17:08, Enrique Lopez-Pineda wrote: > >> Thank you very much for your comments. Please see my responses below >> and >> please provide me with more comments or needed corrections as >> appropriate: >> >> Paul Cunningham wrote: >> >>> Enrique, >>> >>> See below for comments from my quick skip through ... >>> >>> Paul >>> >>> On Tue, 2008-06-17 at 21:56, Enrique Lopez-Pineda wrote: >>> >>> >>>> I have posted a webrev for the package "git" which I am porting to >>>> OpenSolaris and would >>>> like to request a code review. >>>> >>>> Please see http://cr.opensolaris.org/~elpineda/git/webrev/ and provide >>>> any comments as >>>> needed if there are any issues which I need to correct. >>>> >>>> >>> === Start of Comments === >>> >>> 1. usr/src/cmd/Makefile >>> & usr/src/pkgdefs/Makefile >>> You don't seem to have added your package name >>> >>> >> Being new at using "wx", I didn't realize that the "wx co Makefile" >> command would >> need to be done before editing the file. I have corrected this. >> >>> 2. usr/src/cmd/git/METADATA >>> You haven't included the URL of where the source >>> comes from. >>> >>> >> Added a URL line. >> >>> 3. usr/src/cmd/git/Makefile.sfw >>> Why have you created a tmp dir, unzipped into that >>> and then moved the result out of the tmp dir; why >>> not do it directly into where you move it to? >>> >>> >> I was following an example Makefile.sfw from another package. I have >> modified >> it now to do it directly. >> >>> Could this be built with the Sun compiler rather >>> than gcc? >>> >>> >> I believe I tried using the Sun compiler, but had some problems with >> the compilation. >> Since it worked with gcc I stayed with it. I could look at using Sun >> compilers later if >> required. >> >>> I don't think 'PATCHES=' is used? >>> >>> >> Deleted the line. >> >>> 4. usr/src/pkgdefs/SUNWgit/pkginfo >>> This doesn't need to be checked in, as its created >>> from pkginfo.tmpl >>> >>> >> I did an uncreate and a "wx rm usr/src/pkgdefs/SUNWgit/pkginfo". >> >>> === End of Comments ===== >>> >>> -- Enrique Lopez-Pineda Sun Microsystems enrique.lopezpineda at sun.com 651-552-6426 (x44626)
