Paul,
Thank you for reviewing my changes. I understand most of your comments.
I have a few questions that you or others may be able to help me understand.
=== Start of Comments ===
3. usr/src/cmd/ircii/install-sfw
Various assignments are unused, eg, INFODIR=, MAN1DIR=,
etc., you should probably remove these.
=== End of Comments ===
I think I do have these defined as:
36 INFODIR=${SHAREDIR}/info
37 MAN1DIR=${SHAREDIR}/man/man1
I was looking at
http://cr.opensolaris.org/~trp/ircii/webrev/usr/src/cmd/ircii/install-sfw.html
=== Start of Comments ===
2. usr/src/cmd/ircii/Makefile.sfw
You are hard coding '--prefix=', you might
want to use the predefined value in CONFIGURE_OPTIONS,
see
http://cr.opensolaris.org/~rayx/erlang/webrev/usr/src/cmd/erlang/Makefile.sfw.html
=== End of Comments ===
This is very confusing to me, mostly because I don't understand how the
various makefiles/scripts get things straight between the build root [
$(ROOT)$(CFGxxx) ] and the "install" root, i.e., where the installed
package code will live [$(CFGxxx)].
For example, Makefile.master sets:
CONFIGURE_OPTIONS = --prefix=$(CFGPREFIX)
CFGPREFIX= /usr
Since my package has an install make target, I think this results in an
attempt to install the code into /usr of the build system, instead of
/proto....
I didn't think of this until just now, but I suppose I could not run the
install target in the package's makefile, and just do the copy with the
install-sfw script. This would also eliminate a few patches, which is
always good.
--- Todd
