Todd Pisek wrote: > Roland Mainz wrote: > > Todd Pisek wrote: > >> Please see http://cr.opensolaris.org/~trp/ircii/webrev/ and provide any > >> comments or changes I need to make. [snip] > >> +VERS=20060725 > >> +PKGVERS=ircii-${VERS} > >> +TOPDIR=$PWD/${PKGVERS} > >> + > >> +. ${SRC}/tools/install.subr > >> > > > > Please use "source" instead of "." (see > > http://www.opensolaris.org/os/project/shell/shellstyle/#use_source_not_dot). > > > When I replace '.' with 'source', _install is not found.
I forgot to say that this item depends on using either "ksh93" or "bash" which was listed above in the item for "set -o errexit". If "source" fails then "set -o errexit" should abort the script with an usefull error mesage (e.g. both items interact with each other: If "source" fails to include a script it will return a non-zero exit code which "set -o errexit" will properly catch (that's the advantage over using the plain ".")). ---- Bye, Roland -- __ . . __ (o.\ \/ /.o) roland.mainz at nrubsig.org \__\/\/__/ MPEG specialist, C&&JAVA&&Sun&&Unix programmer /O /==\ O\ TEL <currently fluctuating> (;O/ \/ \O;)
