Todd,

See below for additional comments ..

Paul 

> -----Original Message-----
> From: Todd.Pisek at Sun.COM [mailto:Todd.Pisek at Sun.COM] 
> 
> Thanks for your advice and help. I removed all but one patch 
> (needed to enable some defines for SUN environments).
> Updated webrev at http://cr.opensolaris.org/~trp/ircii/webrev/

=== Start ======

1. usr/src/cmd/ircii/install-sfw 
   The 'mkdir's should really be put into the 'Targetdirs' file.
   Remove the 'echo' lines.
   I might have missed it, but where does ${MAN1DIR}/ircII.1 get
   installed. And can it be done with '_install M ..'?

2. usr/src/pkgdefs/SUNWircii/prototype_com 
   Shouldn't irc.1 be a link to ircII.1 ? And where is
   ircII.1 ?

3. Everything else looks okay to me :-)

=== End ========

Reply via email to