Todd, This looks okay to me now.
Paul > -----Original Message----- > From: Todd.Pisek at Sun.COM [mailto:Todd.Pisek at Sun.COM] > Sent: 27 June 2008 17:37 > To: Cunningham, Paul - UK > Cc: sfwnv-discuss at opensolaris.org > Subject: Re: [sfwnv-discuss] Request code review for "ircii" > > Hi Paul, > > Once again, thanks for the valuable help. I'm slightly more > dangerous now :-). > > I moved the new directories into usr/src/Targetdirs. > > I finally figured out parts of _install, so the man stuff is > now being properly built. > > I added a symbolic link in usr/src/pkgdefs_SUNWircii/prototype_com > > The webrev is at http://cr.opensolaris.org/~trp/ircii/webrev/ > > Regards, > > --- Todd > > > Cunningham, Paul - UK wrote: > > Todd, > > > > See below for additional comments .. > > > > Paul > > > > > >> -----Original Message----- > >> From: Todd.Pisek at Sun.COM [mailto:Todd.Pisek at Sun.COM] > >> > >> Thanks for your advice and help. I removed all but one > patch (needed > >> to enable some defines for SUN environments). > >> Updated webrev at http://cr.opensolaris.org/~trp/ircii/webrev/ > >> > > > > === Start ====== > > > > 1. usr/src/cmd/ircii/install-sfw > > The 'mkdir's should really be put into the 'Targetdirs' file. > > Remove the 'echo' lines. > > I might have missed it, but where does ${MAN1DIR}/ircII.1 get > > installed. And can it be done with '_install M ..'? > > > > 2. usr/src/pkgdefs/SUNWircii/prototype_com > > Shouldn't irc.1 be a link to ircII.1 ? And where is > > ircII.1 ? > > > > 3. Everything else looks okay to me :-) > > > > === End ======== > > > >
