Enrique, See below for comments from my quick skip through ...
Paul On Tue, 2008-06-17 at 21:56, Enrique Lopez-Pineda wrote: > I have posted a webrev for the package "git" which I am porting to > OpenSolaris and would > like to request a code review. > > Please see http://cr.opensolaris.org/~elpineda/git/webrev/ and provide > any comments as > needed if there are any issues which I need to correct. === Start of Comments === 1. usr/src/cmd/Makefile & usr/src/pkgdefs/Makefile You don't seem to have added your package name 2. usr/src/cmd/git/METADATA You haven't included the URL of where the source comes from. 3. usr/src/cmd/git/Makefile.sfw Why have you created a tmp dir, unzipped into that and then moved the result out of the tmp dir; why not do it directly into where you move it to? Could this be built with the Sun compiler rather than gcc? I don't think 'PATCHES=' is used? 4. usr/src/pkgdefs/SUNWgit/pkginfo This doesn't need to be checked in, as its created from pkginfo.tmpl === End of Comments ===== -- ---------------------------------------------------------------------- Paul Cunningham Software Engineer Tadpole Computer Products
