This looks okay to me, but don't forget Jim's comments. Also in the METADATA file, do you need the text for the COMMENTS: field (lines 12 to 17) ? (ie. does it actually provide addition info)
Paul UVR wrote: > UVR wrote on Sun Sep 20 2009 09:11:01 GMT-0700 (PST): >> >> I'm seeking a second round of code reviews for the 'fakeroot' package. >> A webrev is available at: >> http://cr.opensolaris.org/~uvr/fakeroot/ > > I have made the modifications suggested/discussed so far, and > an incremental webrev (of just the changes since the last round > of reviews) is here: > > [1] http://cr.opensolaris.org/~uvr/fakeroot-incremental-webrev/ > > A full webrev (all changes against sfwnv-clone) is here: > > [2] http://cr.opensolaris.org/~uvr/fakeroot-webrev/ > > I will appreciate feedback, especially from those who were kind > enough to provide comments in the previous round (but also from > all others). > > Here's what has changed: > . incorporate feedback from first round > . include a patch file that was inadvertently missed in the previous > round of reviews > > This has been rebuilt and retested overnight, successfully. > > -Ravindra. > _______________________________________________ > sfwnv-discuss mailing list > sfwnv-discuss at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/sfwnv-discuss > -- Paul Cunningham Software Engineer Tel: 01462 685974
