Ravindra,

Here are my comments:

usr/src/cmd/fakeroot/Makefile.sfw

        Are the surrounding parenthesis for the 'install' line
        necessary?

        install: all
                ($(SRC)/tools/protofix --perm --pkg $(COMPONENT_PACKAGES:sh))

        Based on comments I got back on my webrev, my understanding is
        that make runs a new shell for each line in the makefile.
        Surrounding parenthesis are necessary only if you have multiple
        commands that need to execute in the same shell.  Since there
        is only one command executed for install, I don't think the
        surrounding parenthesis are needed.

I haven't had to do patch files so can't provide any useful feedback
there.

Others have already commented on not delivering 64-bit executables,
so the last line of prototype_i386 and prototype_sparc should be
removed and your makefile or patching should delete the 64-bit
'faked' from proto area.

Everything else looks good to me.

Regards,

Andre

Reply via email to