On Sun, 17 Sep 2006 20:05:29 -0400
Jason Lunz <[EMAIL PROTECTED]> wrote:
>
> Increase the granularity of calls to start_writeout() when
> early_writeout is used. This results in a smooth progress display
> during writeout, rather than a noticeable pause each 20% of the way
> through.
Yes, I noticed this too on some machines.
> I think performance shouldn't be hurt, since we're still batching
> pages 1% at a time, down from 20%. A normal image has 10's of
> thousands of pages (mine 512M laptop is ~55000 pages, for example) so
> 1% is still~500 pages or ~2M at a time.
I don't know to if it would impact performance, somebody else
should think a bit more about that maybe. The option (early writeout) is
configurable however, so people can shut it of if they think it slows
writing down.
The patch looks OK to me.
> Jason
>
> ---
> suspend.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> Index: suspend-0.2/suspend.c
> ===================================================================
> --- suspend-0.2.orig/suspend.c
> +++ suspend-0.2/suspend.c
> @@ -416,8 +416,9 @@
> m = nr_pages / 100;
> if (!m)
> m = 1;
> - writeout_rate = nr_pages / 5;
> - if (!writeout_rate || !early_writeout)
> + if (early_writeout)
> + writeout_rate = m;
> + else
> writeout_rate = nr_pages;
> nr_pages = 0;
> do {
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Suspend-devel mailing list
Suspend-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/suspend-devel
