On Wed, Mar 18, 2009 at 8:03 PM, asmeurer <asmeu...@gmail.com> wrote:
>
>> The patch will not be accepted without tests, so yes, the tests should
>> be updated.
>
> OK.  Is there a way to edit my patch somehow or should I just
> resubmit? And if resubmit, should I resubmit the whole thing, or just
> the test?
>
> Also, are there any guidelines on tests that I should know about?
> Obviously, the test should work, but other than that? I was just going
> to just find a sample Bernoulli equation from my text and add it in
> the same way that the other tests are implemented.

Just resubmit the patch. You can use

git rebase -i

to merge/squash patches. I'll help you with the rest once I can see the patch.

>
>> You should see your mail in sympy-patches. If you don't, your mail
>> client may not work. In this case, just attach the files generated
>> with "git format-patch" to some issue in our bug tracker.
>
> I see it now.  My mail client was marking it as junk.

Could you please post a link to the message in the sympy-patches list:

http://groups.google.com/group/sympy-patches

I can't see it.

Ondrej

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sympy" group.
To post to this group, send email to sympy@googlegroups.com
To unsubscribe from this group, send email to sympy+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sympy?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to