Oh, and if someone could go through and add priority labels and code in labels to all the sympy-bot issues (https://github.com/sympy/sympy-bot/issues?sort=created&direction=desc&state=open), then we can put these in the next round for code-in, and maybe some of them will be fixed through that. I think just about all of them would get the QA label, by the way.
Aaron Meurer On Fri, Dec 2, 2011 at 4:58 PM, Aaron Meurer <asmeu...@gmail.com> wrote: > 2011/12/2 Ondřej Čertík <ondrej.cer...@gmail.com>: >> 2011/12/2 krastanov.ste...@gmail.com <krastanov.ste...@gmail.com>: >>> On the topic of testing: What is the reason that the pull requests are not >>> all tested automatically? And tox run every week or so. I thought that all >> >> That's the plan, but I got busy to set this up, so it's not done yet. >> >>> the code for the automated testing is already written. And there is that >>> google app engine instance. If it's only a processing power issue I have a >>> relatively old core2due computer that is almost completely unused and I'll >>> gladly make an ssh account for you so you install the automated sympy-bot >>> (or I can do it with your help). Or if I'm wrong and this stuff is not >>> automated one can just write a one line cron job workaround for it. >> >> If you have time to make this work, it'd be really great. I just sent you >> an invitation for push access to the app engine instance of >> reviews.sympy.org. >> The code of which is in the sympy-bot repository, see the web directory [1]. >> >> My overall long term goal is to have all pull requests automatically >> tested on all architectures, every time either the master or the pull >> request branch changes. To do so, I've already implemented to note >> down the master hash and branch hash in the pull request. My TODO list >> is: >> >> 1) make the web application accept the master/branch hashes for each >> submitted test >> >> 2) implement "sympy-bot work" mode that would query the web >> application for a list of pull requests that need updated test run > > Let's do this in a distributed fashion. So just have the server give > one pull request at a time, and keep track that it has been given out, > and timeout for it after an hour or something and put it back in the > queue. That we, we can easily have multiple machines running this. > We can also use a priority queue based on certain things (e.g., pull > requests without any reviews would have higher priority, pull requests > from new contributors would have higher priority, etc.), and also let > people manually bump their pulls if they want. > > That way it will be easy to have multiple servers, or for example, I > could just run it on my own machine when I don't mind the CPU being > used (kind of like a sympy-bot@home). > > Another thing we'll need to implement is a way to note in the .conf > file which executables to use for particular architectures (e.g., on > Mac OS X you can get 32-bit or 64-bit using arch -i386 > /Library/Frameworks/Python.framework/Versions/2.5/bin/python2.5 or > arch -x86_64 /Library/Frameworks/Python.framework/Versions/2.5/bin/python2.5, > assuming the executable has the code for that particular architecture. > Then the sympy-bot work server can be very specific about testing not > only different pull requests but the same pull requests on different > Python versions and different architectures. > >> >> 3) setup github authentication, so that the web application comments >> into the github pullrequest (currently the sympy-bot itself comments >> using your github credentials). >> >> One needs to figure out the authentication as well as some reasonable >> reporting, as in general there will be tons of tests executed for each >> pull request and the webapp should figure out whether a new test >> should be run or not, depending on the hashes. > > Did we figure out if it's possible to have it edit the pull request > description with test summaries? > > Aaron Meurer > >> >> If you make any work on this, that'd be absolutely awesome. You don't >> need to follow my TODO list. But try to submit all the >> code/configuration into the sympy-bot repository, so that other people >> can reproduce the work and help with the setup. >> >> Ondrej >> >> [1] https://github.com/sympy/sympy-bot >> >> -- >> You received this message because you are subscribed to the Google Groups >> "sympy" group. >> To post to this group, send email to sympy@googlegroups.com. >> To unsubscribe from this group, send email to >> sympy+unsubscr...@googlegroups.com. >> For more options, visit this group at >> http://groups.google.com/group/sympy?hl=en. >> -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to sympy@googlegroups.com. To unsubscribe from this group, send email to sympy+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
