I kind of like this idea of submitting the patch to the list. 'Cuz we can
discuss it =)
On Sun, 21 Nov 2004, Albert Cahalan wrote:
[snip]
> -CFLAGS=-O2 -Wall
> +CFLAGS=-O2 -Wall -fno-common -ffast-math \
> + -W -Wall -Wcast-align -Wredundant-decls \
> + -Wbad-function-cast -Wwrite-strings -Waggregate-return \
> + -Wstrict-prototypes -Wmissing-prototypes
> +
[snip]
Turning on extra error messages sounds good.
-ffast-math should be okay, but it also turns on
-funsafe-math-otpimizations which I'm kind of weary of... Any experts on
this option?
-Wall is defined twice... =P
> enum {
> COLOR_BLACK,
> + COLOR_GREY,
> + COLOR_SILVER,
> COLOR_WHITE,
> COLOR_RED,
> COLOR_PINK,
> COLOR_ORANGE,
> COLOR_YELLOW,
> - COLOR_LIME,
> + COLOR_NEON,
> COLOR_GREEN,
> - COLOR_CYAN,
> + COLOR_SKYBLUE,
> COLOR_BLUE,
> COLOR_PURPLE,
> - COLOR_FUCHSIA, /* ... */
> + COLOR_MAGENTA,
> COLOR_BROWN,
> - COLOR_GREY,
> - COLOR_SILVER, /* ... */
> + COLOR_TAN,
> + COLOR_BEIGE,
> NUM_COLORS
> };
[snip]
I like these color names better than the previously defined ones, but if
we're going to change the names of the colors, let's use the canonical
names, perhaps adopting the color names in /etc/X11/rgb.txt file. We may
also have to retranslate the color names.
BTW, does changing the names of the color and ordering affect file
saving/loading? Will reordering the palette inconvenience the users, and
if so, should we reorder them, and does the reordering make more intuitive
sense? (I haven't checked the new orders.)
[snip]
> -#define MAX_STAMPS 256
> +#define MAX_STAMPS 512
[snip]
If we're gonna increase the stamps, is 512 enough? What's our stamps
collection size?
[snip]
> #ifndef WIN32
> - if (Mix_OpenAudio(44100, AUDIO_S16, 2, 1024) < 0)
> + if (Mix_OpenAudio(44100, AUDIO_S16SYS, 2, 1024) < 0)
> #else
> if (Mix_OpenAudio(44100, AUDIO_S16, 2, 2048) < 0)
> #endif
This change is for Mac, right? Does this change negatively affect Linux
and/or BeOS (or Sun, etc.)?
-Mark
--
Mark K. Kim
AIM: markus kimius
Homepage: http://www.cbreak.org/
Xanga: http://www.xanga.com/vindaci
Friendster: http://www.friendster.com/user.php?uid=13046
PGP key fingerprint: 7324 BACA 53AD E504 A76E 5167 6822 94F0 F298 5DCE
PGP key available on the homepage
_______________________________________________
Tuxpaint-dev mailing list
[EMAIL PROTECTED]
http://tux4kids.net/mailman/listinfo/tuxpaint-dev
