On Sun, 2004-11-21 at 20:25, Mark K. Kim wrote: > Turning on extra error messages sounds good.
That's all you can turn on without... a. being gcc version-specific b. getting warnings for standard include files c. going insane :-) Regarding the last, there are a couple warnings that may look impossible to eliminate at first glance, but are not bad once you get what the concise message is all about. Adding "static" in places (default for C++, but not for C) will be helpful. > -ffast-math should be okay, but it also turns on > -funsafe-math-otpimizations which I'm kind of weary of... Any experts on > this option? It's not really unsafe. :-) Normally, math is seriously slowed down by requirements related to the following: a. must set errno for sqrt(-5.2) and other bad math b. must not do algebraic optimization c. must cause SIGFLT signal in the right places Some people like to trap division by zero so that they can substitute in a "correct" value. Some people like to trap overflow so that they can fudge the exponent for greater range. There's no way Tux Paint will be doing this kind of thing. > > - COLOR_LIME, > > + COLOR_NEON, > > COLOR_GREEN, > > - COLOR_CYAN, > > + COLOR_SKYBLUE, > > COLOR_BLUE, > > COLOR_PURPLE, > > - COLOR_FUCHSIA, /* ... */ > > + COLOR_MAGENTA, > > COLOR_BROWN, > > - COLOR_GREY, > > - COLOR_SILVER, /* ... */ > > + COLOR_TAN, > > + COLOR_BEIGE, > > NUM_COLORS > > }; > [snip] > > I like these color names better than the previously defined ones, but if > we're going to change the names of the colors, let's use the canonical > names, perhaps adopting the color names in /etc/X11/rgb.txt file. We may > also have to retranslate the color names. I went for kid-friendly. I struggle to spell fuchsia. I asked my wife for an opinion, and she reports that a kid's toy and/or TV show (both I guess) uses "magenta". A kid trying to pronounce "fuchsia" could get offensive. :-) The "Sky blue" is actually that now, computed as the average value of the sky in numerous images of the sky. (if you try this, remember to allow for gamma) Likewise, tan and beige were computed from many images. I don't care for "silver", since it doesn't sparkle or gleam, but I figured "light grey" might be to difficult to read. BTW, both "grey" and "gray" are considered correct spellings. > > -#define MAX_STAMPS 256 > > +#define MAX_STAMPS 512 > [snip] > > If we're gonna increase the stamps, is 512 enough? What's our stamps > collection size? It'll do as an emergency fix. I hit the limit with about three dozen local stamps. > [snip] > > #ifndef WIN32 > > - if (Mix_OpenAudio(44100, AUDIO_S16, 2, 1024) < 0) > > + if (Mix_OpenAudio(44100, AUDIO_S16SYS, 2, 1024) < 0) > > #else > > if (Mix_OpenAudio(44100, AUDIO_S16, 2, 2048) < 0) > > #endif > > This change is for Mac, right? Does this change negatively affect Linux > and/or BeOS (or Sun, etc.)? It should help more machines than it hurts. CPU soundcard notes LE LE Common PC. Unchanged. LE BE Broken before, and broken now. (rare) BE LE Broken now, but expected to be rare. BE BE Mac. Now works, even if the drivers won't byteswap. It's rare to have a soundcard that only works with a byte order that is opposite to the CPU. I believe that the MacOS port will handle both; we'll see. _______________________________________________ Tuxpaint-dev mailing list [EMAIL PROTECTED] http://tux4kids.net/mailman/listinfo/tuxpaint-dev
