Hi Eylul,

Thank you for your detailed input.
Point 1 and 2 have already been fixed. The revision has been committed and pushed in Launchpad.

1>> The tagline on the banner has been adjusted based on the revision, the tagline is smaller now, but let me know if it's not small enough.

2>> The social media now appear on Worpress preview (on customizer). As for the demo site, I have tested it on Firefox 69.0.3 and both icons are appearing well. Is it still not appearing on your side? If so, I will investigate it further.


Best regards,
Shinta


On 10/22/2019 2:04 AM, eylul wrote:
Hi Shinta,

First of all apologies for not being able to comment the last update and
delay on doing so in this one.

Quick review: A nitpick on this (or possibly a bug), a second bug with
the social media icons (everything was reviewed on Firefox 69.0.2 on
Ubuntu Studio Bionic for reference in case either of these are browser
specific issues) and a license related item

1) could we make the font of the tagline a bit smaller so that it
doesn't overwhelm the logo? It looks fine on mobile but on desktop it
looks larger than the font of the logo at the moment. (not sure if this
is intended behavior or a bug)

2) there is something strange happening with the social media icons as I
can see both facebook and twitter icons on my android phone, only
facebook icon when viewing the demo, and neither when I am editing the
layout. Not sure exactly what is happening there. (the twitter logo
image is not even showing on the editing sidebar even through it looks
as uploaded.) if it is the images themselves that is causing the hiccup
we can probably fix it easily, but just want to make sure that they are
not getting eaten by a layout bug of some form. :)

3) Erich, just as a heads-up, on the keyboard photograph used. Unsplash
changed its license from CC0 a couple of years ago and it is a bit of a
strange situation. Creative commons declares it as technically not GPL
compatible (or at least not in some situations)
(https://creativecommons.org/2017/06/22/unsplash/) unsplash claims that
it is for individual images
(https://twitter.com/lukechesser/status/872997091374751745), but then
again modification should be alright in this explanation? Just something
for us to keep in mind and maybe we might want to note this also on the
theme license?

Other than that this looks fantastic.  The theme has tons of customizing
options that will give us a lot of flexibility in terms of how our
content can change without having to change the code. Issues previously
mentioned are fixed as far as I can tell. The user documentation is very
detailed and we should be able to integrate it into our docs, (and code
is also documented through comments) The core team obviously will need
to give the final approval, but this looks great and thank you for your
hard work on it. :)

Best

Eylul

On 10/19/19 2:45 PM, Shinta Carolinasari wrote:
Hi all,

I think Ubuntu Studio theme is now ready for review (apologize for
slower progress recently).

Please check the latest demo update in http://ubuntustudio.playmain.com/
If you want to take a look at the dashboard, you could use your usual
login account.

We have committed & pushed the theme code to Launchpad:
https://code.launchpad.net/~ubuntustudio-web-staging/ubuntustudio-web-staging/+git/ubuntustudio-web-staging


Documentation
-------------
This doc contains a guide to set up the theme, required steps to
replicate what in demo site, and also dev notes on how to modify the
theme.
https://drive.google.com/open?id=1dKiqZ3KUKBGdp7jK6nKAV5NX0SCfeqtEA4RnflRg3x0


XML export file (from demo site)
---------------
This file useful to replicate what on the demo site. Just in case you
need it.
https://drive.google.com/open?id=12KULogOG3-APlSVbj-5QKtmvRlKhrxxV

Other assets files
------------------
https://drive.google.com/open?id=1qtd89MXuOQy5W1-cnDJYk2CwEF8OIR4U
It contains footer mixer image from Unsplash
https://unsplash.com/photos/_mugHa5Fc3M, and twitter & facebook icons
taken from their official brand guidelines. They are to be added in
customizer. Feel free to replace it with a more properly licensed
photo, though.

Just let me know if you need a hand setting up the website, or need
some revisions.

Currently, the theme has 2 designs: homepage, and inner pages.
Inner pages are all looking the same, even though it allows for some
limited customization (eg: full width/no sidebar)
So if you have any improvement ideas, for example, want to make a
custom download page, we are happy to discuss.

Best regards,
Shinta



On 8/26/2019 10:26 AM, Shinta Carolinasari wrote:
Hi all,

Here's the latest Update on theme progress:
Demo:
http://ubuntustudio.playmain.com/

Changes summary:
-nav, submenu styling & search on top
-optimize hero banner performance
-download box, support 1 or 2 ubuntu versions and moved position above
the fold
-homepage - features blurbs support up to 9 boxes, odd & even
-bottom download section, background brightness reduced and now smaller
on inner pages
-other bugfixes and polishments

Source code has been committed to launchpad git.
However its not finished/not ready for review yet.

Will let you know on next update.

Thanks!

Shinta

On 8/19/2019 9:58 PM, Shinta Carolinasari wrote:
Hi Erich,

I really apologize for the late reply. For some reason, I missed to
read
your latest email (But I have improved our inbox/spam organization to
prevent this happen again).
Thanks for staging details. I've made launchpad account, my username
is:
playmain
Will perform further as per your instruction.

Regarding theme progress, I'm still working on the theme. Some
revisions
have already been fixed, and the homepage animation should have
performed better now.
There are some outstanding revision items and polishment still needs to
work on.

Our daily work is a bit hectic recently make this progress slowed down,
We are sorry for this. But I'd expect I can report some update on next
Sunday.

Meanwhile, should you have more feedback just let us know and we will
add them to the list.

Best regards,
Shinta


On 8/13/2019 11:56 PM, er...@ericheickmeyer.com wrote:
Hi Shinta,

Sorry for the silence. Let's go ahead and move forward.

What I need:
1) Create a launchpad account (https://launchpad.net)
2) Let me know what your launchpad username is so I can add you to the
ubuntustudio-web-staging team
(https://launchpad.net/~ubuntustudio-web-staging).
3) Add your public SSH key to your Launchpad account
4) Upload the Wordpress theme and assets using the instructions at
https://code.launchpad.net/~ubuntustudio-web-staging/ubuntustudio-web-staging/+git/ubuntustudio-web-staging




From there, our security team will review the code for anything they
deem an issue.

Let me know if you need any help. I look forward to implementing this
theme! It looks great!

Erich
----
Erich Eickmeyer
Project Leader
Ubuntu Studio

ubuntustudio.org


Shinta Carolinasari – Wed, 10. July 2019 13:41
Hi All,

Thanks for all comments & feedbacks!

Admin Account
-------------
We have created admin account for Erich, Eylul and Len (please let me
know if you haven't received the notification, or want to add more)

TODOS based on feedbacks
------------------------
-For blurbs, current build is still assuming there are always 6
blurbs,
we'll improve it to be more flexible.
-tweak top download box, move position and to covers 2 versions
condition.
-tweak footer download CTA
-move open source to the last panel.
-make sure all text in homepage are editable placeholders
-social icons, currently it uses fontawesome.. we'll check the
license
and evaluate other flexible alternatives, maybe option to upload own
icon
-we also thinking to add additional widget areas in homepage for more
flexibility (eg: in case there's important announcement or events
banner)

performance
-----------
we just tried to add a bit animation on homepage illustration.
this is
our fist time applying css animation on complex svg. we thought
native
css method was the best, however in reality we see tendency of very
high
usage of GPU, just like mentioned by Mark, so we still evaluating
this
or the alternative.

Content
-------
Great to hear Eylul can organize & polish content, Since we have
limited
knowledge on the materials itself.

Logos
-----
We've updated the logos to compliant with the guidelines

resources
---------
-logos and fonts are from ubuntu, font currently taken from google
fonts
for easier development, will eventually changed to be part of the
theme
assets.
-we also use bootstrap css framework (MIT license)
-Photo at bottom CTA, i think its from unsplash, need to be changed
eventually. Ralf previously offered photo contribution for mixer.
-other artwork things are done in house, do you know how to make them
GPL compliant? is it simply by adding comments in theme's source
code?
we'll make sure all the source files are included in git.


Regards,
Shinta

--
ubuntu-studio-devel mailing list
ubuntu-studio-devel@lists.ubuntu.com
Modify settings or unsubscribe at:
lists.ubuntu.com/mailman/listinfo/ubuntu-studio-devel





--
ubuntu-studio-devel mailing list
ubuntu-studio-devel@lists.ubuntu.com
Modify settings or unsubscribe at: 
https://lists.ubuntu.com/mailman/listinfo/ubuntu-studio-devel

Reply via email to