I'm happy to report that I found the problem with my previous patch. The
test
was wrong.
I have fixed the test, and would like you to consider this version for
inclusion
into v8.
Thank you so much for all the reviewing and help!
--fg
https://codereview.chromium.org/121173009/diff/470001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/121173009/diff/470001/test/cctest/test-api.cc#newcode7571
test/cctest/test-api.cc:7571: context->GetIsolate(), pair,
v8::String::kNormalString, 2);
This mistake was the missing piece in the puzzle. My fix seems to have
been correct already.
https://codereview.chromium.org/121173009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
