lgtm
i'll land once you addressed the trivial comments below
additionally, the description of the code review must now change to be the
description of the change. when I land it, it will become the commit message
thanks for fixing this!
https://codereview.chromium.org/121173009/diff/470001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/121173009/diff/470001/src/api.cc#newcode4565
src/api.cc:4565: // TODO(felixge) This function is rather complex and
could benefit from
drop the todo
https://codereview.chromium.org/121173009/diff/470001/src/api.cc#newcode4627
src/api.cc:4627: if (replace_invalid_utf8_ &&
Utf16::IsLeadSurrogate(character)) {
this line is in the correct place, but it's only true because we can
have at most 3 characters remaining here
please add a one line comment
https://codereview.chromium.org/121173009/diff/470001/src/api.cc#newcode4631
src/api.cc:4631:
no space
https://codereview.chromium.org/121173009/diff/470001/src/unicode-inl.h
File src/unicode-inl.h (right):
https://codereview.chromium.org/121173009/diff/470001/src/unicode-inl.h#newcode113
src/unicode-inl.h:113: // with kReplacementCharacter.
kBadChar
https://codereview.chromium.org/121173009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
