Shahar Havivi has posted comments on this change. Change subject: vm payload: add file injection to vm ......................................................................
Patch Set 2: (10 inline comments) .................................................... File vdsm/supervdsmServer.py Line 29: import tempfile sure, but please don't ask me later to join it again to this module Line 187: def _commonMkFs(self, files): what name do you mean? Line 188: uid = resolveUid(VDSM_USER) Done Line 197: f = file(filename, 'w') Done Line 202: tmpFile = tempfile.NamedTemporaryFile(prefix=PAYLOAD_PATH_PREFIX) Done Line 207: uid = resolveUid(VDSM_USER) Done Line 215: os.rmdir(dirname) Done Line 224: raise OSError(errno.EINVAL, "could not create floppy file: \ is EIO better? Line 229: rc, out, err = storage.misc.execCmd(command, raw=True, sudo=False) Done Line 234: for file in os.listdir(dirname): what do you mean? tmp is the mounted dir -- To view, visit http://gerrit.ovirt.org/2321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
