Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: vm payload: add file injection to vm ......................................................................
Patch Set 5: (4 inline comments) .................................................... File vdsm/constants.py.in Line 54: P_PAYLOAD_PATH_PREFIX = '/var/run/vdsm/payload/' Doesn't P_ already imply PATH? Thus P_PAYLOAD_PREFIX should suffice. .................................................... File vdsm/mkimage.py Line 51: f.write(base64.b64decode(entry[name])) Why use iterkeys if you're using both the key and the value? for name, content in entry.iteritems(): Line 85: _commonCleanFs(files, dirname, floppy) If any exception was raised you're leaving stale files. Maybe this should be in some finally clause? Line 99: _commonCleanFs(files, dirname, isopath) Same comment about stale files here. -- To view, visit http://gerrit.ovirt.org/2321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
