Shahar Havivi has posted comments on this change. Change subject: vm payload: add file injection to vm ......................................................................
Patch Set 4: (8 inline comments) .................................................... File vdsm/libvirtvm.py Line 1973: #TODO: delete the payload devices its not postpone, as you see I never check the code (until I will implement the backend) the releaseVm is in libvirtvm.py but the code need to be in vm.py, any suggestions? .................................................... File vdsm/mkimage.py Line 32: _PAYLOAD_PATH_PREFIX = '/var/run/vdsm/payload/' Done Line 47: dirname = tempfile.mkdtemp(prefix=_PAYLOAD_PATH_PREFIX) Dan, I don't understand what do you mean by that. Line 74: m = storage.mount.Mount() Done Line 76: m.mount(mntOpts='-o loop %s %s' % (floppy, tmp)) Done Line 78: for file in os.listdir(dirname): no I can't the _decodeFilesInDir is common code for the floppy and iso, the this copy is only in the floppy case Line 92: isopath = tempfile.NamedTemporaryFile(prefix=_PAYLOAD_PATH_PREFIX, delete=False) sorry, what do you mean? .................................................... File vdsm/vm.py Line 448: devices[DISK_DEVICES].append(drv) I did. and I will change it to the new device model. -- To view, visit http://gerrit.ovirt.org/2321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
