Shahar Havivi has posted comments on this change. Change subject: vm payload: add file injection to vm ......................................................................
Patch Set 3: (8 inline comments) .................................................... File vdsm/mkimage.py Line 2: # Copyright 2008-2012 Red Hat, Inc. so should I remove the copyright or just add the 2012? Line 31: PAYLOAD_PATH_PREFIX = '/var/run/vdsm/payload/' Done Line 33: def _commonMkFs(files): Done Line 43: uid = resolveUid(DISKIMAGE_USER) Done Line 46: os.mkdir(PAYLOAD_PATH_PREFIX) because of security issues, it should not be in temp Line 70: rc, out, err = storage.misc.execCmd(command, raw=True, sudo=False) Done Line 79: raise OSError(errno.EIO, "could not mount floppy file: \ Done Line 82: for file in os.listdir(dirname): Sorry I don't get what you are saying here. -- To view, visit http://gerrit.ovirt.org/2321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I256475342c79690a95ad999335522f99714cdc8b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
