Dan Kenigsberg has posted comments on this change. Change subject: test, add argument parser to testrunner ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) thanks for addressing the need of not hacking vdsm modules in functional testing. however, I find the implementation seriously lacking. I do not understand why you are forcing the user to send a single space-separated list of modules, only to split it by space later. I'm sure there's a simpler argparse way to do it. .................................................... Commit Message Line 14: python testrunner.py -vdsm_replace "main.py miscTests.py" a dash is more standard than underscore. and it should be double-dash for long option names. I'm pretty sure you can add an optional flag without forcing the users to quote all the other args into one. -- To view, visit http://gerrit.ovirt.org/4730 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34cde3b61d394eb651da7c4b544a7c00ab4338f2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Wenchao Xia <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Wenchao Xia <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://fedorahosted.org/mailman/listinfo/vdsm-patches
