Dan Kenigsberg has posted comments on this change.
Change subject: add arguments to testrunner
......................................................................
Patch Set 7: I would prefer that you didn't submit this
(4 inline comments)
....................................................
File tests/testrunner.py
Line 201: testConfig = {"help": False, "local_modules": False}
I still don't find this dictionary helpful.
Line 203: testConfig["help"] = findRemove(sys.argv, "--help")
we actually do not want to remove the --help request. nose gives nice info
there.
Line 207: " --local-modules whether to replace vdsm
library.\n")
fix string to:
--local-modules use vdsm modules from source true, instead of installed
ones
Line 212: if __name__ == '__main__':
this whole patch could be replaced by
if '--help' in sys.argv:
print '--local-modules ...'
if findRemove(sys.argv, '--local-modules'):
hackVdsmModule()
the simpler, the better.
--
To view, visit http://gerrit.ovirt.org/4730
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34cde3b61d394eb651da7c4b544a7c00ab4338f2
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Wenchao Xia <[email protected]>
Gerrit-Reviewer: Xu He Jie <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
