Dan Kenigsberg has posted comments on this change.
Change subject: add arguments parser to testrunner
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File tests/testrunner.py
Line 149: argv = [sys.argv[0]] + caseArgs
I've missed this issue until now, but I think you should pass all the args that
you are not aware of to nose.core - otherwide you couldn't run with
--with-xunit or other nose useful options.
you should look for --local-modules in the args list, act upon it, and pass
everything else to nose.
Line 198: testSuitConfig = {"cases": None, "local_modules": False}
sorry, I do not have any forseable use case for this dictionary. please keep
this patch as minimal as possible.
Line 204: def prepareTest(testConfig):
the function is too general and lacks of substance. Let's inline it.
--
To view, visit http://gerrit.ovirt.org/4730
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34cde3b61d394eb651da7c4b544a7c00ab4338f2
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Wenchao Xia <[email protected]>
Gerrit-Reviewer: Xu He Jie <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
