Dan Kenigsberg has posted comments on this change.
Change subject: add arguments parser to testrunner
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(5 inline comments)
thanks, but we're still not there.
please notice my commit message comment.
....................................................
Commit Message
Line 12: python testrunner.py -vdsm_replace main.py miscTests.py
a dash is more standard than underscore. and it should be double-dash for long
option names.
....................................................
File tests/testrunner.py
Line 157: args = [sys.argv[0]] + caseArgs
I don't like "args" more than "argv". why change?
Line 201: parser.add_argument('--vdsm-replace',
--local-modules maybe?
the meaning of this switch is to take local vdsm modules, and not look for them
in sitelib. --vdsm-replace is not explicit enough.
Line 205: testSuitConfig["case"] = args.case
I don't understand why you must use this global dict. you could return args
just as well.
Line 214: colorWrite(stream, "hacking vdsm modles...\n", colorSuitTip)
why does this hack merits a dramatic colorful notice to the user? I'd try to
hide this hack until we eliminate it completely.
--
To view, visit http://gerrit.ovirt.org/4730
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34cde3b61d394eb651da7c4b544a7c00ab4338f2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Wenchao Xia <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
