Wenchao Xia has posted comments on this change.
Change subject: add arguments parser to testrunner
......................................................................
Patch Set 4: (8 inline comments)
....................................................
File tests/testrunner.py
Line 43: colorSuitTip = TermColor.magenta
removed.
Line 196: parser.add_argument('case', nargs='*', help='specify cases to
run.')
you are right.
Line 197: parser.add_argument('--local_modules', action='store_true',
Sorry I missed the underscore inside the word. Changed.
Line 199: inputArgs = sys.argv[1:]
removed
Line 201: testSuitConfig = {"case": None, "local_modules": False} #
default values
removed.
Line 204: return testSuitConfig
testSuitConfig stands for collection of settings used inside test suit.
Although it is one to one mapping with user args now, but in the future it may
store settings not got from user. So I think an internal dictionary is good for
extension.
Line 208: """Now it only overwrite the vdsm library."""
added more words in the doc string to show what work it is supposed to do.
Line 211: colorWrite(stream, "hacking vdsm modules...\n", colorSuitTip)
OK, removed the tips.
--
To view, visit http://gerrit.ovirt.org/4730
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34cde3b61d394eb651da7c4b544a7c00ab4338f2
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Wenchao Xia <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Wenchao Xia <[email protected]>
Gerrit-Reviewer: Xu He Jie <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
