Ewoud Kohl van Wijngaarden has posted comments on this change.
Change subject: Enable vdsm-reg service
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
Commit Message
Line 6:
Line 7: Enable vdsm-reg service
Line 8:
Line 9: Due to some typos in the vdsm-reg service name (vdsmd-reg instead of
vdsm-reg),
Line 10: the service is not enbaled after rpm installation.
s/enbaled/enabled/
Line 11:
Line 12: Change-Id: Id96224cd61e6cd1e88ca94649b71f2f5f88886c1
....................................................
File vdsm_reg/vdsm-config
Line 21: if [ -x /bin/systemctl ] ; then
Line 22: /bin/systemctl stop vdsm-reg.service > /dev/null 2>&1
Line 23: elif [ -x /sbin/service ] ; then
Line 24: /sbin/service vdsm-reg stop > /dev/null 2>&1
Line 25: fi
This part isn't mentioned in the commit message. Might be nice to describe it
as well.
Line 26:
Line 27: set_vars() {
Line 28: echo "[vars]" >> $VDSM_CONFIG #Adding ts for the coming scripts.
Line 29: echo "trust_store_path = " `$GETCONFITEM $VDSM_CONFIG vars
trust_store_path /etc/pki/vdsm` >> $VDSM_CONFIG
--
To view, visit http://gerrit.ovirt.org/8037
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id96224cd61e6cd1e88ca94649b71f2f5f88886c1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Fernando Granha Jeronimo <[email protected]>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
