Ewoud Kohl van Wijngaarden has posted comments on this change. Change subject: Enable vdsm-reg service ......................................................................
Patch Set 2: I would prefer that you didn't submit this (3 inline comments) Sorry for the split review, some more comments in line. I'm also unsure of the preferences of others, but I tend to split these things into separate commits. So one commit to fix the incorrect service name and one for the race condition. .................................................... Commit Message Line 3: AuthorDate: 2012-09-17 13:34:59 -0300 Line 4: Commit: Fernando Granha Jeronimo <[email protected]> Line 5: CommitDate: 2012-09-18 13:39:06 -0300 Line 6: Line 7: Enable vdsm-reg service Maybe make it clear the incorrect service name was used? Line 8: Line 9: Due to some typos in the vdsm-reg service name (vdsmd-reg instead of vdsm-reg), Line 10: the service is not enabled after rpm installation. Moreover, in the vdsm-config script, Line 11: the vdsm-reg service is disabled to avoid race conditions, once it is intended to be Line 5: CommitDate: 2012-09-18 13:39:06 -0300 Line 6: Line 7: Enable vdsm-reg service Line 8: Line 9: Due to some typos in the vdsm-reg service name (vdsmd-reg instead of vdsm-reg), I wouldn't refer to this as a typo but rather a bug. Line 10: the service is not enabled after rpm installation. Moreover, in the vdsm-config script, Line 11: the vdsm-reg service is disabled to avoid race conditions, once it is intended to be Line 12: executed just before the node is rebooted and the registration process should take place Line 13: only after reboot. .................................................... File vdsm_reg/vdsm-config Line 18: # when parameters are written to config file and the Line 19: # service is running. This is necessary, because the Line 20: # registration process can take place only after reboot. Line 21: if [ -x /bin/systemctl ] ; then Line 22: /bin/systemctl stop vdsm-reg.service > /dev/null 2>&1 Mixing tabs and spaces? Line 23: elif [ -x /sbin/service ] ; then Line 24: /sbin/service vdsm-reg stop > /dev/null 2>&1 Line 25: fi Line 26: -- To view, visit http://gerrit.ovirt.org/8037 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id96224cd61e6cd1e88ca94649b71f2f5f88886c1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fernando Granha Jeronimo <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Fernando Granha Jeronimo <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
