Antoni Segura Puimedon has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ......................................................................
Patch Set 4: (1 inline comment) .................................................... File vdsm/netconf/ifcfg.py Line 70: netmask = bridge.ip.inet.netmask Line 71: gateway = bridge.ip.inet.gateway Line 72: bootproto = bridge.ip.bootproto Line 73: except AttributeError: Line 74: ipaddr = netmask = gateway = bootproto = None Done Line 75: self.configWriter.addBridge(bridge.name, ipaddr=ipaddr, Line 76: netmask=netmask, mtu=bridge.mtu, Line 77: gateway=gateway, bootproto=bootproto, Line 78: **opts) -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches