Antoni Segura Puimedon has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ......................................................................
Patch Set 4: (1 inline comment) .................................................... File tests/configNetworkTests.py Line 54: # Monkey patch the real network detection from the netinfo module. Line 55: @MonkeyPatch(netinfo, 'networks', _fakeNetworks) Line 56: @MonkeyPatch(netinfo, 'getMaxMtu', lambda *x: 1500) Line 57: @MonkeyPatch(netconf.ifcfg, 'ifdown', lambda *x: raiseInvalidOpException()) Line 58: @MonkeyPatch(netconf.ifcfg, 'ifup', lambda *x: raiseInvalidOpException()) The references to ifdown and ifup should be taken out as soon as those two are not called outside of configurator code. Line 59: @MonkeyPatch(Bond, 'configure', lambda *x: raiseInvalidOpException()) Line 60: @MonkeyPatch(Bridge, 'configure', lambda *x: raiseInvalidOpException()) Line 61: @MonkeyPatch(Nic, 'configure', lambda *x: raiseInvalidOpException()) Line 62: @MonkeyPatch(Vlan, 'configure', lambda *x: raiseInvalidOpException()) -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
