Mark Wu has posted comments on this change.
Change subject: NetReload: netmodels for addNetwork
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm/configNetwork.py
Line 71: if bridged:
Line 72: topObj = Bridge(net, configurator, ports=[topObj] if topObj
else [],
Line 73: mtu=mtu, stp=opts.get('stp'),
Line 74: forwardDelay=opts.get('forward_delay', 0))
Line 75: topObj.ip = IpConfig(inet=IPv4(ipaddr, netmask, gateway),
It's also possible to just configure bonding from UI without network attached.
So it's better to add IpConfig only if ipaddr is not None.
Line 76: bootproto=bootproto)
Line 77: return topObj
Line 78:
Line 79:
--
To view, visit http://gerrit.ovirt.org/14303
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
