Antoni Segura Puimedon has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ......................................................................
Patch Set 4: (2 inline comments) .................................................... File vdsm/configNetwork.py Line 80: def objectivizeBond(bonding, bondingOptions, nics, mtu, _netinfo, Line 81: configurator): Line 82: if bonding and nics: Line 83: slaves = [] Line 84: bondMtu = netinfo.getMaxMtu(nics, mtu) Good catch. I seem to remember that I kept it from old code, but it makes sense to drop it. Line 85: for nic in nics: Line 86: _validateNicUnused(nic, _netinfo) Line 87: slaves.append(Nic(nic, configurator, mtu=bondMtu)) Line 88: elif bonding in _netinfo.bondings: # Implicit bonding. Line 86: _validateNicUnused(nic, _netinfo) Line 87: slaves.append(Nic(nic, configurator, mtu=bondMtu)) Line 88: elif bonding in _netinfo.bondings: # Implicit bonding. Line 89: nics = [nic for nic in _netinfo.getNicsForBonding(bonding)] Line 90: bondMtu = netinfo.getMaxMtu(nics, mtu) Done Line 91: slaves = [Nic(nic, configurator, mtu=bondMtu) for nic in nics] Line 92: bondingOptions = _netinfo.bondings[bonding]['cfg'].get( Line 93: 'BONDING_OPTS') Line 94: else: -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
