Mark Wu has posted comments on this change.
Change subject: NetReload: netmodels for addNetwork
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File vdsm/netmodels.py
Line 118: def __repr__(self):
Line 119: return 'Bridge(' + self.name + ')' + '\n|-' + '\n|-'.join(
Line 120: [repr(port) for port in self.ports])
Line 121:
Line 122: def configure(self, **opts):
no argument 'network'?
Line 123: self.configurator.configureBridge(self, **opts)
Line 124:
Line 125: def remove(self, force=False):
Line 126: logging.debug('Removing bridge %r with ports = %s', self.name,
Line 157:
Line 158: def __str__(self):
Line 159: return self.name
Line 160:
Line 161: def configure(self, **opts):
no argument 'network'?
Line 162: self.configurator.configureBond(self, **opts)
Line 163:
Line 164: def remove(self, force=False):
Line 165: logging.debug('Removing bond %r with nics = %s', self.name,
--
To view, visit http://gerrit.ovirt.org/14303
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
