Giuseppe Vallarelli has posted comments on this change. Change subject: NetReload: netmodels for addNetwork ......................................................................
Patch Set 4: (1 inline comment) .................................................... File vdsm/configNetwork.py Line 115: raise ConfigNetworkError(ne.ERR_BAD_BONDING, 'Multiple nics require a ' Line 116: 'bonding device') Line 117: nic = nics[0] Line 118: nicBond = _netinfo.getBondingForNic(nic) Line 119: if nic not in _netinfo.nics: Probably you should move this inside Nic class. Line 120: raise ConfigNetworkError(ne.ERR_BAD_NIC, 'unknown nic: %r' % nic) Line 121: elif nicBond and nicBond != bonding: Line 122: raise ConfigNetworkError(ne.ERR_USED_NIC, 'nic %s already enslaved to ' Line 123: '%s' % (nic, nicBond)) -- To view, visit http://gerrit.ovirt.org/14303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba5c5b84760e27245cbe34c3b290c54e51278e72 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com> Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches