On Fri, 07 Mar 2014 16:27:53 +0100, Antoine Musso <hashar+...@free.fr> wrote:
So a single -1 should prevent a change from being submitted until that -1 is lifted by addressing the person concern(s) or correcting him/her or whatever.
Note that such a rule never been followed by anyone, including by various WMF teams. You can easily find numerous examples, even if these searches are limited to only changesets where the -1 stuck on the last patchset. https://gerrit.wikimedia.org/r/#/q/is:merged+label:Code-Review-1,n,z (this search seems to hang forever) https://gerrit.wikimedia.org/r/#/q/is:merged+label:Code-Review-1+project:mediawiki/core,n,z -- Matma Rex _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
