On Sun, 19 Nov 2023 08:44:01 GMT, Alan Bateman wrote:
>> Implement the built-in Catalog.
>
> src/java.xml/share/classes/jdk/xml/internal/jdkcatalog/JDKCatalog.xml line 34:
>
>> 32:
>> 33: http://java.sun.com/dtd/preferences.dtd;
>> uri="J2SE/
On Thu, 16 Nov 2023 13:22:10 GMT, Matthias Baesken wrote:
>> src/java.base/windows/native/libnio/ch/Net.c line 160:
>>
>>> 158:
>>> 159: /* IPV6_V6ONLY is true by default */
>>> 160: /* attempt to disable IPV6_V6ONLY to ensure dual-socket
>>> support; ignore errors */
>>
>>
On Thu, 16 Nov 2023 15:52:02 GMT, Matthias Baesken wrote:
>> There are a few places in the JDK C coding where the setsocktopt return
>> value is not handled but better should be handled.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last
On Fri, 17 Nov 2023 21:51:06 GMT, Brian Burkhalter wrote:
> The method `windowsDriveRelative` of the test `java/io/File/GetAbsolutePath`
> was incorrectly translated from its previous version to the current JUnit 5
> version.
The test fix looks okay but the title on the issue is confusing, it
On Fri, 17 Nov 2023 11:28:23 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Adding @implSpec for Gatherer.andThen, plus adds
On Fri, 17 Nov 2023 08:07:02 GMT, Matthias Baesken wrote:
> Hi Alan, do you want an additional change to
> src/java.base/windows/native/libnio/ch/WindowsAsynchronousServerSocketChannelImpl.c
> ? Was not really sure about this after your comment about this chunk .
I think it's okay. The only
On Wed, 15 Nov 2023 22:46:03 GMT, Jorn Vernee wrote:
> See the JBS issue for an extended problem description.
>
> This patch changes the specification and implementation of
> `MethodHandles::byteArrayViewVarHandle`,
> `MethodHandles::byteBufferViewVarHandle`, `ByteBuffer::alignedSlice`, and
On 15/11/2023 17:13, Rob Spoor wrote:
Hello all,
I'm working on a module that makes working with FFM easier; think of
something like JNA. For instance, it allows creating structures
without having to manually manage var handles etc.
My module uses restricted mehods like
On Thu, 16 Nov 2023 13:14:16 GMT, Matthias Baesken wrote:
> Hi Alan, do you mean "drop this chunk from the change" or "drop the coding
> that is trying to copy the socket options" ?
Yes, I think drop SdpSupport.c from the PR. We probably should have removed the
SDP support a long time ago.
On Wed, 15 Nov 2023 18:33:47 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
>> which overrides and provides an implementation of `toString()` in
>> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
>>
>> This change is
On Thu, 16 Nov 2023 08:39:32 GMT, Matthias Baesken wrote:
> There are a few places in the JDK C coding where the setsocktopt return value
> is not handled but better should be handled.
src/java.base/unix/native/libnet/SdpSupport.c line 100:
> 98: if (getsockopt(fd, SOL_SOCKET,
On Thu, 16 Nov 2023 08:39:32 GMT, Matthias Baesken wrote:
> There are a few places in the JDK C coding where the setsocktopt return value
> is not handled but better should be handled.
src/java.base/windows/native/libnio/ch/Net.c line 160:
> 158:
> 159: /* IPV6_V6ONLY is true by
On 16/11/2023 08:40, Baesken, Matthias wrote:
Hi Alan, thanks for the comment.
I created https://bugs.openjdk.org/browse/JDK-8320168 .
Okay, but please note that putting checks into some of these places will
require testing across a very wide range of systems. There are at least
some
On Wed, 15 Nov 2023 17:50:48 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Improvements after feedback
Really nicely done.
On Tue, 14 Nov 2023 16:35:53 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Unpacking the rethrown exceptions from
On 14/11/2023 15:16, Baesken, Matthias wrote:
Hi, while looking at some net/nio coding, I noticed that at a lot of
places the return value of setsockopt is checked :
https://github.com/search?q=repo%3Aopenjdk%2Fjdk+%22setsockopt%22=code
On Tue, 14 Nov 2023 17:25:42 GMT, Darragh Clarke wrote:
>> Currently the `IsAlive` test occasionally times out.
>>
>> This PR changes the timeout from `10` to `25` which I think is an adequate
>> increase based on the failures I've seen. Though I'd be happy to change it
>> to another value if
On Tue, 14 Nov 2023 16:41:31 GMT, Darragh Clarke wrote:
> Currently the `IsAlive` test occasionally times out.
>
> This PR changes the timeout from `10` to `25` which I think is an adequate
> increase based on the failures I've seen. Though I'd be happy to change it to
> another value if
On Mon, 13 Nov 2023 22:31:16 GMT, Brent Christian wrote:
> Classes in the `java.lang.ref` package would benefit from an update to bring
> the spec in line with how the VM already behaves. The changes would focus on
> _happens-before_ edges at some key points during reference processing.
>
> A
On Fri, 10 Nov 2023 15:44:19 GMT, Yakov Shafranovich wrote:
>> The various Zip/Jar-file related Java APIs have some long-standing
>> differences or peculiarities with respect to the ZIP-file specification or
>> compared to other implementations which should be documented in the API-doc.
>>
On Fri, 10 Nov 2023 15:44:19 GMT, Yakov Shafranovich wrote:
>> The various Zip/Jar-file related Java APIs have some long-standing
>> differences or peculiarities with respect to the ZIP-file specification or
>> compared to other implementations which should be documented in the API-doc.
>>
On Fri, 10 Nov 2023 15:44:19 GMT, Yakov Shafranovich wrote:
>> The various Zip/Jar-file related Java APIs have some long-standing
>> differences or peculiarities with respect to the ZIP-file specification or
>> compared to other implementations which should be documented in the API-doc.
>>
On Mon, 13 Nov 2023 15:37:29 GMT, Severin Gehwolf wrote:
> It's not clear what you mean by that. Dropped from what? The CSR? Something
> else? The run-image based link needs the `--add-run-image-resources` plugin
> for it to work.
I mean the list of plugins that are listed by --list-plugins.
On Mon, 13 Nov 2023 21:59:05 GMT, Justin Lu wrote:
> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8319982)
> which overrides and provides an implementation of `toString()` in
> _java.util.zip.ZipFile_ (and by extension, _java.util.jar.JarFile_).
>
> This change is
On Mon, 13 Nov 2023 19:41:48 GMT, Brian Burkhalter wrote:
>> In the Windows implementation of java.io.File.getCanonicalPath, strip any
>> long path or UNC prefix before canonicalizing the remainder of the pathname.
>
> Brian Burkhalter has updated the pull request with a new target base due to
On Mon, 13 Nov 2023 16:00:05 GMT, Yakov Shafranovich wrote:
> That would probably also involve taking existing documentation such as the
> note about not opening entries with "."/"..", and the POSIX permissions
> mappings? Would it make sense to split the rest of the changes in this PR
> from
On Mon, 13 Nov 2023 16:00:05 GMT, Yakov Shafranovich wrote:
> That would probably also involve taking existing documentation such as the
> note about not opening entries with "."/"..", and the POSIX permissions
> mappings? Would it make sense to split the rest of the changes in this PR
> from
On Mon, 13 Nov 2023 16:00:05 GMT, Yakov Shafranovich wrote:
> That would probably also involve taking existing documentation such as the
> note about not opening entries with "."/"..", and the POSIX permissions
> mappings? Would it make sense to split the rest of the changes in this PR
> from
On Fri, 10 Nov 2023 16:30:35 GMT, suchismith1993 wrote:
> There is not generic way of generating this. It needs a manual intervention
> and symbols are to be added on a need basis in future. Looks like a list to
> be maintained. I had tried adding comments to explain the list, but that
>
On Fri, 10 Nov 2023 16:30:35 GMT, suchismith1993 wrote:
> There is not generic way of generating this. It needs a manual intervention
> and symbols are to be added on a need basis in future. Looks like a list to
> be maintained. I had tried adding comments to explain the list, but that
>
On Wed, 18 Oct 2023 17:37:30 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a "jmodless" jlink mode to the JDK.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> install might not come with the packaged modules (directory `jmods`). This
>>
On Fri, 10 Nov 2023 15:44:19 GMT, Yakov Shafranovich wrote:
>> The various Zip/Jar-file related Java APIs have some long-standing
>> differences or peculiarities with respect to the ZIP-file specification or
>> compared to other implementations which should be documented in the API-doc.
>>
On Fri, 10 Nov 2023 15:44:19 GMT, Yakov Shafranovich wrote:
>> The various Zip/Jar-file related Java APIs have some long-standing
>> differences or peculiarities with respect to the ZIP-file specification or
>> compared to other implementations which should be documented in the API-doc.
>>
On Fri, 10 Nov 2023 15:44:19 GMT, Yakov Shafranovich wrote:
>> The various Zip/Jar-file related Java APIs have some long-standing
>> differences or peculiarities with respect to the ZIP-file specification or
>> compared to other implementations which should be documented in the API-doc.
>>
On Wed, 4 Oct 2023 20:35:25 GMT, Brian Burkhalter wrote:
>> In the Windows implementation of java.io.File.getCanonicalPath, strip any
>> long path or UNC prefix before canonicalizing the remainder of the pathname.
>
> Brian Burkhalter has updated the pull request incrementally with one
>
On Fri, 10 Nov 2023 16:34:11 GMT, Maurizio Cimadamore
wrote:
> This simplePR tweaks the factory which wraps custom cleanup actions passed to
> `MemorySegment::reinterpret`, so that any exception thrown by the custom
> cleanup is swallowed when the arena is closed.
>
> This aligns the
On Fri, 10 Nov 2023 09:32:17 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Multiple improvements to Gatherer and
On 10/11/2023 07:26, Shruthi Shruthi1 wrote:
Hi Alan.,
Please let us know if you have any suggestions/inputs for the earlier
update.
Sorry, I can't help you. The SAP and IBM engineers maintain the AIX port
and may be able to help diagnose this issue, it sounds like dup2 is
problematic.
On Wed, 20 Apr 2022 14:30:21 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Could I get the following PR review please? It adds a new JDK specific
>> extended socket option
>> called IP_DONTFRAGMENT, which disables IP packet fragmentation in both IPv4
>> and IPv6
>> UDP sockets (NIO
On Wed, 20 Apr 2022 14:30:21 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Could I get the following PR review please? It adds a new JDK specific
>> extended socket option
>> called IP_DONTFRAGMENT, which disables IP packet fragmentation in both IPv4
>> and IPv6
>> UDP sockets (NIO
On Wed, 8 Nov 2023 21:08:03 GMT, Viktor Klang wrote:
>> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Addressing review feedback
> - Make
On Thu, 9 Nov 2023 09:42:41 GMT, Viktor Klang wrote:
>> src/java.base/share/classes/java/util/stream/Gatherers.java line 326:
>>
>>> 324:
>>> 325: /**
>>> 326: * Gathers elements into fixed-size windows. The last window may
>>> contain
>>
>> Returns a ...
>
> You mean "Returns a
On Mon, 30 Oct 2023 15:38:35 GMT, Viktor Klang wrote:
> This Pull-Request implements [JEP-461](https://openjdk.org/jeps/461)
src/java.base/share/classes/java/util/stream/Gatherer.java line 38:
> 36: /**
> 37: * An intermediate operation that transforms a stream of input elements
> into a
>
On Wed, 8 Nov 2023 16:03:22 GMT, Ryan Wallace wrote:
> Added and tested and it still works as expected.
@ryawalla Would it be possible to update the PR description so there's a clear
summary on the updated proposal? I think it aligns the behavior with what
happens when a bad file path is
On Tue, 7 Nov 2023 03:20:45 GMT, Alexey Semenyuk wrote:
> Remove `-Xmx512m` from the jtreg `@run` command as @AlanBateman suggested
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/16535#pullrequestreview-1718248698
On Tue, 7 Nov 2023 15:45:02 GMT, Alan Bateman wrote:
>> Jim Laskey has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 14 addi
On Tue, 7 Nov 2023 12:29:12 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Tue, 7 Nov 2023 15:45:02 GMT, Alan Bateman wrote:
>> Jim Laskey has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 14 addi
On Tue, 7 Nov 2023 12:29:12 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Tue, 7 Nov 2023 11:11:31 GMT, Erik Gahlin wrote:
>> Could I have a review of a PR that removes the bytecode instrumentation for
>> the exception events.
>>
>> Testing: jdk/jdk/jfr + tier1 + tier2
>
> Erik Gahlin has updated the pull request incrementally with one additional
> commit since
On Tue, 7 Nov 2023 11:11:31 GMT, Erik Gahlin wrote:
>> Could I have a review of a PR that removes the bytecode instrumentation for
>> the exception events.
>>
>> Testing: jdk/jdk/jfr + tier1 + tier2
>
> Erik Gahlin has updated the pull request incrementally with one additional
> commit since
On Tue, 7 Nov 2023 02:10:29 GMT, Erik Gahlin wrote:
> I filed an issue to investigate if there is a problem with SOE, or if the OOM
> check is really needed now. https://bugs.openjdk.org/browse/JDK-8319579
>
> Regardless of outcome, It would be good to document the results of the
>
On Tue, 7 Nov 2023 02:10:29 GMT, Erik Gahlin wrote:
> I filed an issue to investigate if there is a problem with SOE, or if the OOM
> check is really needed now. https://bugs.openjdk.org/browse/JDK-8319579
>
> Regardless of outcome, It would be good to document the results of the
>
On Mon, 6 Nov 2023 22:52:50 GMT, Erik Gahlin wrote:
>> Could I have a review of a PR that removes the bytecode instrumentation for
>> the exception events.
>>
>> Testing: jdk/jdk/jfr + tier1 + tier2
>
> Erik Gahlin has updated the pull request incrementally with one additional
> commit since
On Mon, 6 Nov 2023 22:52:50 GMT, Erik Gahlin wrote:
>> Could I have a review of a PR that removes the bytecode instrumentation for
>> the exception events.
>>
>> Testing: jdk/jdk/jfr + tier1 + tier2
>
> Erik Gahlin has updated the pull request incrementally with one additional
> commit since
On Mon, 6 Nov 2023 20:22:43 GMT, Mandy Chung wrote:
>> This is a regression caused by JDK-8302791. IAE should be thrown when an
>> interface is not visible to the given class loader but NPE is thrown instead
>> when the loader is null. The boot loader has no name and so the fix will
>>
On Tue, 7 Nov 2023 03:20:45 GMT, Alexey Semenyuk wrote:
> Remove `-Xmx512m` from the jtreg `@run` command as @AlanBateman suggested
Can you confirm that debug builds are passing with -XX:+UseZGC now?
-
PR Comment: https://git.openjdk.org/jdk/pull/16535#issuecomment-1797889256
On Mon, 6 Nov 2023 19:12:28 GMT, Mandy Chung wrote:
> This is a regression caused by JDK-8302791. IAE should be thrown when an
> interface is not visible to the given class loader but NPE is thrown instead
> when the loader is null. The boot loader has no name and so the fix will
> print
On Fri, 3 Nov 2023 12:19:07 GMT, Erik Gahlin wrote:
> Could I have a review of a PR that removes the bytecode instrumentation for
> the exception events.
>
> Testing: jdk/jdk/jfr + tier1 + tier2
src/java.base/share/classes/jdk/internal/event/ThrowableTracer.java line 37:
> 35: private
On Fri, 3 Nov 2023 12:19:07 GMT, Erik Gahlin wrote:
> Could I have a review of a PR that removes the bytecode instrumentation for
> the exception events.
>
> Testing: jdk/jdk/jfr + tier1 + tier2
src/java.base/share/classes/jdk/internal/event/ThrowableTracer.java line 37:
> 35: private
On Mon, 30 Oct 2023 16:16:52 GMT, Ryan Wallace wrote:
> Hi all,
>
> Please review this fix for jar tool not producing archive if there is a
> missing file supplied. Fix is to throw an exception and exit processing when
> a missing file is supplied. Current behaviour will recognise missing
On Mon, 30 Oct 2023 16:16:52 GMT, Ryan Wallace wrote:
> Hi all,
>
> Please review this fix for jar tool not producing archive if there is a
> missing file supplied. Fix is to throw an exception and exit processing when
> a missing file is supplied. Current behaviour will recognise missing
On Mon, 6 Nov 2023 05:34:04 GMT, David Holmes wrote:
>> test/hotspot/jtreg/serviceability/jvmti/stress/StackTrace/Suspended/libGetStackTraceSuspendedStress.cpp
>> line 125:
>>
>>> 123: err = jvmti->SetEventNotificationMode(JVMTI_ENABLE,
>>> JVMTI_EVENT_SINGLE_STEP, vthread);
>>> 124: if
On Fri, 3 Nov 2023 15:29:25 GMT, Jim Laskey wrote:
>> Update String Templates for a second preview. With the addition of
>>
>> - Expression type and throws are determined from the `process` method of the
>> processor type and not the processor type.
>>
>> - Qualified `STR` and `RAW` are
On Mon, 16 Oct 2023 14:31:46 GMT, Jim Laskey wrote:
> Wasn't sure about that. Thx.
When in doubt, JEP 12. Alex provided good guidance for API authors on how
`@since` should be used with preview APIs.
-
PR Review Comment:
On Mon, 16 Oct 2023 14:31:46 GMT, Jim Laskey wrote:
> Wasn't sure about that. Thx.
When in doubt, JEP 12. Alex provided good guidance for API authors on how
`@since` should be used with preview APIs.
-
PR Review Comment:
On Fri, 3 Nov 2023 15:29:25 GMT, Jim Laskey wrote:
>> Update String Templates for a second preview. With the addition of
>>
>> - Expression type and throws are determined from the `process` method of the
>> processor type and not the processor type.
>>
>> - Qualified `STR` and `RAW` are
On Mon, 30 Oct 2023 17:26:53 GMT, Yakov Shafranovich wrote:
> The various Zip/Jar-file related Java APIs have some long-standing
> differences or peculiarities with respect to the ZIP-file specification or
> compared to other implementations which should be documented in the API-doc.
> This
On Mon, 30 Oct 2023 17:26:53 GMT, Yakov Shafranovich wrote:
> The various Zip/Jar-file related Java APIs have some long-standing
> differences or peculiarities with respect to the ZIP-file specification or
> compared to other implementations which should be documented in the API-doc.
> This
On Mon, 30 Oct 2023 17:26:53 GMT, Yakov Shafranovich wrote:
> The various Zip/Jar-file related Java APIs have some long-standing
> differences or peculiarities with respect to the ZIP-file specification or
> compared to other implementations which should be documented in the API-doc.
> This
On Fri, 3 Nov 2023 05:43:38 GMT, David Holmes wrote:
> I don't understand what this is trying to do. If any virtual thread has an
> uncaught exception then other virtual threads will throw it wrapped in a
> RuntimeException. But the first virtual thread that completes (normally or by
>
On Thu, 2 Nov 2023 22:20:02 GMT, Martin Balao wrote:
>> src/java.base/share/classes/java/security/Security.java line 243:
>>
>>> 241: if (connection instanceof FileURLConnection
>>> fileConnection) {
>>> 242: // A local file URL can be interpreted as a Path
>>> 243:
On Thu, 2 Nov 2023 22:20:02 GMT, Martin Balao wrote:
>> src/java.base/share/classes/java/security/Security.java line 243:
>>
>>> 241: if (connection instanceof FileURLConnection
>>> fileConnection) {
>>> 242: // A local file URL can be interpreted as a Path
>>> 243:
On Tue, 31 Oct 2023 16:11:47 GMT, Joe Darcy wrote:
>> Clarify the intention of tier 1 tests. I'll reflow the paragraph and
>> regenerate the HTML file once the wording is agreed upon.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
On Thu, 2 Nov 2023 19:07:48 GMT, Francisco Ferrari Bihurriet
wrote:
> The implementation of this proposal is based on the requirements,
> specification and design choices described in the [JDK-8319332] ticket and
> its respective CSR [JDK-8319333]. What follows are implementation notes
>
On Thu, 2 Nov 2023 19:07:48 GMT, Francisco Ferrari Bihurriet
wrote:
> The implementation of this proposal is based on the requirements,
> specification and design choices described in the [JDK-8319332] ticket and
> its respective CSR [JDK-8319333]. What follows are implementation notes
>
On Thu, 2 Nov 2023 17:53:12 GMT, Jim Laskey wrote:
> I thought it was a clearer way to get rid of the side effect.
It means LauncherHelper.checkAndLoadMain description will need to be updated as
it says that it checks the public static void main method. But okay, I'll go
through what you have
On Thu, 2 Nov 2023 17:53:12 GMT, Jim Laskey wrote:
> I thought it was a clearer way to get rid of the side effect.
It means LauncherHelper.checkAndLoadMain description will need to be updated as
it says that it checks the public static void main method. But okay, I'll go
through what you have
On Thu, 2 Nov 2023 15:45:03 GMT, Jim Laskey wrote:
> Amazingly enough I seem to have the JNI straight on the first try.
Oh, I wasn't expecting that. My comment was suggesting we change
LauncherHelper.checkAndLoadMain to set both appClass and mainType after the
validate succeeds.
On Thu, 2 Nov 2023 15:45:03 GMT, Jim Laskey wrote:
> Amazingly enough I seem to have the JNI straight on the first try.
Oh, I wasn't expecting that. My comment was suggesting we change
LauncherHelper.checkAndLoadMain to set both appClass and mainType after the
validate succeeds.
On Thu, 2 Nov 2023 16:19:35 GMT, Mandy Chung wrote:
>> Tool modules can be created via `jmod --main-class` option such that
>> `ModuleMainClass` attribute will be added in `module-info.class` and the
>> module's main class can be launched via `java -m ` without
>> specifying the name of the
On Thu, 2 Nov 2023 12:33:27 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Thu, 2 Nov 2023 12:33:27 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Thu, 2 Nov 2023 12:33:27 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Thu, 2 Nov 2023 12:33:27 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Thu, 2 Nov 2023 10:57:15 GMT, Hannes Wallnöfer wrote:
>> This change fixes two errors in inline HTML styles in the `java.lang`
>> package:
>>
>> - wrong CSS property name in `java.lang.String`
>> - CSS declaration terminated by colon instead of semicolon in
>> `java.lang.Thread`
>>
>>
On Wed, 1 Nov 2023 19:14:22 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Wed, 1 Nov 2023 19:14:22 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> -
On Wed, 1 Nov 2023 19:58:07 GMT, Mandy Chung wrote:
> Tool modules can be created via `jmod --main-class` option such that
> `ModuleMainClass` attribute will be added in `module-info.class` and the
> module's main class can be launched via `java -m ` without
> specifying the name of the main
On Tue, 31 Oct 2023 20:45:11 GMT, Calvin Cheung wrote:
> Do you prefer the `canArchive` setting be inside `if
> (CDS.isDumpingStaticArchive())` like the following?
>
> ```
> if (CDS.isDumpingStaticArchive())
> canArchive = true;
> ```
That's fine. It has been harmless to have
On Wed, 1 Nov 2023 04:34:35 GMT, Calvin Cheung wrote:
>> Please review this changeset for adding support for `--module` (-m) option
>> for CDS.
>> Changes in the `ModuleBootstrap.java` are needed so that the
>> `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if
>> the
On Tue, 31 Oct 2023 20:14:45 GMT, Joe Darcy wrote:
> Due to their longer-than-typical running time and because the vector API is
> not (yet) in the base module, move the vector API tests in tier 1 to tier 2.
jdk_vector_sanity was added by JDK-8295970 to get some coverage in tier1. That
On Tue, 10 Oct 2023 15:09:41 GMT, Adam Sotona wrote:
> JImageValidator has been recently converted to use ClassFile API and original
> weak validation of class files was replaced with full class verification.
> Unfortunately full class verification is too strong as it includes class
>
On Mon, 16 Oct 2023 16:31:04 GMT, Brian Burkhalter wrote:
> The CSR was created.
Thanks. I changed the "Compatibility Risk" to medium and expanded its
description to more clearly explain the compatibility risk to fix this long
standing issue.
-
PR Comment:
On Mon, 30 Oct 2023 15:07:49 GMT, Viktor Klang wrote:
>> Discussed with @DougLea and adjusting the queue capacity to at least the
>> number of participating threads seems like the most sensible fix.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since
On Tue, 31 Oct 2023 06:17:34 GMT, Calvin Cheung wrote:
> I've added the following field in `ArchivedModuleGraph` so that the
> `get(String mainModuleName)` will check the `mainModule` before returning
> `archivedModuleGraph`. `private static String mainModule;` The `mainModule`
> field is
On Tue, 31 Oct 2023 06:11:50 GMT, Calvin Cheung wrote:
>> Please review this changeset for adding support for `--module` (-m) option
>> for CDS.
>> Changes in the `ModuleBootstrap.java` are needed so that the
>> `ArchivedModuleGraph.archive` and `ArchivedBootLayer.archive` are called if
>>
On Mon, 30 Oct 2023 17:16:54 GMT, Andrew Haley wrote:
>> The bug here is a thinko in `ScopedValue.scopedValueBindings()`.
>>
>> If the JVM runs out of resources, we throw a `VirtualMachineError`. Running
>> out of resources can happen at almost any time, and can happen while
>>
On Tue, 31 Oct 2023 00:23:44 GMT, Joe Darcy wrote:
>> Clarify the intention of tier 1 tests. I'll reflow the paragraph and
>> regenerate the HTML file once the wording is agreed upon.
>
> Joe Darcy has updated the pull request incrementally with one additional
> commit since the last revision:
On Fri, 1 Sep 2023 08:29:41 GMT, Alan Bateman wrote:
>> I think you may have missed the comment in the JBS issue. Logging means
>> running potentially arbitrary code, doing this at Runtime.halt time is
>> problematic. I thought the conclusion from the work on Runtime.exit
901 - 1000 of 18235 matches
Mail list logo