Re: [blink-dev] Intent to Ship: Tabbed web apps

On Wed, May 8, 2024 at 8:39 AM Alex Russell wrote: > I'm happy for this to be CrOS first, but would like to unpack Brett's > statement above a bit. If we (MSFT) were to polish this up for Windows, > would patches for that be accepted? > I can't speak for the browser team. But my current

Re: [blink-dev] Intent to Ship: Tabbed web apps

On Mon, May 6, 2024 at 3:02 AM Yoav Weiss (@Shopify) wrote: > > > On Fri, May 3, 2024 at 7:28 PM Brett Wilson wrote: > >> Contact emailsbre...@chromium.org, alancut...@chromium.org, >> mgi...@chromium.org, loubr...@google.com >> >> Explainer >> https:/

[blink-dev] Intent to Ship: Tabbed web apps

Contact emailsbre...@chromium.org, alancut...@chromium.org, mgi...@chromium.org, loubr...@google.com Explainer https://github.com/WICG/manifest-incubations/blob/gh-pages/tabbed-mode-explainer.md Specificationhttps://wicg.github.io/manifest-incubations/#dfn-tabbed Summary Allow web app windows

Re: [blink-dev] Intent to Continue Experimenting: Tabbed Web Apps

On Wed, Apr 10, 2024 at 8:29 AM Alex Russell wrote: > Great to hear there's support for the feature. > > 118-126 w/o breaking changes is pushing things. Is it practical to ship > inside the 123-126 window? How close are we?\ > Hi Alex, Sorry for the delay, we've been trying to figure out the

[PATCH] D139154: [clang-doc] Add template support

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a68babd9973: [clang-doc] Add template support. (authored by brettw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/

[clang-tools-extra] 4a68bab - [clang-doc] Add template support.

Author: Brett Wilson Date: 2022-12-08T08:02:02-08:00 New Revision: 4a68babd9973f043fd3e40f159fbb990880606a6 URL: https://github.com/llvm/llvm-project/commit/4a68babd9973f043fd3e40f159fbb990880606a6 DIFF: https://github.com/llvm/llvm-project/commit/4a68babd9973f043fd3e40f159fbb990880606a6.diff

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 480979. brettw added a comment. New patch with llvm::Optional converted to std::optional (previously collided with a refactor). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files:

[clang-tools-extra] 91b38c6 - Revert "[clang-doc] Add template support."

Author: Brett Wilson Date: 2022-12-07T10:22:51-08:00 New Revision: 91b38c6aaddefabad2a4c959ea3865e356761ed5 URL: https://github.com/llvm/llvm-project/commit/91b38c6aaddefabad2a4c959ea3865e356761ed5 DIFF: https://github.com/llvm/llvm-project/commit/91b38c6aaddefabad2a4c959ea3865e356761ed5.diff

[PATCH] D139154: [clang-doc] Add template support

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f6dbb5f1646: [clang-doc] Add template support. (authored by brettw). Changed prior to commit: https://reviews.llvm.org/D139154?vs=480560=480960#toc Repository: rG LLVM Github Monorepo CHANGES

[clang-tools-extra] 0f6dbb5 - [clang-doc] Add template support.

Author: Brett Wilson Date: 2022-12-07T09:48:13-08:00 New Revision: 0f6dbb5f164662c3e6a167a89e7a89f07c60e32b URL: https://github.com/llvm/llvm-project/commit/0f6dbb5f164662c3e6a167a89e7a89f07c60e32b DIFF: https://github.com/llvm/llvm-project/commit/0f6dbb5f164662c3e6a167a89e7a89f07c60e32b.diff

[PATCH] D139154: [clang-doc] Add template support

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:119-123 + // This variant (that takes no qualified name parameter) uses the Name as the + // QualName (very useful in unit tests to reduce verbosity). This can't use + // the empty string

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 480560. brettw marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D139154: [clang-doc] Add template support

brettw marked an inline comment as done. brettw added a comment. New patch up. Comment at: clang-tools-extra/test/clang-doc/single-file.cpp:19 // CHECK-NEXT:DefLocation: -// CHECK-NEXT: LineNumber: [[@LINE-8]] +// CHECK-NEXT: LineNumber: 11 //

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 480536. brettw marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 480251. brettw added a reviewer: paulkirth. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D139154: [clang-doc] Add template support

brettw updated this revision to Diff 479772. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139154/new/ https://reviews.llvm.org/D139154 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/BitcodeWriter.h

[PATCH] D139154: [clang-doc] Add template support

brettw created this revision. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Decodes the template parameters for both functions and records. For template specializations, records a

[PATCH] D138961: [clang-doc] Fix warnings about lock_guard.

brettw created this revision. brettw added a project: clang-tools-extra. Herald added a subscriber: arphaman. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Fixes a warning about a potentially unsupported template argument deduction

[PATCH] D138073: [clang-doc] Move file layout to the generators.

This revision was automatically updated to reflect the committed changes. Closed by commit rG7b8c7e02122a: [clang-doc] Move file layout to the generators. (authored by brettw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/

[clang-tools-extra] 7b8c7e0 - [clang-doc] Move file layout to the generators.

Author: Brett Wilson Date: 2022-11-29T14:40:58-08:00 New Revision: 7b8c7e02122a2ea392b371e3e39b405bc98146de URL: https://github.com/llvm/llvm-project/commit/7b8c7e02122a2ea392b371e3e39b405bc98146de DIFF: https://github.com/llvm/llvm-project/commit/7b8c7e02122a2ea392b371e3e39b405bc98146de.diff

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw updated this revision to Diff 478683. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/ https://reviews.llvm.org/D138073 Files: clang-tools-extra/clang-doc/Generators.h clang-tools-extra/clang-doc/HTMLGenerator.cpp clang-tools-extra/clang-doc/MDGenerator.cpp

[PATCH] D138073: [clang-doc] Move file layout to the generators.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8a469fc5727: [clang-doc] Move file layout to the generators. (authored by brettw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/

[clang-tools-extra] f8a469f - [clang-doc] Move file layout to the generators.

Author: Brett Wilson Date: 2022-11-22T10:27:29-08:00 New Revision: f8a469fc572778d05b72f34a772082cf3abd3cda URL: https://github.com/llvm/llvm-project/commit/f8a469fc572778d05b72f34a772082cf3abd3cda DIFF: https://github.com/llvm/llvm-project/commit/f8a469fc572778d05b72f34a772082cf3abd3cda.diff

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:890-892 +// TODO If there are multiple Infos for this file name (for example, +// template specializations), this will generate multiple complete web pages +// (with and , etc.)

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw updated this revision to Diff 476955. brettw marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/ https://reviews.llvm.org/D138073 Files: clang-tools-extra/clang-doc/Generators.h

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:890-892 +// TODO If there are multiple Infos for this file name (for example, +// template specializations), this will generate multiple complete web pages +// (with and , etc.)

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw updated this revision to Diff 476612. brettw marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/ https://reviews.llvm.org/D138073 Files: clang-tools-extra/clang-doc/Generators.h clang-tools-extra/clang-doc/HTMLGenerator.cpp

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:890-892 +// TODO If there are multiple Infos for this file name (for example, +// template specializations), this will generate multiple complete web pages +// (with and , etc.)

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw updated this revision to Diff 476183. brettw marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/ https://reviews.llvm.org/D138073 Files: clang-tools-extra/clang-doc/Generators.h clang-tools-extra/clang-doc/HTMLGenerator.cpp

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw updated this revision to Diff 475869. brettw added a comment. Updated the lit tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138073/new/ https://reviews.llvm.org/D138073 Files: clang-tools-extra/clang-doc/Generators.h clang-tools-extra/clang-doc/HTMLGenerator.cpp

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw added a comment. If you're curious, you can see the simplification the YAML output format change makes in the consuming code: https://fuchsia-review.git.corp.google.com/c/fuchsia/+/760570/2/tools/cppdocgen/clangdoc/clangdoc.go Since it allows us to remove some special-casing code for

[PATCH] D138073: [clang-doc] Move file layout to the generators.

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Herald added a project: All. brettw requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Previously file

[PATCH] D136894: Add clang-doc readme

brettw abandoned this revision. brettw added a comment. Ok thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136894/new/ https://reviews.llvm.org/D136894 ___ cfe-commits mailing list

[PATCH] D136894: Add clang-doc readme

brettw added a comment. I definitely wasn't intending to write "formal documentation" for clang-doc. I was trying to write some notes for a future contributor as I'm winding down my work here, and it seems nobody else is working on it or has any knowledge about it. Is there a place in LLVM for

[PATCH] D136894: Add clang-doc readme

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Adds a readme to clang-doc with an overview of the structure of the code.

[PATCH] D136638: [clang-doc] Fix typedef/using output.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7231c9966e52: [clang-doc] Fix typedef/using output. (authored by brettw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang-tools-extra] 7231c99 - [clang-doc] Fix typedef/using output.

Author: Brett Wilson Date: 2022-10-25T13:47:24-07:00 New Revision: 7231c9966e523a6fa20aa63b9a9245aff49cf881 URL: https://github.com/llvm/llvm-project/commit/7231c9966e523a6fa20aa63b9a9245aff49cf881 DIFF: https://github.com/llvm/llvm-project/commit/7231c9966e523a6fa20aa63b9a9245aff49cf881.diff

[PATCH] D136638: [clang-doc] Fix typedef/using output.

brettw updated this revision to Diff 470598. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136638/new/ https://reviews.llvm.org/D136638 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/Representation.h

[PATCH] D136638: [clang-doc] Fix typedef/using output.

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Provides an initializer for the TypedefInfo.IsUsing member. Previously this

[clang-tools-extra] 21fb70c - [clang-doc] Add typedef/using information.

Author: Brett Wilson Date: 2022-10-14T14:59:29-07:00 New Revision: 21fb70c6ab3b25fe8f5f8384714a9a359b4b5a54 URL: https://github.com/llvm/llvm-project/commit/21fb70c6ab3b25fe8f5f8384714a9a359b4b5a54 DIFF: https://github.com/llvm/llvm-project/commit/21fb70c6ab3b25fe8f5f8384714a9a359b4b5a54.diff

[PATCH] D134371: [clang-doc] Add typedef/using information.

This revision was automatically updated to reflect the committed changes. Closed by commit rG21fb70c6ab3b: [clang-doc] Add typedef/using information. (authored by brettw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw updated this revision to Diff 467895. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llvm.org/D134371 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/BitcodeWriter.h

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw updated this revision to Diff 467894. brettw added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llvm.org/D134371 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw reopened this revision. brettw added a comment. This revision is now accepted and ready to land. New patch up to fix warnings that caused the revert. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llvm.org/D134371

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw updated this revision to Diff 466858. brettw added a comment. Fixed -Wall issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llvm.org/D134371 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:336 Reference *I, FieldId ) { switch (ID) { case REFERENCE_USR: haowei wrote: > This block ID came from L582, which read from a bitcode file

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

brettw added a comment. I can guarantee that nobody uses this for anything useful because it doesn't work well enough. For example, before I started changing it, requesting HTML output crashed on startup and many of the most basic syntactic things were broken. My previous patch changed enums

Re: [PATCH] D134235: [clang-doc] Clean up *Info constructors.

On Mon, Sep 26, 2022 at 1:42 PM Haowei Wu via Phabricator < revi...@reviews.llvm.org> wrote: > haowei added a comment. > > @brettw Thanks for the clarification. I was oncall for buildgardener last > week and got quite busy due to breakages. > > Thanks for your clarification, that is really

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/Representation.h:202 + bool IsFileInRootDir = false) : LineNumber(LineNumber), Filename(std::move(Filename)), IsFileInRootDir(IsFileInRootDir) {} paulkirth wrote: >

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:540 } - template <> void addChild(NamespaceInfo *I, EnumInfo &) { paulkirth wrote: > nit: can we avoid unrelated changes to whitespace here and elsewhere in the > patch?

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw updated this revision to Diff 462313. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134371/new/ https://reviews.llvm.org/D134371 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/BitcodeWriter.h

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

brettw updated this revision to Diff 462281. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134235/new/ https://reviews.llvm.org/D134235 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/BitcodeWriter.h

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

brettw marked an inline comment as done. brettw added a comment. If you have more questions, I can schedule a meeting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134235/new/ https://reviews.llvm.org/D134235

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

brettw marked an inline comment as done. brettw added a comment. First, for the mechanical part of the change, this code implement multiple constructors:   Info() = default;   Info(InfoType IT) : IT(IT) {}   Info(InfoType IT, SymbolID USR) : USR(USR), IT(IT) {}   Info(InfoType IT, SymbolID USR,

[PATCH] D134371: [clang-doc] Add typedef/using information.

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added a subscriber: arphaman. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Read typedef and "using" type alias

[PATCH] D134235: [clang-doc] Clean up *Info constructors.

brettw created this revision. Herald added a project: All. brettw requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. The *Info object (for the copy of the AST") constructors had many duplicated variants. Many of the variants

[PATCH] D134225: [clang-doc] Centralize TypeInfo creation.

brettw updated this revision to Diff 461397. brettw marked an inline comment as done. brettw added a comment. Comment addressed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134225/new/ https://reviews.llvm.org/D134225 Files: clang-tools-extra/clang-doc/Representation.h

[PATCH] D134055: [clang-doc] Add support for explicitly typed enums

brettw updated this revision to Diff 461366. brettw added a comment. Clang-formatted CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134055/new/ https://reviews.llvm.org/D134055 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D134225: [clang-doc] Centralize TypeInfo creation.

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Several different places in the code had similar computations for the

[PATCH] D134055: [clang-doc] Add support for explicitly typed enums

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:53 +llvm::Error decodeRecord(const Record , llvm::APSInt , llvm::StringRef Blob) { + auto ByteWidth = R[0]; paulkirth wrote: > brettw wrote: > > paulkirth wrote: > > > do

[PATCH] D134055: [clang-doc] Add support for explicitly typed enums

brettw updated this revision to Diff 461259. brettw marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134055/new/ https://reviews.llvm.org/D134055 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D134055: [clang-doc] Export enum type and value information.

brettw added inline comments. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:53 +llvm::Error decodeRecord(const Record , llvm::APSInt , llvm::StringRef Blob) { + auto ByteWidth = R[0]; paulkirth wrote: > do you need to do all of this? APSInt

[PATCH] D134055: [clang-doc] Export enum type and value information.

brettw updated this revision to Diff 460882. brettw marked 2 inline comments as done. brettw retitled this revision from "[clang-doc] Export more enum information" to "[clang-doc] Export enum type and value information.". brettw edited the summary of this revision. Repository: rG LLVM Github

[PATCH] D134055: [clang-doc] Export more enum information

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Add support for explicitly typed enums: enum Foo : unsigned { ... }; to

[PATCH] D133732: [clang-doc] Support default args for functions.

brettw updated this revision to Diff 460538. brettw marked 4 inline comments as done. brettw added a comment. There is no usage change for this. It just adds another field to the YAML. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133732/new/ https://reviews.llvm.org/D133732 Files:

[PATCH] D133732: [clang-doc] Support default args for functions.

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Adds support for default arguments in the internal representation and reads

[PATCH] D131739: [clang-doc] Always emit the TagType for RecordInfo

brettw added a comment. In D131739#3719634 , @paulkirth wrote: > Can you update the summary to reflect what's in this change now + add a tag > for clang-doc? > > `[clang-doc] Always emit the TagType for RecordInfo` > > I can land this and D131793

[PATCH] D131793: [clang-doc] Fix assert on startup

brettw added a comment. In D131793#3719619 , @paulkirth wrote: > This is LGTM, but can you add a tag to the summary title/commit message? ie. > `[clang-doc] Fix assert on startup in clang-doc` Done Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D131739: Fix some clang-doc issues.

brettw updated this revision to Diff 452227. brettw edited the summary of this revision. brettw added a comment. Startup assert fix broken out into https://reviews.llvm.org/D131793 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131739/new/ https://reviews.llvm.org/D131739 Files:

[PATCH] D131793: Fix assert on startup in clang-doc

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. When using `clang-doc

[PATCH] D131739: Fix some clang-doc issues.

brettw created this revision. brettw added a reviewer: paulkirth. brettw added a project: clang-tools-extra. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Always emit the TagType for

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 451882. brettw marked 2 inline comments as done. brettw added a comment. New patch up with requested changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131298/new/ https://reviews.llvm.org/D131298 Files:

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw added inline comments. Comment at: clang-tools-extra/unittests/clang-doc/SerializeTest.cpp:166 + ExpectedE.Members.emplace_back("int", "value", AccessSpecifier::AS_public); + //ExpectedE.Members.back().Description.push_back(MakeOneLineCommentInfo(" Some docs"));

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 451632. brettw added a comment. New patch up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131298/new/ https://reviews.llvm.org/D131298 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 451299. brettw marked an inline comment as done. brettw added a comment. I updated the comment test that's not currently working with a TODO. There are some open questions in the code review about some bigger questions about this tool. Since this has been

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw marked 2 inline comments as done. brettw added inline comments. Comment at: clang-tools-extra/clang-doc/Serialize.cpp:439 +static void populateMemberTypeInfo(MemberTypeInfo , const FieldDecl *D) { + ASTContext& Context = D->getASTContext(); + RawComment *Comment =

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 451001. brettw marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131298/new/ https://reviews.llvm.org/D131298 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw added a comment. Comment at: clang-tools-extra/clang-doc/BitcodeReader.cpp:354 +template <> llvm::Expected getCommentInfo(MemberTypeInfo *I) { + I->Description.emplace_back(); + return >Description.back(); paulkirth wrote: > So, I see that this uses

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 450976. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131298/new/ https://reviews.llvm.org/D131298 Files: clang-tools-extra/clang-doc/BitcodeReader.cpp clang-tools-extra/clang-doc/BitcodeWriter.cpp clang-tools-extra/clang-doc/Representation.h

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw updated this revision to Diff 450967. brettw added a comment. Herald added subscribers: usaxena95, arphaman. Added some tests (with one open question). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131298/new/ https://reviews.llvm.org/D131298 Files:

[PATCH] D131298: [clang-doc] Read docstrings for record members

brettw created this revision. brettw added a reviewer: phosek. brettw added a project: clang-tools-extra. Herald added a project: All. brettw requested review of this revision. Herald added a subscriber: cfe-commits. Struct/class data members did not have the comments associated with them. This

Re: [webkit-dev] Changing the implementation of KURL

On Sat, Jan 28, 2012 at 12:19 AM, Adam Barth aba...@webkit.org wrote: On Fri, Jan 27, 2012 at 9:44 PM, Darin Fisher da...@chromium.org wrote: On Fri, Jan 27, 2012 at 2:39 AM, Adam Barth aba...@webkit.org wrote: On Fri, Jan 27, 2012 at 1:49 AM, Maciej Stachowiak m...@apple.com wrote: That

Re: [webkit-dev] Changing the implementation of KURL

On Sat, Jan 28, 2012 at 4:07 PM, Maciej Stachowiak m...@apple.com wrote: On Jan 28, 2012, at 9:24 AM, Brett Wilson wrote: On Sat, Jan 28, 2012 at 12:19 AM, Adam Barth aba...@webkit.org wrote: On Fri, Jan 27, 2012 at 9:44 PM, Darin Fisher da...@chromium.org wrote: On Fri, Jan 27, 2012 at 2:39

Re: [webkit-dev] Changing the implementation of KURL

On Sat, Jan 28, 2012 at 4:48 PM, Brett Wilson bre...@chromium.org wrote: On Sat, Jan 28, 2012 at 4:07 PM, Maciej Stachowiak m...@apple.com wrote: On Jan 28, 2012, at 9:24 AM, Brett Wilson wrote: On Sat, Jan 28, 2012 at 12:19 AM, Adam Barth aba...@webkit.org wrote: On Fri, Jan 27, 2012 at 9

Re: [webkit-dev] Changing the implementation of KURL

On Sat, Jan 28, 2012 at 5:28 PM, Joe Mason jma...@rim.com wrote: -Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev- boun...@lists.webkit.org] On Behalf Of Maciej Stachowiak Sent: Saturday, January 28, 2012 7:08 PM To: Brett Wilson Cc: Benjamin Poulain

Re: [webkit-dev] no URL validation checking in KURLGoogle?

On Fri, Nov 11, 2011 at 12:29 AM, Huang, Deqing deqing.hu...@intel.com wrote: Hi, It seems that KURLGoogle is not validating url, it simply marks url as valid. I tested an invalid url http://a a/ in Chrome, it tried to open it and failed. In FireFox for this kind of url it will pop out a

Re: [webkit-dev] Adding ENABLE_BATTERY_STATUS to WebCore

On Wed, Jun 15, 2011 at 9:30 AM, Holger Freyther ze...@selfish.org wrote: On 06/15/2011 06:11 PM, laszlo.1.gom...@nokia.com wrote: Hi, The use-case for us is to enable content developers to implement rudimentary power management (e.g. to stop expensive operations on the page, perhaps

Re: [webkit-dev] Correct relative URL behavior

On Wed, May 4, 2011 at 2:49 AM, Maciej Stachowiak m...@apple.com wrote: On May 4, 2011, at 2:33 AM, Xianzhu Wang wrote: Hi, KURL's relative URL behavior is different between Chromium and non-Chromium ports, because Chromium ports use KURLGoogle.cpp instead of KURL.cpp. In KURL(base,

[rrd-users] Once a day updates incorrect by timezone

Hi All, Im monitoring my solar power installation and logging it into rrdtool then graphing the output. *http://powermonitoring.zzl.org/* Its all working well apart from the daily updates which run at midnight each night (local time) and pull the KwH produced today and the Time online today from

[v8-dev] Re: [Chrome-team] Opera 10.60 alpha 1 released

On Mon, May 31, 2010 at 10:23 AM, Peter Kasting pkast...@google.com wrote: Announcement: http://my.opera.com/desktopteam/blog/2010/05/31/opera-10-60-alpha-1 According to various blogs, a few of the major changes are that this build scores dramatically higher (50-100%) than Opera 10.50 on

Re: [chromium-dev] Interesting performance characteristics of http://a.qoid.us/google.html

On Mon, Jan 11, 2010 at 9:04 PM, Chris Evans cev...@chromium.org wrote: Hi, I found this interesting: http://a.qoid.us/google.html Because it's clearly very non-JavaScript focused (just a CSS rotation) and yet the browsers exhibit very different performance characteristics. All on my

Re: [chromium-dev] Interesting performance characteristics of http://a.qoid.us/google.html

On Tue, Jan 12, 2010 at 11:33 AM, Evan Martin e...@chromium.org wrote: On Tue, Jan 12, 2010 at 10:17 AM, Brett Wilson bre...@chromium.org wrote: I imagine the problems on Linux are the same as they were on Windows, where the underlying graphics layer wants to place glyphs aligned on pixel

Re: [chromium-dev] How can I tell if a Renderer process finishes loading a page

On Mon, Jan 11, 2010 at 12:59 AM, hap 497 hap...@gmail.com wrote: Thank you. But when I load www.cnn.com, I see something strange: First the throbber is spinning, and then the cnn fave icon is shown and then the throbber is spinning again, and then fave icon is shown. And then the fave icon

Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

On Mon, Dec 7, 2009 at 1:43 PM, Bradley Nelson bradnel...@google.com wrote: Hello All, Last week I re-landed a change to split off parts of chrome.gyp into .gypi's in the same directory. I had done something similar a couple weeks back, but took it out because concern was raised about merge

Re: [chromium-dev] Thoughts on // NOLINT?

On Wed, Dec 9, 2009 at 4:24 PM, John Abd-El-Malek j...@chromium.org wrote: btw I searched the code, almost all the instances are in code from different repositories, like v8, gtest, gmock.  I counted only 17 instances in Chrome's code. Most of the Chrome NOLINTs look like the're around

[chromium-dev] Re: Changes to using threads in the browser process

On Tue, Nov 3, 2009 at 6:01 AM, Mike Pinkerton pinker...@chromium.org wrote: Can you put this information, as well as some examples for proper usage, on dev.chromium.org. I doubt this stuff is very well documented from the perspective of someone trying to use it, and this looks like a great

[chromium-dev] Re: Tab Thumbnails and Aero Peek (of Windows 7)

2009/10/23 Hironori Bono (坊野 博典) hb...@google.com: Hi Brett, Thank you so much for noticing this. I'm integrating the ThumbnailGenertor class into my prototype now. :) By the way, I'm a little wondering if there is a function that changes the width and the height of a thumbnail image

[chromium-dev] Re: Tab Thumbnails and Aero Peek (of Windows 7)

Hi Hironori, Thanks for researching this topic. On generating thumbnails, I wrote chrome/browser/tab_contents/thumbnail_generator which tries to get the most up-to-date thumbnail images for all tabs (except ones that haven't ever been shown) with minimal performance overhead. The code hasn't

[chromium-dev] Re: Spellchecker and memory-mapped dicts

On Thu, Oct 22, 2009 at 1:39 PM, Evan Stade est...@chromium.org wrote: Hi all, At its last meeting the jank task force discussed improving responsiveness of the spellchecker but we didn't come to a solid conclusion so I thought I'd bring it up here to see if anyone else has opinions. The

[chromium-dev] Re: Brent's Windows port of WebKit moving to Skia

On Mon, Oct 19, 2009 at 7:27 AM, Evan Martin e...@chromium.org wrote: On Sun, Oct 18, 2009 at 11:58 PM, Adam Barth aba...@chromium.org wrote: It looks like Brent Fulgham is strongly considering moving his Windows WebKit port to Skia:

  1   2   3   >