Re: [PR] KAFKA-15588 ConfigCommandIntegrationTest rewritten in java [kafka]

2024-04-10 Thread via GitHub
nizhikov commented on PR #15645: URL: https://github.com/apache/kafka/pull/15645#issuecomment-2046644817 > I prefer to don't touch it. This class is all about zk and we can remove it once we remove zk support. So we want to rewrite in java KRaft tests only. Is it correct? I

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-04-10 Thread via GitHub
cadonna merged PR #15585: URL: https://github.com/apache/kafka/pull/15585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Reopened] (KAFKA-15538) Client support for java regex based subscription

2024-04-10 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reopened KAFKA-15538: --- > Client support for java regex based subscription >

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

2024-04-10 Thread via GitHub
OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559054203 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

[jira] [Reopened] (KAFKA-15793) Flaky test ZkMigrationIntegrationTest.testMigrateTopicDeletions

2024-04-10 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez reopened KAFKA-15793: - This has come up again:   {code:java} [2024-04-09T21:06:17.307Z] Gradle Test Run :core:test >

[jira] (KAFKA-15793) Flaky test ZkMigrationIntegrationTest.testMigrateTopicDeletions

2024-04-10 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15793 ] Igor Soarez deleted comment on KAFKA-15793: - was (Author: soarez): This has come up again:   {code:java} [2024-04-09T21:06:17.307Z] Gradle Test Run :core:test > Gradle Test Executor 97 >

Re: [PR] KAFKA-16272: Adding new coordinator related changes for connect_distributed.py [kafka]

2024-04-10 Thread via GitHub
lucasbru commented on PR #15594: URL: https://github.com/apache/kafka/pull/15594#issuecomment-2046963651 @vamossagar12 did the test you ran pass? Here is an example how I run parameterized tests using a test suite file: ``` consumer_test: -

Re: [PR] KAFKA-15588 ConfigCommandIntegrationTest rewritten in java [kafka]

2024-04-10 Thread via GitHub
chia7712 commented on PR #15645: URL: https://github.com/apache/kafka/pull/15645#issuecomment-2047302613 > I thought we want to move all code related to the ConfigCommand to java and remove it when ZK support will be dropped. Personally, rewriting a class which will get removed

Re: [PR] KAFKA-16004: auto-commit inflight improved logs, docs and tests [kafka]

2024-04-10 Thread via GitHub
cadonna merged PR #15669: URL: https://github.com/apache/kafka/pull/15669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15951: MissingSourceTopicException should include topic names [kafka]

2024-04-10 Thread via GitHub
chickenchickenlove commented on PR #15573: URL: https://github.com/apache/kafka/pull/15573#issuecomment-2046916043 Gently ping, @mjsax . Would you please take a look when you have some free time? ‍♂️ -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-16389: ConsumerEventHandler does not support incremental assignment changes causing failure in system test [kafka]

2024-04-10 Thread via GitHub
lucasbru commented on code in PR #15661: URL: https://github.com/apache/kafka/pull/15661#discussion_r1559094045 ## tests/kafkatest/services/verifiable_consumer.py: ## @@ -135,6 +135,28 @@ def last_commit(self, tp): else: return None +# This needs to be

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

2024-04-10 Thread via GitHub
soarez commented on PR #15136: URL: https://github.com/apache/kafka/pull/15136#issuecomment-2046971782 @showuon PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

2024-04-10 Thread via GitHub
OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559022658 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

Re: [PR] KAFKA-16297: Race condition while promoting future replica [kafka]

2024-04-10 Thread via GitHub
showuon merged PR #15557: URL: https://github.com/apache/kafka/pull/15557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR : Replaced the while loop with TestUtils.waitForCondition [kafka]

2024-04-10 Thread via GitHub
chiacyu commented on PR #15678: URL: https://github.com/apache/kafka/pull/15678#issuecomment-2047169130 If the condition doesn't meet within the maxWaitMs, the waitForCondition would throw the assertion failure. Do we need another timeout to handle that? -- This is an automated message

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

2024-04-10 Thread via GitHub
vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1559256180 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +537,45 @@ public void

Re: [PR] KAFKA-16082: Avoid resuming future replica if current replica is in the same directory [kafka]

2024-04-10 Thread via GitHub
showuon commented on PR #15136: URL: https://github.com/apache/kafka/pull/15136#issuecomment-2047306952 Will check it again within this week. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

2024-04-10 Thread via GitHub
OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559064580 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

Re: [PR] KAFKA-15588 ConfigCommandIntegrationTest rewritten in java [kafka]

2024-04-10 Thread via GitHub
nizhikov commented on PR #15645: URL: https://github.com/apache/kafka/pull/15645#issuecomment-2047311878 > I mean we can add more tests for zk and kraft in this PR, and it would be nice to use new test infra (ClusterTestExtensions) to rewrite it. WDYT? Agree. I will try to extend

Re: [PR] KAFKA-16294: Add group protocol migration enabling config [kafka]

2024-04-10 Thread via GitHub
dajac commented on PR #15411: URL: https://github.com/apache/kafka/pull/15411#issuecomment-2046712467 Re-triggered a build as last one had errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (KAFKA-15793) Flaky test ZkMigrationIntegrationTest.testMigrateTopicDeletions

2024-04-10 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835652#comment-17835652 ] Igor Soarez commented on KAFKA-15793: - This has come up again:   {code:java}

[jira] [Comment Edited] (KAFKA-15793) Flaky test ZkMigrationIntegrationTest.testMigrateTopicDeletions

2024-04-10 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835653#comment-17835653 ] Igor Soarez edited comment on KAFKA-15793 at 4/10/24 8:56 AM: -- This has

Re: [PR] KAFKA-16436: Online upgrade triggering and group type conversion [kafka]

2024-04-10 Thread via GitHub
dajac commented on code in PR #15662: URL: https://github.com/apache/kafka/pull/15662#discussion_r1559052702 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -761,6 +776,58 @@ public ClassicGroup classicGroup( }

[jira] [Commented] (KAFKA-8250) Flaky Test DelegationTokenEndToEndAuthorizationTest#testProduceConsumeViaAssign

2024-04-10 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835654#comment-17835654 ] Igor Soarez commented on KAFKA-8250: This failed again in

Re: [PR] MINOR: Improve logging in AssignmentsManager [kafka]

2024-04-10 Thread via GitHub
showuon commented on PR #15522: URL: https://github.com/apache/kafka/pull/15522#issuecomment-2047072476 Sorry, forgot about this PR. The jdk8 job failed to complete due to infra's issue. Re-triggering now: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15522/6/ -- This is an

Re: [PR] KAFKA-16197: Print Connect worker specific logs on poll timeout expiry [kafka]

2024-04-10 Thread via GitHub
vamossagar12 commented on code in PR #15305: URL: https://github.com/apache/kafka/pull/15305#discussion_r1559253060 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java: ## @@ -533,6 +536,47 @@ public void

[jira] [Assigned] (KAFKA-15309) Add custom error handler to Producer

2024-04-10 Thread Alieh Saeedi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alieh Saeedi reassigned KAFKA-15309: Assignee: (was: Alieh Saeedi) > Add custom error handler to Producer >

Re: [PR] MINOR: Remove dead code of metric forward-rate [kafka]

2024-04-10 Thread via GitHub
cadonna merged PR #15686: URL: https://github.com/apache/kafka/pull/15686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Add type check to classic group timeout operations [kafka]

2024-04-10 Thread via GitHub
dajac commented on code in PR #15587: URL: https://github.com/apache/kafka/pull/15587#discussion_r1558986456 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -2415,6 +2415,22 @@ private CoordinatorResult

[jira] [Created] (KAFKA-16503) getOrMaybeCreateClassicGroup should not thrown GroupIdNotFoundException

2024-04-10 Thread David Jacot (Jira)
David Jacot created KAFKA-16503: --- Summary: getOrMaybeCreateClassicGroup should not thrown GroupIdNotFoundException Key: KAFKA-16503 URL: https://issues.apache.org/jira/browse/KAFKA-16503 Project: Kafka

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

2024-04-10 Thread via GitHub
dajac commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1558996031 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

[jira] [Created] (KAFKA-16505) KIP-1034: Dead letter queue in Kafka Streams

2024-04-10 Thread Damien Gasparina (Jira)
Damien Gasparina created KAFKA-16505: Summary: KIP-1034: Dead letter queue in Kafka Streams Key: KAFKA-16505 URL: https://issues.apache.org/jira/browse/KAFKA-16505 Project: Kafka Issue

Re: [PR] KAFKA-16297: Race condition while promoting future replica [kafka]

2024-04-10 Thread via GitHub
showuon commented on PR #15557: URL: https://github.com/apache/kafka/pull/15557#issuecomment-2047083295 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-16297: Race condition while promoting future replica [kafka]

2024-04-10 Thread via GitHub
showuon commented on code in PR #15557: URL: https://github.com/apache/kafka/pull/15557#discussion_r1559170927 ## core/src/main/scala/kafka/server/ReplicaAlterLogDirsThread.scala: ## @@ -96,57 +97,55 @@ class ReplicaAlterLogDirsThread(name: String, } override def

[jira] [Resolved] (KAFKA-15568) Use incrementalAlterConfigs to update the dynamic config of broker in ConfigCommand tool

2024-04-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-15568. Resolution: Duplicate duplicate to KAFKA-16181 > Use incrementalAlterConfigs to update

[PR] KAFKA:-16399: Add JBOD support in tiered storage [kafka]

2024-04-10 Thread via GitHub
showuon opened a new pull request, #15690: URL: https://github.com/apache/kafka/pull/15690 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

Re: [PR] MINOR: Add type check to classic group timeout operations [kafka]

2024-04-10 Thread via GitHub
dajac merged PR #15587: URL: https://github.com/apache/kafka/pull/15587 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-16504) Flaky test org.apache.kafka.controller.QuorumControllerTest.testConfigurationOperations

2024-04-10 Thread Igor Soarez (Jira)
Igor Soarez created KAFKA-16504: --- Summary: Flaky test org.apache.kafka.controller.QuorumControllerTest.testConfigurationOperations Key: KAFKA-16504 URL: https://issues.apache.org/jira/browse/KAFKA-16504

Re: [PR] MINOR: Improve logging in AssignmentsManager [kafka]

2024-04-10 Thread via GitHub
soarez commented on PR #15522: URL: https://github.com/apache/kafka/pull/15522#issuecomment-2046961029 Failing tests are all unrelated and tracked: * kafka.api.DelegationTokenEndToEndAuthorizationWithOwnerTest."testNoConsumeWithDescribeAclViaAssign(String).quorum=kraft"

Re: [PR] KAFKA-16433: BeginningAndEndOffsets and OffsetsForTimes should send an event and return empty with zero timeout provided [kafka]

2024-04-10 Thread via GitHub
lucasbru merged PR #15688: URL: https://github.com/apache/kafka/pull/15688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16272: Adding new coordinator related changes for connect_distributed.py [kafka]

2024-04-10 Thread via GitHub
vamossagar12 commented on PR #15594: URL: https://github.com/apache/kafka/pull/15594#issuecomment-2047030266 @lucasbru , that test did pass. However, let me try again with the snippet you shared above and see if it works. Let me get back to you. -- This is an automated message from the

Re: [PR] MINOR: Improve logging in AssignmentsManager [kafka]

2024-04-10 Thread via GitHub
showuon commented on PR #15522: URL: https://github.com/apache/kafka/pull/15522#issuecomment-2047096126 @soarez , oops, there's conflict due to I've just merged another PR. Please help resolve it. Thanks. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Assigned] (KAFKA-15309) Add custom error handler to Producer

2024-04-10 Thread Alieh Saeedi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alieh Saeedi reassigned KAFKA-15309: Assignee: Alieh Saeedi > Add custom error handler to Producer >

[jira] [Commented] (KAFKA-16506) add the scala version of tool-related classes back to core module to follow KIP-906

2024-04-10 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835749#comment-17835749 ] PoAn Yang commented on KAFKA-16506: --- Hi [~chia7712], I'm interested in this. May I assign to myself?

[jira] [Updated] (KAFKA-16502) Fix flaky EOSUncleanShutdownIntegrationTest#shouldWorkWithUncleanShutdownWipeOutStateStore

2024-04-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16502: Labels: flaky-test (was: ) > Fix flaky >

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

2024-04-10 Thread via GitHub
dajac commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559600382 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

2024-04-10 Thread via GitHub
chia7712 commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559616179 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

2024-04-10 Thread via GitHub
OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559674776 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

2024-04-10 Thread via GitHub
OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559689777 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

2024-04-10 Thread via GitHub
OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559706475 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

2024-04-10 Thread via GitHub
chia7712 commented on PR #15684: URL: https://github.com/apache/kafka/pull/15684#issuecomment-2047933442 @OmniaGM it seems there are build error. could you fix them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (KAFKA-16506) add the scala version of tool-related classes back to core module to follow KIP-906

2024-04-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-16506: --- Summary: add the scala version of tool-related classes back to core module to follow

Re: [PR] KAFKA-15853: Move Sasl and SSL configs out of core [kafka]

2024-04-10 Thread via GitHub
chia7712 merged PR #15656: URL: https://github.com/apache/kafka/pull/15656 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15853: Move transactions configs out of core [kafka]

2024-04-10 Thread via GitHub
chia7712 commented on code in PR #15670: URL: https://github.com/apache/kafka/pull/15670#discussion_r1559526460 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManagerConfig.java: ## @@ -17,13 +17,12 @@ package

[jira] [Updated] (KAFKA-16502) Fix flaky EOSUncleanShutdownIntegrationTest#shouldWorkWithUncleanShutdownWipeOutStateStore

2024-04-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16502: Component/s: streams unit tests > Fix flaky >

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

2024-04-10 Thread via GitHub
OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559689777 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

2024-04-10 Thread via GitHub
chia7712 commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559398541 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import

Re: [PR] KAFKA-16103: commitSync and close should await pending async commits [kafka]

2024-04-10 Thread via GitHub
lucasbru commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1559430603 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java: ## @@ -229,7 +229,11 @@ private GroupRebalanceConfig

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

2024-04-10 Thread via GitHub
OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559529499 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

[jira] [Updated] (KAFKA-16505) KIP-1034: Dead letter queue in Kafka Streams

2024-04-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16505: Labels: KIP (was: ) > KIP-1034: Dead letter queue in Kafka Streams >

[jira] [Created] (KAFKA-16507) Add raw record into RecordDeserialisationException

2024-04-10 Thread Fred Rouleau (Jira)
Fred Rouleau created KAFKA-16507: Summary: Add raw record into RecordDeserialisationException Key: KAFKA-16507 URL: https://issues.apache.org/jira/browse/KAFKA-16507 Project: Kafka Issue

[PR] KAFKA-16507 Add raw record into RecordDeserialisationException [kafka]

2024-04-10 Thread via GitHub
fred-ro opened a new pull request, #15691: URL: https://github.com/apache/kafka/pull/15691 Add raw ConsumerRecord data to RecordDeserialisationException to make DLQ implementation easier *Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or

Re: [PR] KAFKA-15517: Improve MirrorMaker logging in case of authorization errors [kafka]

2024-04-10 Thread via GitHub
mimaison commented on code in PR #15558: URL: https://github.com/apache/kafka/pull/15558#discussion_r1559584216 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorUtils.java: ## @@ -320,4 +323,21 @@ static void createCompactedTopic(String topicName, short

Re: [PR] KAFKA-16389: ConsumerEventHandler does not support incremental assignment changes causing failure in system test [kafka]

2024-04-10 Thread via GitHub
philipnee commented on code in PR #15661: URL: https://github.com/apache/kafka/pull/15661#discussion_r1559662337 ## tests/kafkatest/services/verifiable_consumer.py: ## @@ -135,6 +135,28 @@ def last_commit(self, tp): else: return None +# This needs to be

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

2024-04-10 Thread via GitHub
OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559709137 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

[PR] KAFKA-16103: LegacyConsumer should always await pending async commits on commitSync and close [kafka]

2024-04-10 Thread via GitHub
lucasbru opened a new pull request, #15693: URL: https://github.com/apache/kafka/pull/15693 The javadoc for `KafkaConsumer.commitSync` says: > Note that asynchronous offset commits sent previously with the {https://github.com/link #commitAsync(OffsetCommitCallback)} > (or similar)

Re: [PR] KAFKA-9914: Fix replication cycle detection [kafka]

2024-04-10 Thread via GitHub
izmal commented on PR #10277: URL: https://github.com/apache/kafka/pull/10277#issuecomment-2047967071 I my case reason for replication cycle was: `replication.policy.separator = -` With another separator works without cycle (e.g '_'). :-) -- This is an automated message from the

[jira] [Assigned] (KAFKA-16506) add the scala version of tool-related class back to core module to follow KIP-906

2024-04-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16506: -- Assignee: Chia-Ping Tsai > add the scala version of tool-related class back to core

[jira] [Created] (KAFKA-16506) add the scala version of tool-related class back to core module to follow KIP-906

2024-04-10 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16506: -- Summary: add the scala version of tool-related class back to core module to follow KIP-906 Key: KAFKA-16506 URL: https://issues.apache.org/jira/browse/KAFKA-16506

Re: [PR] KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records [kafka]

2024-04-10 Thread via GitHub
vamossagar12 commented on PR #13801: URL: https://github.com/apache/kafka/pull/13801#issuecomment-2047548232 Chris, I started changing the tests in alignment with the comments (i.e using AtomicBoolean, AtomicReference and removing try-catch block). I noticed an interesting issue with

[jira] [Assigned] (KAFKA-15309) Add custom error handler to Producer

2024-04-10 Thread Alieh Saeedi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alieh Saeedi reassigned KAFKA-15309: Assignee: Alieh Saeedi > Add custom error handler to Producer >

[jira] [Updated] (KAFKA-16507) Add raw record into RecordDeserialisationException

2024-04-10 Thread Fred Rouleau (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fred Rouleau updated KAFKA-16507: - Labels: kip (was: ) > Add raw record into RecordDeserialisationException >

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

2024-04-10 Thread via GitHub
OmniaGM commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559689777 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import org.apache.kafka.common.record.CompressionType;

[jira] [Created] (KAFKA-16508) Infinte loop if output topic does not exisit

2024-04-10 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-16508: --- Summary: Infinte loop if output topic does not exisit Key: KAFKA-16508 URL: https://issues.apache.org/jira/browse/KAFKA-16508 Project: Kafka Issue

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

2024-04-10 Thread via GitHub
chia7712 commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559703336 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetConfig.java: ## @@ -20,16 +20,51 @@ import

Re: [PR] KAFKA-16103: AsyncConsumer should await pending async commits on commitSync and close [kafka]

2024-04-10 Thread via GitHub
lucasbru commented on PR #15613: URL: https://github.com/apache/kafka/pull/15613#issuecomment-2047945261 Hey @lianetm. I split the PR into two, the changes for the legacy consumer go into https://github.com/apache/kafka/pull/15693. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-16482: Eliminate the IDE warnings of accepting ClusterConfig in BeforeEach [kafka]

2024-04-10 Thread via GitHub
chia7712 commented on code in PR #15676: URL: https://github.com/apache/kafka/pull/15676#discussion_r1559385018 ## core/src/test/scala/integration/kafka/coordinator/transaction/ProducerIdsIntegrationTest.scala: ## @@ -19,32 +19,31 @@ package kafka.coordinator.transaction

[jira] [Assigned] (KAFKA-14517) Implement regex subscriptions

2024-04-10 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Phuc Hong Tran reassigned KAFKA-14517: -- Assignee: Phuc Hong Tran (was: Jimmy Wang) > Implement regex subscriptions >

Re: [PR] MINOR : Replaced the while loop with TestUtils.waitForCondition [kafka]

2024-04-10 Thread via GitHub
chia7712 commented on PR #15678: URL: https://github.com/apache/kafka/pull/15678#issuecomment-2047578617 > If the condition doesn't meet within the maxWaitMs, the waitForCondition would throw the assertion failure. Do we need another timeout to handle that? My origin thought was to

[jira] [Commented] (KAFKA-16506) add the scala version of tool-related classes back to core module to follow KIP-906

2024-04-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835754#comment-17835754 ] Chia-Ping Tsai commented on KAFKA-16506: [~yangpoan]thanks for taking over this jira. please

[jira] [Assigned] (KAFKA-16506) add the scala version of tool-related classes back to core module to follow KIP-906

2024-04-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16506: -- Assignee: PoAn Yang (was: Chia-Ping Tsai) > add the scala version of tool-related

[jira] [Commented] (KAFKA-16336) Remove Deprecated metric standby-process-ratio

2024-04-10 Thread Kiriakos Marantidis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835763#comment-17835763 ] Kiriakos Marantidis commented on KAFKA-16336: - Hi [~mjsax] , I would like to work on this

[jira] [Updated] (KAFKA-16505) KIP-1034: Dead letter queue in Kafka Streams

2024-04-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16505: Component/s: streams > KIP-1034: Dead letter queue in Kafka Streams >

Re: [PR] KAFKA-16103: LegacyConsumer should always await pending async commits on commitSync and close [kafka]

2024-04-10 Thread via GitHub
lucasbru commented on PR #15693: URL: https://github.com/apache/kafka/pull/15693#issuecomment-2047947707 @lianetm You have reviewed those changes already as part of https://github.com/apache/kafka/pull/15613 . -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

2024-04-10 Thread via GitHub
OmniaGM commented on PR #15684: URL: https://github.com/apache/kafka/pull/15684#issuecomment-2047947749 ugh my local environment keep the wrong caches because I keep jump between branches -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-15853: Move consumer group and group coordinator configs out of core [kafka]

2024-04-10 Thread via GitHub
chia7712 commented on code in PR #15684: URL: https://github.com/apache/kafka/pull/15684#discussion_r1559774590 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java: ## @@ -16,14 +16,132 @@ */ package

Re: [PR] KAFKA-16433: BeginningAndEndOffsets and OffsetsForTimes should send an event and return empty with zero timeout provided [kafka]

2024-04-10 Thread via GitHub
kirktrue commented on PR #15688: URL: https://github.com/apache/kafka/pull/15688#issuecomment-2048148062 @philipnee—sorry I'm late to the party, but why do we submit the event to the queue when the timeout is 0? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] KAFKA-7632: Support Compression Level [kafka]

2024-04-10 Thread via GitHub
mimaison commented on PR #10826: URL: https://github.com/apache/kafka/pull/10826#issuecomment-2048127235 I opened https://github.com/apache/kafka/pull/15516 to implement this KIP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-7632: Support Compression Levels (KIP-390) [kafka]

2024-04-10 Thread via GitHub
mimaison commented on PR #15516: URL: https://github.com/apache/kafka/pull/15516#issuecomment-2048128916 @divijvaidya It seems you've done a bit of work around compression in the past. Can you take a look? Thanks -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] KAFKA-16103: AsyncConsumer should await pending async commits on commitSync and close [kafka]

2024-04-10 Thread via GitHub
kirktrue commented on code in PR #15613: URL: https://github.com/apache/kafka/pull/15613#discussion_r1559907295 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -157,8 +157,10 @@ public class AsyncKafkaConsumerTest {

Re: [PR] KAFKA-16389: ConsumerEventHandler does not support incremental assignment changes causing failure in system test [kafka]

2024-04-10 Thread via GitHub
lucasbru commented on code in PR #15661: URL: https://github.com/apache/kafka/pull/15661#discussion_r1559790393 ## tests/kafkatest/services/verifiable_consumer.py: ## @@ -135,6 +135,28 @@ def last_commit(self, tp): else: return None +# This needs to be

Re: [PR] KAFKA-16389: ConsumerEventHandler does not support incremental assignment changes causing failure in system test [kafka]

2024-04-10 Thread via GitHub
lucasbru merged PR #15661: URL: https://github.com/apache/kafka/pull/15661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

2024-04-10 Thread via GitHub
kirktrue commented on PR #15408: URL: https://github.com/apache/kafka/pull/15408#issuecomment-2048153273 @lucasbru—sorry that I've forgotten, but why don't we want to merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Resolved] (KAFKA-16294) Add group protocol migration enabling config

2024-04-10 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-16294. - Fix Version/s: 3.8.0 Resolution: Fixed > Add group protocol migration enabling config >

Re: [PR] KAFKA-16294: Add group protocol migration enabling config [kafka]

2024-04-10 Thread via GitHub
dajac merged PR #15411: URL: https://github.com/apache/kafka/pull/15411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-16466) QuorumController is swallowing some exception messages

2024-04-10 Thread Ilya Zakharov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835846#comment-17835846 ] Ilya Zakharov commented on KAFKA-16466: --- [~chiacyu] Hello! Сan you tell me if you're working on

[jira] [Created] (KAFKA-16509) CurrentControllerId metric is unreliable in ZK mode

2024-04-10 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-16509: Summary: CurrentControllerId metric is unreliable in ZK mode Key: KAFKA-16509 URL: https://issues.apache.org/jira/browse/KAFKA-16509 Project: Kafka Issue

Re: [PR] KAFKA:-16399: Add JBOD support in tiered storage [kafka]

2024-04-10 Thread via GitHub
soarez commented on code in PR #15690: URL: https://github.com/apache/kafka/pull/15690#discussion_r1560139446 ## core/src/main/java/kafka/server/TierStateMachine.java: ## @@ -40,7 +92,72 @@ public interface TierStateMachine { */ PartitionFetchState

[PR] KAFKA-16211: Inconsistent config values in CreateTopicsResult and DescribeConfigsResult [kafka]

2024-04-10 Thread via GitHub
infantlikesprogramming opened a new pull request, #15696: URL: https://github.com/apache/kafka/pull/15696 *When creating a topic in KRaft cluster, a config value returned by createTopics() is different than what you get from describeConfigs().​* *My guess from reading the code is

Re: [PR] KAFKA-16509: CurrentControllerId metric is unreliable in ZK mode [kafka]

2024-04-10 Thread via GitHub
mumrah commented on code in PR #15695: URL: https://github.com/apache/kafka/pull/15695#discussion_r1560161829 ## core/src/main/scala/kafka/server/KafkaServer.scala: ## @@ -657,15 +657,19 @@ class KafkaServer( } private def createCurrentControllerIdMetric(): Unit = { -

  1   2   >