insistedMarin commented on PR #1919: URL: https://github.com/apache/iggy/pull/1919#issuecomment-3018212758
> I am not sure if the abstraction is put in the right place for this feature. > > I think it would be better of if the Consumer/Producer was hidden behind another layer (either enum or a struct with generic type determining whether its low-level or high-level client), and it gets method injected into the benchmark scenarios, rather than implementing different backends for each one. This way the code would be more composable, currently there is a lot of code that both looks ugly (those associated types such as (Producer, Identifier, Identifer) ), as well as quite a bit repetitive. Thank you very much for the feedback! That makes a lot of sense — I’ll go ahead and refactor the code to introduce a unified client trait and inject it into the benchmark logic, as you suggested. This should help reduce duplication and improve composability. Appreciate the detailed suggestion! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
