numinnex commented on code in PR #1919:
URL: https://github.com/apache/iggy/pull/1919#discussion_r2188044799
##########
core/bench/src/actors/consumer/benchmark_consumer.rs:
##########
@@ -74,81 +75,56 @@ impl BenchmarkConsumer {
origin_timestamp_latency_calculation,
};
- let backend = if use_high_level_api {
- ConsumerBackend::HighLevel(HighLevelBackend::new(client_factory,
config.clone()))
+ let (client, api_label): (Box<dyn ConsumerClient>, &'static str) = if
use_high_level_api {
Review Comment:
I think this `api_label` can be moved as a `static` to the trait definition
```rs
pub trait Foo {
static NAME: &str;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
