insistedMarin commented on PR #1919: URL: https://github.com/apache/iggy/pull/1919#issuecomment-3046369555
> That's definitely step in the right direction. > > One thing right out of the bat that I would change is moving the `setup` method to seperate trait something like `BenchmarkSetup` rather than sticking it to `ProducerClient` and `ConsumerClient`. > > This way when implementing `ProducingConsumingClient`, you can put trait bounds on that trait: > > ```rust > pub trait ProducingConsumingClient + ProducerClient + ConsumerClient + BenchmarkSetup > ``` > > So you don't drag the unnecessary `setup` methods together with `ProducerClient` and `ConsumerClient`. Thanks for the suggestion! I've split setup and api_label into separate traits as proposed, and cleaned up the client traits accordingly. Let me know if anything else needs adjustment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
