insistedMarin commented on PR #1919: URL: https://github.com/apache/iggy/pull/1919#issuecomment-3067225455
Thanks for the feedback @numinnex! 🙌 I've addressed the requested changes: Replaced Box<dyn BenchmarkConsumerClient> / ProducerClient with generic parameters and removed #[async_trait] by making the traits fully generic. Moved initialization logic into the setup method in BenchmarkInit. Changed api_label from a method to a const in the ApiLabel trait. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
