numinnex commented on code in PR #1919:
URL: https://github.com/apache/iggy/pull/1919#discussion_r2230364493
##########
core/bench/src/benchmarks/common.rs:
##########
@@ -263,19 +266,28 @@ pub fn build_producing_consumers_futures(
&args,
BenchmarkFinishConditionMode::PerProducingConsumer,
);
-
+ let origin_timestamp_latency_calculation = match args.kind() {
+ BenchmarkKind::PinnedConsumer
+ | BenchmarkKind::PinnedProducerAndConsumer
+ | BenchmarkKind::BalancedConsumerGroup // TODO(hubcio): in
future, PinnedProducerAndConsumer can also be true
+ | BenchmarkKind::EndToEndProducingConsumer => false,
+ BenchmarkKind::BalancedProducerAndConsumerGroup => true,
+ _ => unreachable!(),
+ };
+ let use_high_level_api = args.high_level_api();
let rate_limit = rate_limit_per_actor(args.rate_limit(),
producing_consumers);
async move {
info!(
"Executing producing consumer #{}, stream_id={}",
actor_id, stream_id
);
- let actor = BenchmarkProducingConsumer::new(
+ let actor = TypedBenchmarkProducingConsumer::new(
+ use_high_level_api,
client_factory_clone,
args_clone.kind(),
actor_id,
- None,
+ None, // consumer_group_id
Review Comment:
remove that commented consumer_group_id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
