numinnex commented on code in PR #1919:
URL: https://github.com/apache/iggy/pull/1919#discussion_r2188045880
##########
core/bench/src/actors/consumer/benchmark_consumer.rs:
##########
@@ -74,81 +75,56 @@ impl BenchmarkConsumer {
origin_timestamp_latency_calculation,
};
- let backend = if use_high_level_api {
- ConsumerBackend::HighLevel(HighLevelBackend::new(client_factory,
config.clone()))
+ let (client, api_label): (Box<dyn ConsumerClient>, &'static str) = if
use_high_level_api {
Review Comment:
Probably the `BenchmarkSetup` trait that I proposed in the comment under PR
is good place for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
