numinnex commented on PR #1919:
URL: https://github.com/apache/iggy/pull/1919#issuecomment-3040986165
That's definitely step in the right direction.
One thing right out of the bat that I would change is moving the `setup`
method to seperate trait something like `BenchmarkSetup` rather than sticking
it to `ProducerClient` and `ConsumerClient`.
This way when implementing `ProducingConsumingClient`, you can put trait
bounds on that trait:
```rs
pub trait ProducingConsumingClient + ProducerClient + ConsumerClient
+ BenchmarkSetup
````
So you don't drag the unnecessary methods together with `ProducerClient` and
`ConsumerClient`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
