acassis commented on code in PR #6815:
URL: https://github.com/apache/incubator-nuttx/pull/6815#discussion_r941424907
##########
arch/mips/src/pic32mx/pic32mx_lowinit.c:
##########
@@ -192,6 +247,12 @@ void pic32mx_lowinit(void)
up_earlyserialinit();
#endif
+#if CONFIG_PIC32MX_JTAG_ENABLE
Review Comment:
Please fix these compilation errors:
```
chip/pic32mx_lowinit.c: In function 'pic32mx_disable_jtag':
Error: chip/pic32mx_lowinit.c:172:21: error: unused variable 'regval'
[-Werror=unused-variable]
register uint32_t regval;
^
chip/pic32mx_lowinit.c: In function 'pic32mx_enable_jtag':
Error: chip/pic32mx_lowinit.c:199:21: error: unused variable 'regval'
[-Werror=unused-variable]
register uint32_t regval;
^
chip/pic32mx_lowinit.c: In function 'pic32mx_lowinit':
Error: chip/pic32mx_lowinit.c:250:5: error: "CONFIG_PIC32MX_JTAG_ENABLE" is
not defined [-Werror=undef]
#if CONFIG_PIC32MX_JTAG_ENABLE
^
cc1: all warnings being treated as errors
make[1]: *** [Makefile:82: pic32mx_lowinit.o] Error 1
make[1]: Target 'libarch.a' not remade because of errors.
make: *** [tools/LibTargets.mk:152: arch/mips/src/libarch.a] Error 2
make: Target 'all' not remade because of errors.
/github/workspace/sources/nuttx/tools/testbuild.sh: line 290:
/github/workspace/sources/nuttx/../nuttx/nuttx.manifest: No such file or
directory
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
